)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03746a41ef66e04de26f498b2ec394911a319fcb","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"                                                  active image)"},{"line_number":1962,"context_line":"          }"},{"line_number":1963,"context_line":"        \"\"\""},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"        LOG.debug(\u0027volume_snapshot_delete: delete_info: %s\u0027, delete_info,"},{"line_number":1966,"context_line":"                  instance\u003dinstance)"},{"line_number":1967,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1becc18e","side":"PARENT","line":1964,"updated":"2016-08-24 15:56:47.000000000","message":"No reason I can see to remove this blank line; consider reverting, as I feel the whitespace adds readability here.","commit_id":"1423be58b5e3aa26c85296968146e9d6ed59455a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03746a41ef66e04de26f498b2ec394911a319fcb","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                      *qemu_img_extra_arg)"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"    def _volume_snapshot_check(self, gcow\u003dNone, get_guest\u003dNone,"},{"line_number":1946,"context_line":"                                          notfound\u003dNone):"},{"line_number":1947,"context_line":"        if gcow is not None:"},{"line_number":1948,"context_line":"            if gcow !\u003d \u0027qcow2\u0027:"},{"line_number":1949,"context_line":"                msg \u003d _(\u0027Unknown delete_info type %s\u0027) % gcow"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_5bac7935","line":1946,"updated":"2016-08-24 15:56:47.000000000","message":"This feels like another swiss army knife style function.  Here the thing to do is leave the code where it is or break the bits up into individual functions.","commit_id":"24d3656bee4468029c596826cecee4d9ff7357d9"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6740d2c63d8cf5b0652b0accf201fc5a89af5167","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                      *qemu_img_extra_arg)"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"    def _volume_snapshot_check(self, gcow\u003dNone, get_guest\u003dNone,"},{"line_number":1946,"context_line":"                                          notfound\u003dNone):"},{"line_number":1947,"context_line":"        if gcow is not None:"},{"line_number":1948,"context_line":"            if gcow !\u003d \u0027qcow2\u0027:"},{"line_number":1949,"context_line":"                msg \u003d _(\u0027Unknown delete_info type %s\u0027) % gcow"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_240fa8e2","line":1946,"in_reply_to":"1ac06dbe_5bac7935","updated":"2016-08-26 06:12:20.000000000","message":"Right. Those are three unrelated cases, why would we care to enclose them inside one particular function?","commit_id":"24d3656bee4468029c596826cecee4d9ff7357d9"}]}