)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c0c9bcdd8878bd07b64b1e5aa0164d7b81895179","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Check server group members quota if needed"},{"line_number":305,"context_line":"        if check_server_group_quota and instance_group:"},{"line_number":306,"context_line":"            count \u003d objects.Quotas.count(context,"},{"line_number":307,"context_line":"                                         \u0027server_group_members\u0027,"},{"line_number":308,"context_line":"                                         instance_group,"},{"line_number":309,"context_line":"                                         context.user_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_a6b26e92","line":306,"range":{"start_line":306,"start_character":35,"end_line":306,"end_character":40},"updated":"2016-08-29 11:24:31.000000000","message":"if some quota update after this action\nwill this be a race condition? \n\nas you store count in local var and this can be a dirty read?","commit_id":"656077988f36e8b352e39bd44aeeed396bba3596"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"536042340e0c135d8b377dc7a801fa7be785da73","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Check server group members quota if needed"},{"line_number":305,"context_line":"        if check_server_group_quota and instance_group:"},{"line_number":306,"context_line":"            count \u003d objects.Quotas.count(context,"},{"line_number":307,"context_line":"                                         \u0027server_group_members\u0027,"},{"line_number":308,"context_line":"                                         instance_group,"},{"line_number":309,"context_line":"                                         context.user_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_8cfc5db9","line":306,"range":{"start_line":306,"start_character":35,"end_line":306,"end_character":40},"in_reply_to":"fa7ab95a_2ac34758","updated":"2016-08-30 12:04:36.000000000","message":"I am afraid you can\u0027t...\n\nhttps://github.com/openstack/nova/blob/master/nova/quota.py#L1544\n\nmy understanding is it\u0027s not not reserveable now","commit_id":"656077988f36e8b352e39bd44aeeed396bba3596"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a41e6d279efbe8db78dc961f8e88d656a1371daf","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Check server group members quota if needed"},{"line_number":305,"context_line":"        if check_server_group_quota and instance_group:"},{"line_number":306,"context_line":"            count \u003d objects.Quotas.count(context,"},{"line_number":307,"context_line":"                                         \u0027server_group_members\u0027,"},{"line_number":308,"context_line":"                                         instance_group,"},{"line_number":309,"context_line":"                                         context.user_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_2ac34758","line":306,"range":{"start_line":306,"start_character":35,"end_line":306,"end_character":40},"in_reply_to":"fa7ab95a_a6b26e92","updated":"2016-08-30 06:40:37.000000000","message":"yes, I was thinking adding quota reserve here. Since it is getting complecated.","commit_id":"656077988f36e8b352e39bd44aeeed396bba3596"}]}