)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"655f12cdee5235d4ce7eba5c12bac15c32121864","unresolved":false,"context_lines":[{"line_number":23,"context_line":"methods on the ResourceProvider object."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id0355cb022f68e962af306ff04cf724d22b68d19"},{"line_number":26,"context_line":"Partially-Implements: blueprint generic-resource-pools"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a95cdbc_268517ce","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":54},"updated":"2016-10-10 14:02:25.000000000","message":"Sorry for being a process nanny but this blueprint was closed in Newton as being partially completed. So can we open a new tracking blueprint for Ocata work please? We don\u0027t need a spec re-proposal unless something major has changed in the design. You could call it generic-resource-pools-ocata, or scope it specifically to the aggregates parts of the grp spec if you wanted, doesn\u0027t matter to me, we just shouldn\u0027t use this bp since it\u0027s closed.","commit_id":"e736baaad191138f2bd6829a99af5e9115861988"}],"nova/db/sqlalchemy/api_migrations/migrate_repo/versions/026_placement_aggregates.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"97c7a06b9ddfade44023148a47395d98e266048a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027uuid\u0027, String(length\u003d36), index\u003dTrue, unique\u003dTrue),"},{"line_number":31,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":32,"context_line":"        mysql_charset\u003d\u0027latin1\u0027"},{"line_number":33,"context_line":"    )"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    placement_aggregates.create(checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_9deec4b2","line":32,"range":{"start_line":32,"start_character":23,"end_line":32,"end_character":29},"updated":"2016-10-06 08:41:43.000000000","message":"nit: not that it should matter here, but we could use utf-8 just for the sake of consistency with all other tables","commit_id":"e736baaad191138f2bd6829a99af5e9115861988"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e44ba0fd38640065bde4d29b5442fe49d3e3480d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027uuid\u0027, String(length\u003d36), index\u003dTrue, unique\u003dTrue),"},{"line_number":31,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":32,"context_line":"        mysql_charset\u003d\u0027latin1\u0027"},{"line_number":33,"context_line":"    )"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    placement_aggregates.create(checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_7a057978","line":32,"in_reply_to":"1a95cdbc_9a9fa5b3","updated":"2016-10-06 10:02:38.000000000","message":"Got it, thanks for clarifications!\n\nP.S. I don\u0027t remember the details now, but we had some issues with changing of the charset of the existing tables  in Heat in the past. Hope, we won\u0027t need to do that here ;)","commit_id":"e736baaad191138f2bd6829a99af5e9115861988"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4931349645bceeddc034edde22a8dfd31629bca7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027uuid\u0027, String(length\u003d36), index\u003dTrue, unique\u003dTrue),"},{"line_number":31,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":32,"context_line":"        mysql_charset\u003d\u0027latin1\u0027"},{"line_number":33,"context_line":"    )"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    placement_aggregates.create(checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_9a9fa5b3","line":32,"in_reply_to":"1a95cdbc_9deec4b2","updated":"2016-10-06 09:52:04.000000000","message":"Jay\u0027s been pretty strongly opposed in the past when tables have been utf-8 without needing to be. We\u0027ve made an effort throughout the resource provider tables to stick with latin1 where it is possible.","commit_id":"e736baaad191138f2bd6829a99af5e9115861988"}],"nova/db/sqlalchemy/api_migrations/migrate_repo/versions/027_placement_aggregates.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"899e630fe06881a7bc3d475a50306133908b8521","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":28,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":29,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027uuid\u0027, String(length\u003d36), index\u003dTrue, unique\u003dTrue),"},{"line_number":31,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":32,"context_line":"        mysql_charset\u003d\u0027latin1\u0027"},{"line_number":33,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_be138565","line":30,"updated":"2016-10-12 16:31:10.000000000","message":"Remove the unique\u003dTrue and use a UniqueConstraint object where you can explicitly set the name of the constraint to match the oslo.db constraint-naming convention.\n\nPlease see here for an example of how to do this:\n\nhttps://review.openstack.org/#/c/379654/6/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/026_add_resource_classes.py\n\nline 31","commit_id":"617bdfbbb03c6f491bac8cbeebf4b1ff8ebcb920"}]}