)]}'
{"nova/cells/rpcapi.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"c96feb82e0a43e2207de06777557277b52760b25","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        1.14 - Adds reboot_instance()"},{"line_number":74,"context_line":"        1.15 - Adds suspend_instance() and resume_instance()"},{"line_number":75,"context_line":"        1.16 - Adds instance_update_from_api()"},{"line_number":76,"context_line":"        1.17 - Adds delete() and soft_delete()"},{"line_number":77,"context_line":"    \u0027\u0027\u0027"},{"line_number":78,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAQn%2F%2Fp9w%3D","line":76,"updated":"2013-07-25 17:32:09.000000000","message":"terminate_instance and soft_delete_instance","commit_id":"392e9f1f7b1a1f60a602215189f399115f3f3056"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3b06fe973fbedbb174a06b94ead2ed85457f6283","unresolved":false,"context_lines":[{"line_number":471,"context_line":"            return"},{"line_number":472,"context_line":"        self.cast(ctxt,"},{"line_number":473,"context_line":"                  self.make_msg(\u0027terminate_instance\u0027, instance\u003dinstance,"},{"line_number":474,"context_line":"                                bdms\u003dbdms),"},{"line_number":475,"context_line":"                  version\u003d\u00271.17\u0027)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def soft_delete_instance(self, ctxt, instance, reservations\u003dNone):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAQn%2F%2Fm1U%3D","line":474,"updated":"2013-07-26 18:10:56.000000000","message":"The manager method doesn\u0027t take bdms...  I\u0027d just leave them unused here like reservations.","commit_id":"f9ae08feb51df3e8038cc5a62e4404a49b9f5212"}],"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"c96feb82e0a43e2207de06777557277b52760b25","unresolved":false,"context_lines":[{"line_number":1172,"context_line":"            instance.save()"},{"line_number":1173,"context_line":"            new_type_id \u003d (instance_attrs[\u0027instance_type_id\u0027]"},{"line_number":1174,"context_line":"                           if \u0027instance_type_id\u0027 in instance_attrs"},{"line_number":1175,"context_line":"                           else instance.instance_type_id)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"            # NOTE(comstud): If we delete the instance locally, we\u0027ll"},{"line_number":1178,"context_line":"            # commit the reservations here.  Otherwise, the manager side"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAQn%2F%2FqDI%3D","line":1175,"updated":"2013-07-25 17:32:09.000000000","message":"Seems like you could just use instance.instance_type_id always, right?","commit_id":"392e9f1f7b1a1f60a602215189f399115f3f3056"}],"nova/compute/cells_api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"c96feb82e0a43e2207de06777557277b52760b25","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            delete_type \u003d method_name \u003d\u003d \u0027soft_delete\u0027 and \u0027soft\u0027 or \u0027hard\u0027"},{"line_number":207,"context_line":"            self.cells_rpcapi.instance_delete_everywhere(context,"},{"line_number":208,"context_line":"                    instance, delete_type)"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"},{"line_number":212,"context_line":"        method(context, instance)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAQn%2F%2Fp94%3D","line":209,"updated":"2013-07-25 17:32:09.000000000","message":"Somehow we need _local_delete() to run before we can return... so that the DB entry gets nuked in this cell (API cell).  If you simply removed the \u0027return\u0027 here, you end up with an exception raised when super()ing below... because you added the @check_instance_cell decorator in api.py.... so we can\u0027t do that alone.\n\nHm.  I wonder if it\u0027s best to just nuke all of this code in this file... and incorporate it into api.py.. it shouldn\u0027t be that bad.  I can show you a diff against this shortly...","commit_id":"392e9f1f7b1a1f60a602215189f399115f3f3056"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"cf5be89c2099ebeae805fb9d42c478e210c03e29","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            delete_type \u003d method_name \u003d\u003d \u0027soft_delete\u0027 and \u0027soft\u0027 or \u0027hard\u0027"},{"line_number":207,"context_line":"            self.cells_rpcapi.instance_delete_everywhere(context,"},{"line_number":208,"context_line":"                    instance, delete_type)"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"},{"line_number":212,"context_line":"        method(context, instance)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAQn%2F%2FpuA%3D","line":209,"in_reply_to":"AAAAQn%2F%2Fp0o%3D","updated":"2013-07-25 19:00:33.000000000","message":"We\u0027ll need to pull out any bdms in here to pass into it, since it takes them as an argument.  And I feel like that starts duplicating too much code... or well, I think I was already past the point of duplicating too much code ;)","commit_id":"392e9f1f7b1a1f60a602215189f399115f3f3056"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"005123b6c2072c2b1ba9db9ce2acbbf28155ee47","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            delete_type \u003d method_name \u003d\u003d \u0027soft_delete\u0027 and \u0027soft\u0027 or \u0027hard\u0027"},{"line_number":207,"context_line":"            self.cells_rpcapi.instance_delete_everywhere(context,"},{"line_number":208,"context_line":"                    instance, delete_type)"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"},{"line_number":212,"context_line":"        method(context, instance)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAQn%2F%2Fp0o%3D","line":209,"in_reply_to":"AAAAQn%2F%2Fp94%3D","updated":"2013-07-25 18:18:07.000000000","message":"Hmm, why can\u0027t we just call super()._local_delete before the return?","commit_id":"392e9f1f7b1a1f60a602215189f399115f3f3056"}]}