)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7305f180770cf1f9f6ecf70472895a9641151098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a89bdaa_4c1e70bb","updated":"2016-09-05 16:10:12.000000000","message":"nit: commit messages should generally be wrapped at 72 (or 71) characters, except for the 50 (49) character summary line","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a741c5cc30d96191760820b0790474883ddce6e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a89bdaa_e9f06d69","in_reply_to":"9a89bdaa_4c1e70bb","updated":"2016-09-08 12:05:31.000000000","message":"Done","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7305f180770cf1f9f6ecf70472895a9641151098","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PCI: Fix pci_passthrough_whitelist with fully qualified PF PCI address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Specifying a PF passthrough device in the pci_passthrough_whitelist using it\u0027s"},{"line_number":10,"context_line":"fully qualified PCI address (no wildcard) causes the device to not be"},{"line_number":11,"context_line":"properly loaded.  The PCI device is then not available to be assigned to any"},{"line_number":12,"context_line":"guest."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_8c1798a2","line":9,"range":{"start_line":9,"start_character":74,"end_line":9,"end_character":78},"updated":"2016-09-05 16:10:12.000000000","message":"nit: its","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a741c5cc30d96191760820b0790474883ddce6e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PCI: Fix pci_passthrough_whitelist with fully qualified PF PCI address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Specifying a PF passthrough device in the pci_passthrough_whitelist using it\u0027s"},{"line_number":10,"context_line":"fully qualified PCI address (no wildcard) causes the device to not be"},{"line_number":11,"context_line":"properly loaded.  The PCI device is then not available to be assigned to any"},{"line_number":12,"context_line":"guest."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_29e7b5ac","line":9,"range":{"start_line":9,"start_character":74,"end_line":9,"end_character":78},"in_reply_to":"9a89bdaa_8c1798a2","updated":"2016-09-08 12:05:31.000000000","message":"Done","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7305f180770cf1f9f6ecf70472895a9641151098","unresolved":false,"context_lines":[{"line_number":12,"context_line":"guest."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this case, the hypervisor reports the PF device without a \u0027parent_addr\u0027."},{"line_number":15,"context_line":"But in the PciAddress, match() is using it when doing the comparison to it\u0027s"},{"line_number":16,"context_line":"own address."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This commit changes the logic of the address matching method in PciDevSpec to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_ac837ccb","line":15,"range":{"start_line":15,"start_character":72,"end_line":15,"end_character":76},"updated":"2016-09-05 16:10:12.000000000","message":"nit: its\n\nIn case it helps (hope I\u0027m being helpful and not condescending :))\n\n    http://grammarist.com/spelling/its-its/","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a741c5cc30d96191760820b0790474883ddce6e3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"guest."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this case, the hypervisor reports the PF device without a \u0027parent_addr\u0027."},{"line_number":15,"context_line":"But in the PciAddress, match() is using it when doing the comparison to it\u0027s"},{"line_number":16,"context_line":"own address."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This commit changes the logic of the address matching method in PciDevSpec to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_69b37d98","line":15,"range":{"start_line":15,"start_character":72,"end_line":15,"end_character":76},"in_reply_to":"9a89bdaa_ac837ccb","updated":"2016-09-08 12:05:31.000000000","message":"Thanks Stephen !","commit_id":"3091baf5358dfa8a9428ea9628bffc7ee5b343d5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"71606ba3ffe48ac3d3c9e6b6e14b6b29b3c8cd4c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u0027parent_addr\u0027 is reported by the hypervisor."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5255240871d8ad5c216500f39520339efe46e84b"},{"line_number":23,"context_line":"Closes-Bug: #1618984"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_275d4b79","line":23,"updated":"2016-11-02 18:30:59.000000000","message":"I marked the above as a duplicate of 1613434. Please update the above to be 1613434","commit_id":"29a7b1ab7e6957d435e0f9c0580ef5abb5f07f23"}],"nova/tests/unit/pci/test_devspec.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"71606ba3ffe48ac3d3c9e6b6e14b6b29b3c8cd4c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        pci \u003d devspec.PciDeviceSpec(pci_info)"},{"line_number":102,"context_line":"        self.assertTrue(pci.match(dev))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @mock.patch(\u0027nova.pci.utils.is_physical_function\u0027, return_value \u003d True)"},{"line_number":105,"context_line":"    def test_address_pf_no_parent_addr(self, mock_is_physical_function):"},{"line_number":106,"context_line":"        _dev \u003d dev.copy()"},{"line_number":107,"context_line":"        _dev.pop(\u0027parent_addr\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_a2b4e934","line":104,"updated":"2016-11-02 18:30:59.000000000","message":"pep8 will ding you here (or should at least). There should be no space between return_value and True.","commit_id":"29a7b1ab7e6957d435e0f9c0580ef5abb5f07f23"}]}
