)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3feeb6028c9f517d17d71ba7c97fafd9b1f47de0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is some cellsv2 code that\u0027s conditional upon the nova-api services"},{"line_number":10,"context_line":"all being above a specific service version. However the lookup was"},{"line_number":11,"context_line":"checking for the \u0027nova-api\u0027 service version which returns the default of"},{"line_number":12,"context_line":"0 because the actual registered service is \u0027nova-os_compute\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I97a5d8472cc09ae64203de1c91d0db6ec59d83de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_093a8d98","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":59},"updated":"2016-08-31 20:24:16.000000000","message":"nova-osapi_compute","commit_id":"2fbda9afd8b556a128c39a902a5e889dd8a1e15d"}],"nova/compute/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58b9e4dafdfb844661617dfe18e6020065ca9626","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        # Before service version 15 deletion of the BuildRequest has no effect"},{"line_number":1607,"context_line":"        # and will be cleaned up as part of the boot process."},{"line_number":1608,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":1609,"context_line":"            context, \u0027nova-os_compute\u0027)"},{"line_number":1610,"context_line":"        if service_version \u003c 15:"},{"line_number":1611,"context_line":"            return False"},{"line_number":1612,"context_line":"        deleted \u003d self._attempt_delete_of_buildrequest(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_63e7b812","line":1609,"range":{"start_line":1609,"start_character":22,"end_line":1609,"end_character":37},"updated":"2016-08-31 19:41:44.000000000","message":"Are we sure this isn\u0027t supposed to be \u0027nova-osapi_compute\u0027? I don\u0027t find \u0027nova-os_compute\u0027 anywhere else in the code.","commit_id":"29a870baa6630186563703a113aa2c992c9449c3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"5d14992c7629c0ad9a15747285d206a3624c9e7e","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        # Before service version 15 deletion of the BuildRequest has no effect"},{"line_number":1607,"context_line":"        # and will be cleaned up as part of the boot process."},{"line_number":1608,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":1609,"context_line":"            context, \u0027nova-os_compute\u0027)"},{"line_number":1610,"context_line":"        if service_version \u003c 15:"},{"line_number":1611,"context_line":"            return False"},{"line_number":1612,"context_line":"        deleted \u003d self._attempt_delete_of_buildrequest(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_43d474bc","line":1609,"range":{"start_line":1609,"start_character":22,"end_line":1609,"end_character":37},"in_reply_to":"fa7ab95a_6326d817","updated":"2016-08-31 19:51:02.000000000","message":"You\u0027re right, that comment is wrong.","commit_id":"29a870baa6630186563703a113aa2c992c9449c3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"24d55440cc74d2f8df020deb9d40409b3f75fa58","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        # Before service version 15 deletion of the BuildRequest has no effect"},{"line_number":1607,"context_line":"        # and will be cleaned up as part of the boot process."},{"line_number":1608,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":1609,"context_line":"            context, \u0027nova-os_compute\u0027)"},{"line_number":1610,"context_line":"        if service_version \u003c 15:"},{"line_number":1611,"context_line":"            return False"},{"line_number":1612,"context_line":"        deleted \u003d self._attempt_delete_of_buildrequest(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_6326d817","line":1609,"range":{"start_line":1609,"start_character":22,"end_line":1609,"end_character":37},"in_reply_to":"fa7ab95a_63e7b812","updated":"2016-08-31 19:47:52.000000000","message":"According to http://git.openstack.org/cgit/openstack/nova/tree/nova/service.py#n282 it\u0027s nova-os_compute.","commit_id":"29a870baa6630186563703a113aa2c992c9449c3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58b9e4dafdfb844661617dfe18e6020065ca9626","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        # there is an instance mapping we don\u0027t need to honor it for older"},{"line_number":2144,"context_line":"        # service versions."},{"line_number":2145,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":2146,"context_line":"            context, \u0027nova-api\u0027)"},{"line_number":2147,"context_line":"        if service_version \u003c 15:"},{"line_number":2148,"context_line":"            return objects.Instance.get_by_uuid(context, instance_uuid,"},{"line_number":2149,"context_line":"                                                expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_43ae3499","line":2146,"range":{"start_line":2146,"start_character":21,"end_line":2146,"end_character":31},"updated":"2016-08-31 19:41:44.000000000","message":"Is this one okay as is? I don\u0027t know the difference between nova-api and nova-osapi_compute","commit_id":"29a870baa6630186563703a113aa2c992c9449c3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"24d55440cc74d2f8df020deb9d40409b3f75fa58","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        # there is an instance mapping we don\u0027t need to honor it for older"},{"line_number":2144,"context_line":"        # service versions."},{"line_number":2145,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":2146,"context_line":"            context, \u0027nova-api\u0027)"},{"line_number":2147,"context_line":"        if service_version \u003c 15:"},{"line_number":2148,"context_line":"            return objects.Instance.get_by_uuid(context, instance_uuid,"},{"line_number":2149,"context_line":"                                                expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_83f3dc9e","line":2146,"range":{"start_line":2146,"start_character":21,"end_line":2146,"end_character":31},"in_reply_to":"fa7ab95a_43ae3499","updated":"2016-08-31 19:47:52.000000000","message":"Nope, this should change too. There is no \u0027nova-api\u0027 service. I based this off of http://git.openstack.org/cgit/openstack/nova/tree/nova/service.py#n282 , but I have a logging patch up to try to confirm.","commit_id":"29a870baa6630186563703a113aa2c992c9449c3"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3feeb6028c9f517d17d71ba7c97fafd9b1f47de0","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        do_test()"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"    @mock.patch.object(objects.Service, \u0027get_minimum_version\u0027, return_value\u003d12)"},{"line_number":824,"context_line":"    @mock.patch.object(objects.Instance, \u0027refresh\u0027, new\u003dmock.MagicMock())"},{"line_number":825,"context_line":"    @mock.patch.object(objects.BuildRequest, \u0027get_by_instance_uuid\u0027,"},{"line_number":826,"context_line":"            side_effect\u003dexc.BuildRequestNotFound(uuid\u003d\u0027fake\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_09d60d27","line":823,"range":{"start_line":823,"start_character":76,"end_line":823,"end_character":78},"updated":"2016-08-31 20:24:16.000000000","message":"Did you mean to change this to older than version 15? The previous code was using AllServicesCurrent","commit_id":"2fbda9afd8b556a128c39a902a5e889dd8a1e15d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0adc1abb6254e4d8591a7b51bad673d8cc9aadbe","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        do_test()"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"    @mock.patch.object(objects.Service, \u0027get_minimum_version\u0027, return_value\u003d12)"},{"line_number":824,"context_line":"    @mock.patch.object(objects.Instance, \u0027refresh\u0027, new\u003dmock.MagicMock())"},{"line_number":825,"context_line":"    @mock.patch.object(objects.BuildRequest, \u0027get_by_instance_uuid\u0027,"},{"line_number":826,"context_line":"            side_effect\u003dexc.BuildRequestNotFound(uuid\u003d\u0027fake\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_a99fe15d","line":823,"range":{"start_line":823,"start_character":76,"end_line":823,"end_character":78},"in_reply_to":"fa7ab95a_09d60d27","updated":"2016-08-31 20:25:41.000000000","message":"Sorry, I just saw in the implementation, it\u0027s supposed to be 12.","commit_id":"2fbda9afd8b556a128c39a902a5e889dd8a1e15d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c9be941556c86812da723b82109d8ae22cfa62fc","unresolved":false,"context_lines":[{"line_number":842,"context_line":"        # build_instances() is a cast, we need to wait for it to complete"},{"line_number":843,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self.stubs))"},{"line_number":844,"context_line":"        # Ensure service is high enough to run the new code path"},{"line_number":845,"context_line":"        self.useFixture(fixtures.AllServicesCurrent())"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        inst_map_mock \u003d mock.MagicMock()"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7e3b9feb","side":"PARENT","line":845,"updated":"2016-09-01 14:11:47.000000000","message":"We should probably only make this return good values for the api and compute service?https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L667\n\nBut thats another patch, on another day.","commit_id":"39819da18b7810758d23eb4ba3441c108f02e298"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e5fce37b5456132ad4f1bc05f12a85b0d8cc832a","unresolved":false,"context_lines":[{"line_number":842,"context_line":"        # build_instances() is a cast, we need to wait for it to complete"},{"line_number":843,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self.stubs))"},{"line_number":844,"context_line":"        # Ensure service is high enough to run the new code path"},{"line_number":845,"context_line":"        self.useFixture(fixtures.AllServicesCurrent())"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        inst_map_mock \u003d mock.MagicMock()"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_ce2156fe","side":"PARENT","line":845,"in_reply_to":"fa7ab95a_7e3b9feb","updated":"2016-09-01 14:44:42.000000000","message":"Yeah, I was thinking that as well. But that\u0027s a whole separate concern from this patch.","commit_id":"39819da18b7810758d23eb4ba3441c108f02e298"}]}