)]}'
{"nova/virt/vmwareapi/fake.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    return lst_objs"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class FakeRetrieveObjects(object):"},{"line_number":87,"context_line":"    def __init__(self):"},{"line_number":88,"context_line":"        self.objects \u003d []"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyaQ%3D","line":86,"updated":"2013-07-11 14:06:39.000000000","message":"nit: http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vmodl.query.PropertyCollector.RetrieveResult.html\n\nRetrieveResult holds an ObjectContent list.","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4621e7a7ac6eb046855b9af4a97d0cd07369f44d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    return lst_objs"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class FakeRetrieveObjects(object):"},{"line_number":87,"context_line":"    def __init__(self):"},{"line_number":88,"context_line":"        self.objects \u003d []"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fx1U%3D","line":86,"in_reply_to":"AAAAP3%2F%2FyaQ%3D","updated":"2013-07-11 19:19:11.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"}],"nova/virt/vmwareapi/host.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"5514f6ad7569549b3f66a70a53274cde6f7d762a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def host_power_action(self, host, action):"},{"line_number":37,"context_line":"        \"\"\"Reboots or shuts down the host.\"\"\""},{"line_number":38,"context_line":"        host_mor \u003d vm_util.get_host_ref(self._session)"},{"line_number":39,"context_line":"        LOG.debug(_(\"%(action)s %(host)s\"), {\u0027action\u0027: action, \u0027host\u0027: host})"},{"line_number":40,"context_line":"        if action \u003d\u003d \"reboot\":"},{"line_number":41,"context_line":"            host_task \u003d self._session._call_method("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FzVY%3D","line":38,"updated":"2013-07-23 00:56:19.000000000","message":"nit: A comment about how this code path is only ever exercised when connected to an ESX host could prevent confusion.","commit_id":"9a967a42b0151cedd5b9a21c68445b3d17c50a9a"}],"nova/virt/vmwareapi/vim_util.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"6003590e2be9ac863420dfa1d4fbf87d6899daa4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"vmware_opts \u003d cfg.IntOpt(\u0027vmware_maximum_objects\u0027, default\u003d100,"},{"line_number":26,"context_line":"                         help\u003d\u0027Maximum number of objects to retrieve\u0027)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CONF.register_opt(vmware_opts)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FxZM%3D","line":26,"updated":"2013-07-23 14:42:13.000000000","message":"Is this something you really expect administrators to tweak?  If so, why?  Under what conditions?  What values are reasonable?  If this option stays, the help text should explain all of that.","commit_id":"9a967a42b0151cedd5b9a21c68445b3d17c50a9a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e9264c185a91d97ccaa5ef8fd39b36a915350b14","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"vmware_opts \u003d cfg.IntOpt(\u0027vmware_maximum_objects\u0027, default\u003d100,"},{"line_number":26,"context_line":"                         help\u003d\u0027Maximum number of objects to retrieve\u0027)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CONF.register_opt(vmware_opts)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2Fw4A%3D","line":26,"in_reply_to":"AAAAQn%2F%2FxZM%3D","updated":"2013-07-23 17:09:42.000000000","message":"Yes, this is certainly something that we would want the admins to have the ability to change if necessary. Moving forwards there may be certain objects that me require different values. This enables the admin to define the maximum number of objects to retrieve per call. I will update the help text.\nIf possible can you please look at https://review.openstack.org/#/c/37539/. It would make life easier if that went though first and it would save us a rebase and conflicts.","commit_id":"9a967a42b0151cedd5b9a21c68445b3d17c50a9a"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"5514f6ad7569549b3f66a70a53274cde6f7d762a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"\"\"Gets a particular property of the Managed Object.\"\"\""},{"line_number":162,"context_line":"    obj_content \u003d get_object_properties(vim, None, mobj, type, [property_name])"},{"line_number":163,"context_line":"    if hasattr(obj_content, \u0027token\u0027):"},{"line_number":164,"context_line":"        vim.CancelRetrievePropertiesEx(token\u003dobj_content.token)"},{"line_number":165,"context_line":"    property_value \u003d None"},{"line_number":166,"context_line":"    if obj_content.objects:"},{"line_number":167,"context_line":"        dynamic_property \u003d obj_content.objects[0].propSet"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FzW0%3D","line":164,"updated":"2013-07-23 00:56:19.000000000","message":"nit: a one line comment above explaining that there should only ever be one row in the results could prevent a WTF moment.","commit_id":"9a967a42b0151cedd5b9a21c68445b3d17c50a9a"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    \"\"\"Get reference to the VM with the name specified.\"\"\""},{"line_number":503,"context_line":"    vms \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":504,"context_line":"                \"VirtualMachine\", [\"name\"])"},{"line_number":505,"context_line":"    for vm in vms.objects:"},{"line_number":506,"context_line":"        if vm.propSet[0].val \u003d\u003d vm_name:"},{"line_number":507,"context_line":"            return vm.obj"},{"line_number":508,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyV0%3D","line":505,"updated":"2013-07-11 14:06:39.000000000","message":"same as other comments: How do you know there are only 100 virtual machines? Check for a \u0027token\u0027 attribute on RetrieveResult and if it is set, you need to call ContinueRetrievePropertiesEx  some how. If it is set and you don\u0027t care what comes next, you need to clean up and call cancelRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    \"\"\"Get reference to the VM with the name specified.\"\"\""},{"line_number":503,"context_line":"    vms \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":504,"context_line":"                \"VirtualMachine\", [\"name\"])"},{"line_number":505,"context_line":"    for vm in vms.objects:"},{"line_number":506,"context_line":"        if vm.propSet[0].val \u003d\u003d vm_name:"},{"line_number":507,"context_line":"            return vm.obj"},{"line_number":508,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvEo%3D","line":505,"in_reply_to":"AAAAP3%2F%2FxLo%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4621e7a7ac6eb046855b9af4a97d0cd07369f44d","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    \"\"\"Get reference to the VM with the name specified.\"\"\""},{"line_number":503,"context_line":"    vms \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":504,"context_line":"                \"VirtualMachine\", [\"name\"])"},{"line_number":505,"context_line":"    for vm in vms.objects:"},{"line_number":506,"context_line":"        if vm.propSet[0].val \u003d\u003d vm_name:"},{"line_number":507,"context_line":"            return vm.obj"},{"line_number":508,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FxLo%3D","line":505,"in_reply_to":"AAAAP3%2F%2FyV0%3D","updated":"2013-07-11 19:19:11.000000000","message":"Thanks. I am working on this.","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    \"\"\"Get reference to the VM with the uuid specified.\"\"\""},{"line_number":513,"context_line":"    vms \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":514,"context_line":"                \"VirtualMachine\", [\"name\"])"},{"line_number":515,"context_line":"    for vm in vms.objects:"},{"line_number":516,"context_line":"        if vm.propSet[0].val \u003d\u003d instance_uuid:"},{"line_number":517,"context_line":"            return vm.obj"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyVw%3D","line":515,"updated":"2013-07-11 14:06:39.000000000","message":"same nit as above","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    \"\"\"Get reference to the VM with the uuid specified.\"\"\""},{"line_number":513,"context_line":"    vms \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":514,"context_line":"                \"VirtualMachine\", [\"name\"])"},{"line_number":515,"context_line":"    for vm in vms.objects:"},{"line_number":516,"context_line":"        if vm.propSet[0].val \u003d\u003d instance_uuid:"},{"line_number":517,"context_line":"            return vm.obj"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvEk%3D","line":515,"in_reply_to":"AAAAP3%2F%2FyVw%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                    vim_util, \"get_objects\","},{"line_number":538,"context_line":"                    \"HostSystem\", property_list)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    for ref in host_refs.objects:"},{"line_number":541,"context_line":"        if ref.obj.value \u003d\u003d host_id:"},{"line_number":542,"context_line":"            return ref"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyVs%3D","line":540,"updated":"2013-07-11 14:06:39.000000000","message":"same nit as above","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                    vim_util, \"get_objects\","},{"line_number":538,"context_line":"                    \"HostSystem\", property_list)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    for ref in host_refs.objects:"},{"line_number":541,"context_line":"        if ref.obj.value \u003d\u003d host_id:"},{"line_number":542,"context_line":"            return ref"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvEg%3D","line":540,"in_reply_to":"AAAAP3%2F%2FyVs%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    \"\"\"Get reference to the cluster with the name specified.\"\"\""},{"line_number":644,"context_line":"    cls \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":645,"context_line":"                               \"ClusterComputeResource\", [\"name\"])"},{"line_number":646,"context_line":"    for cluster in cls.objects:"},{"line_number":647,"context_line":"        if cluster.propSet[0].val \u003d\u003d cluster_name:"},{"line_number":648,"context_line":"            return cluster.obj"},{"line_number":649,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyVY%3D","line":646,"updated":"2013-07-11 14:06:39.000000000","message":"can there be more than 100 of these?","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    \"\"\"Get reference to the cluster with the name specified.\"\"\""},{"line_number":644,"context_line":"    cls \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":645,"context_line":"                               \"ClusterComputeResource\", [\"name\"])"},{"line_number":646,"context_line":"    for cluster in cls.objects:"},{"line_number":647,"context_line":"        if cluster.propSet[0].val \u003d\u003d cluster_name:"},{"line_number":648,"context_line":"            return cluster.obj"},{"line_number":649,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvEc%3D","line":646,"in_reply_to":"AAAAP3%2F%2FyVY%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    \"\"\"Get reference to a host within the cluster specified.\"\"\""},{"line_number":654,"context_line":"    if cluster is None:"},{"line_number":655,"context_line":"        host_mor \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":656,"context_line":"                                        \"HostSystem\").objects[0].obj"},{"line_number":657,"context_line":"    else:"},{"line_number":658,"context_line":"        host_ret \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":659,"context_line":"                                        cluster, \"ClusterComputeResource\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyVc%3D","line":656,"updated":"2013-07-11 14:06:39.000000000","message":"cancelRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    \"\"\"Get reference to a host within the cluster specified.\"\"\""},{"line_number":654,"context_line":"    if cluster is None:"},{"line_number":655,"context_line":"        host_mor \u003d session._call_method(vim_util, \"get_objects\","},{"line_number":656,"context_line":"                                        \"HostSystem\").objects[0].obj"},{"line_number":657,"context_line":"    else:"},{"line_number":658,"context_line":"        host_ret \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":659,"context_line":"                                        cluster, \"ClusterComputeResource\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvCw%3D","line":656,"in_reply_to":"AAAAP3%2F%2FyVc%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                                \"Datastore\", data_store_mors,"},{"line_number":694,"context_line":"                                [\"summary.type\", \"summary.name\","},{"line_number":695,"context_line":"                                 \"summary.capacity\", \"summary.freeSpace\"])"},{"line_number":696,"context_line":"    for elem in data_stores.objects:"},{"line_number":697,"context_line":"        ds_name \u003d None"},{"line_number":698,"context_line":"        ds_type \u003d None"},{"line_number":699,"context_line":"        ds_cap \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyVU%3D","line":696,"updated":"2013-07-11 14:06:39.000000000","message":"can there be more than 100 of these?","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                                \"Datastore\", data_store_mors,"},{"line_number":694,"context_line":"                                [\"summary.type\", \"summary.name\","},{"line_number":695,"context_line":"                                 \"summary.capacity\", \"summary.freeSpace\"])"},{"line_number":696,"context_line":"    for elem in data_stores.objects:"},{"line_number":697,"context_line":"        ds_name \u003d None"},{"line_number":698,"context_line":"        ds_type \u003d None"},{"line_number":699,"context_line":"        ds_cap \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvCs%3D","line":696,"in_reply_to":"AAAAP3%2F%2FyVU%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bee091939880d1f92eaa47b392778916d38ed6c6","unresolved":false,"context_lines":[{"line_number":501,"context_line":"def _get_token(results):"},{"line_number":502,"context_line":"    \"\"\"Get the token from the property results.\"\"\""},{"line_number":503,"context_line":"    if hasattr(results, \u0027token\u0027):"},{"line_number":504,"context_line":"        return results.token"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"def _get_reference_for_value(results, value):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FiXg%3D","line":504,"updated":"2013-07-16 21:01:53.000000000","message":"You can change this to just:\n\n    return getattr(results, \u0027token\u0027, None)\n\nOr just replace _get_token() with that getattr().","commit_id":"efb43de0db5a18e8920d0931009aa52f9d02e2e6"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"a86c7efe5fb9b7b0fa5d8e114828373d7ce7f4af","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    token \u003d _get_token(results)"},{"line_number":539,"context_line":"    if token:"},{"line_number":540,"context_line":"        results \u003d session._call_method(vim_util,"},{"line_number":541,"context_line":"                                       \"continue_to_get_objects\","},{"line_number":542,"context_line":"                                       token)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAQn%2F%2Fl1Q%3D","line":541,"updated":"2013-07-27 00:09:56.000000000","message":"should this be \"cancel_retrieve\"?","commit_id":"d4126f91fe598c3dbe72c832cae66b32255d08ca"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9266676c23a74039d4ab2e8c62cbb0e9d61a356c","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    token \u003d _get_token(results)"},{"line_number":539,"context_line":"    if token:"},{"line_number":540,"context_line":"        results \u003d session._call_method(vim_util,"},{"line_number":541,"context_line":"                                       \"continue_to_get_objects\","},{"line_number":542,"context_line":"                                       token)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAQn%2F%2FlX8%3D","line":541,"in_reply_to":"AAAAQn%2F%2Fl1Q%3D","updated":"2013-07-27 07:26:57.000000000","message":"Done","commit_id":"d4126f91fe598c3dbe72c832cae66b32255d08ca"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                     \"VirtualMachine\","},{"line_number":95,"context_line":"                     [\"name\", \"runtime.connectionState\"])"},{"line_number":96,"context_line":"        lst_vm_names \u003d []"},{"line_number":97,"context_line":"        for vm in vms.objects:"},{"line_number":98,"context_line":"            vm_name \u003d None"},{"line_number":99,"context_line":"            conn_state \u003d None"},{"line_number":100,"context_line":"            for prop in vm.propSet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyZQ%3D","line":97,"updated":"2013-07-11 14:06:39.000000000","message":"when you want the other results you call ContinueRetrievePropertiesEx ... how do you know there are only 100 vms in this entire system? \n\nSee: http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vmodl.query.PropertyCollector.html#continueRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                     \"VirtualMachine\","},{"line_number":95,"context_line":"                     [\"name\", \"runtime.connectionState\"])"},{"line_number":96,"context_line":"        lst_vm_names \u003d []"},{"line_number":97,"context_line":"        for vm in vms.objects:"},{"line_number":98,"context_line":"            vm_name \u003d None"},{"line_number":99,"context_line":"            conn_state \u003d None"},{"line_number":100,"context_line":"            for prop in vm.propSet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvBk%3D","line":97,"in_reply_to":"AAAAP3%2F%2FyZQ%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        pwr_state \u003d None"},{"line_number":593,"context_line":"        tools_status \u003d None"},{"line_number":594,"context_line":"        tools_running_status \u003d False"},{"line_number":595,"context_line":"        for elem in props.objects:"},{"line_number":596,"context_line":"            for prop in elem.propSet:"},{"line_number":597,"context_line":"                if prop.name \u003d\u003d \"runtime.powerState\":"},{"line_number":598,"context_line":"                    pwr_state \u003d prop.val"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyWo%3D","line":595,"updated":"2013-07-11 14:06:39.000000000","message":"because \"get_object_properties\" uses the \u0027ex\u0027 method as well, you\u0027ll need to either call http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vmodl.query.PropertyCollector.html#cancelRetrievePropertiesEx to tell the server it can free the return results (it lets the vSphere host free up memory) or write code to fetch the new results and feed them to this loop somehow (probably by breaking this method up into functions). There\u0027s a reason we had this on the bottom of the list, it\u0027s a lot of work and if you do it right there\u0027s no new behavior ... you just get code that can scale better.","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        pwr_state \u003d None"},{"line_number":593,"context_line":"        tools_status \u003d None"},{"line_number":594,"context_line":"        tools_running_status \u003d False"},{"line_number":595,"context_line":"        for elem in props.objects:"},{"line_number":596,"context_line":"            for prop in elem.propSet:"},{"line_number":597,"context_line":"                if prop.name \u003d\u003d \"runtime.powerState\":"},{"line_number":598,"context_line":"                    pwr_state \u003d prop.val"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvA4%3D","line":595,"in_reply_to":"AAAAP3%2F%2FyWo%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        \"\"\"Get the datacenter name and the reference.\"\"\""},{"line_number":1191,"context_line":"        dc_obj \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1192,"context_line":"                \"Datacenter\", [\"name\"])"},{"line_number":1193,"context_line":"        return dc_obj.objects[0].obj, dc_obj.objects[0].propSet[0].val"},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def _get_host_ref_from_name(self, host_name):"},{"line_number":1196,"context_line":"        \"\"\"Get reference to the host with the name specified.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyWU%3D","line":1193,"updated":"2013-07-11 14:06:39.000000000","message":"looks like a candidate for cancelRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        \"\"\"Get the datacenter name and the reference.\"\"\""},{"line_number":1191,"context_line":"        dc_obj \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1192,"context_line":"                \"Datacenter\", [\"name\"])"},{"line_number":1193,"context_line":"        return dc_obj.objects[0].obj, dc_obj.objects[0].propSet[0].val"},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def _get_host_ref_from_name(self, host_name):"},{"line_number":1196,"context_line":"        \"\"\"Get reference to the host with the name specified.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fu%2F0%3D","line":1193,"in_reply_to":"AAAAP3%2F%2FyWU%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"        dc_objs \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1207,"context_line":"                                             \"Datacenter\", [\"vmFolder\"])"},{"line_number":1208,"context_line":"        # There is only one default datacenter in a standalone ESX host"},{"line_number":1209,"context_line":"        vm_folder_ref \u003d dc_objs.objects[0].propSet[0].val"},{"line_number":1210,"context_line":"        return vm_folder_ref"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def _get_res_pool_ref(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyWM%3D","line":1209,"updated":"2013-07-11 14:06:39.000000000","message":"cancelRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"        dc_objs \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1207,"context_line":"                                             \"Datacenter\", [\"vmFolder\"])"},{"line_number":1208,"context_line":"        # There is only one default datacenter in a standalone ESX host"},{"line_number":1209,"context_line":"        vm_folder_ref \u003d dc_objs.objects[0].propSet[0].val"},{"line_number":1210,"context_line":"        return vm_folder_ref"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def _get_res_pool_ref(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fu%2Fw%3D","line":1209,"in_reply_to":"AAAAP3%2F%2FyWM%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c838e12b8c53981a31ebda156d6f94565247a43e","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        # way. Assuming that is the default resource pool."},{"line_number":1215,"context_line":"        if self._cluster is None:"},{"line_number":1216,"context_line":"            res_pool_ref \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1217,"context_line":"                    \"ResourcePool\").objects[0].obj"},{"line_number":1218,"context_line":"        else:"},{"line_number":1219,"context_line":"            res_pool_ref \u003d self._session._call_method(vim_util,"},{"line_number":1220,"context_line":"                                                      \"get_dynamic_property\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FyWI%3D","line":1217,"updated":"2013-07-11 14:06:39.000000000","message":"cancelRetrievePropertiesEx","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20f20310b7c05c810c23ee806b3ec9f3d18f6524","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        # way. Assuming that is the default resource pool."},{"line_number":1215,"context_line":"        if self._cluster is None:"},{"line_number":1216,"context_line":"            res_pool_ref \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":1217,"context_line":"                    \"ResourcePool\").objects[0].obj"},{"line_number":1218,"context_line":"        else:"},{"line_number":1219,"context_line":"            res_pool_ref \u003d self._session._call_method(vim_util,"},{"line_number":1220,"context_line":"                                                      \"get_dynamic_property\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fu%2Fo%3D","line":1217,"in_reply_to":"AAAAP3%2F%2FyWI%3D","updated":"2013-07-12 08:10:26.000000000","message":"Done","commit_id":"3a33708a0b1c32b83fd27d77085bb689bedf7969"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bee091939880d1f92eaa47b392778916d38ed6c6","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                        max_mem \u003d int(prop.val) * 1024"},{"line_number":1083,"context_line":"                    elif prop.name \u003d\u003d \"runtime.powerState\":"},{"line_number":1084,"context_line":"                        pwr_state \u003d VMWARE_POWER_STATES[prop.val]"},{"line_number":1085,"context_line":"            if token:"},{"line_number":1086,"context_line":"                vm_props \u003d self._session._call_method(vim_util,"},{"line_number":1087,"context_line":"                        \"continue_to_get_objects\", token)"},{"line_number":1088,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FiW0%3D","line":1085,"updated":"2013-07-16 21:01:53.000000000","message":"There\u0027s a lot of repetition here…is there any way this can be DRY\u0027d up?  Maybe use some sort of generator…","commit_id":"efb43de0db5a18e8920d0931009aa52f9d02e2e6"}]}