)]}'
{"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d313abc4f9f163bc9b2d6e363a2ea758517dc988","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if self.connection._host.has_min_version("},{"line_number":99,"context_line":"                    hv_ver\u003dmin_qemu,"},{"line_number":100,"context_line":"                    hv_type\u003dhost.HV_DRIVER_QEMU):"},{"line_number":101,"context_line":"                if CONF.libvirt.hw_disk_discard \u003d\u003d \u0027unmap\u0027:"},{"line_number":102,"context_line":"                    conf.driver_discard \u003d \u0027unmap\u0027"},{"line_number":103,"context_line":"            else:"},{"line_number":104,"context_line":"                global SHOULD_LOG_DISCARD_WARNING"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c99fee5d","line":101,"range":{"start_line":101,"start_character":16,"end_line":101,"end_character":59},"updated":"2016-09-05 02:54:50.000000000","message":"I prefer a debug log when disk_discard disabled by virt driver.","commit_id":"8a579cdddd7e142bb720068ba8ac43944267eefd"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"583dd723f38aedee4f6244086c57e303a3e17254","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                if CONF.libvirt.hw_disk_discard \u003d\u003d \u0027unmap\u0027:"},{"line_number":102,"context_line":"                    conf.driver_discard \u003d \u0027unmap\u0027"},{"line_number":103,"context_line":"                else:"},{"line_number":104,"context_line":"                    LOG.debug(_LE(\u0027Volume is not set to use the discard \u0027))"},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                global SHOULD_LOG_DISCARD_WARNING"},{"line_number":107,"context_line":"                if SHOULD_LOG_DISCARD_WARNING:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_33499232","line":104,"updated":"2016-09-05 11:55:13.000000000","message":"This is wrong - there are two completely independent settings here\n\n - nova.conf hw_disk_discard is applicable to compute node local ephemeral storage\n - cinder \u0027discard\u0027 property is applicable to cinder volume storage\n\nUsing hw_disk_discard when configuring cinder volumes is not appropriate.","commit_id":"c518d976852528ca4e37c3577bf1abb2eafe9f1b"}]}