)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19e27e1dc5f8b68caf6edb28ae9260c81872865b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                  allocations,"},{"line_number":331,"context_line":"                  instance\u003dinstance)"},{"line_number":332,"context_line":"        r \u003d self.put(url, allocations)"},{"line_number":333,"context_line":"        if r:"},{"line_number":334,"context_line":"            LOG.info(_LI(\u0027Submitted allocation for instance\u0027),"},{"line_number":335,"context_line":"                     instance\u003dinstance)"},{"line_number":336,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c80db83f","line":333,"updated":"2016-09-01 20:59:33.000000000","message":"Thanks for fixing that ordering, the negative check was bugging me, especially since you had it this way below for delete. :)","commit_id":"f9965e85b917b6413a2f4401c058f21e22eeebed"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ca374fa1dde6d1e14f9b9b6f21422145b8e23269","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                  allocations,"},{"line_number":331,"context_line":"                  instance\u003dinstance)"},{"line_number":332,"context_line":"        r \u003d self.put(url, allocations)"},{"line_number":333,"context_line":"        if r:"},{"line_number":334,"context_line":"            LOG.info(_LI(\u0027Submitted allocation for instance\u0027),"},{"line_number":335,"context_line":"                     instance\u003dinstance)"},{"line_number":336,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c314b945","line":333,"in_reply_to":"fa7ab95a_c80db83f","updated":"2016-09-01 21:00:33.000000000","message":"I figured it would bug you all weekend ;D","commit_id":"f9965e85b917b6413a2f4401c058f21e22eeebed"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"394943e8e1cbf792a7eabd0a05a59e6b21969ffa","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        inst \u003d objects.Instance(uuid\u003duuids.inst)"},{"line_number":594,"context_line":"        with mock.patch.object(self.client, \u0027_allocations\u0027) as mock_a:"},{"line_number":595,"context_line":"            self.client.update_instance_allocation(cn, inst, 1)"},{"line_number":596,"context_line":"            mock_put.return_value.__nonzero__ \u003d False"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @mock.patch(\u0027nova.scheduler.client.report.SchedulerReportClient.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_28d624f1","line":596,"updated":"2016-09-01 20:47:37.000000000","message":"Doesn\u0027t this need to come before you actually call the method that\u0027s going to test it?\n\nIt doesn\u0027t make a difference in this test since we don\u0027t assert anything. Maybe assert that we call LOG.warning.","commit_id":"850401f55c27ba045561f032030ca07ae5afe707"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"394943e8e1cbf792a7eabd0a05a59e6b21969ffa","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        cn \u003d objects.ComputeNode(uuid\u003duuids.cn)"},{"line_number":612,"context_line":"        inst \u003d objects.Instance(uuid\u003duuids.inst)"},{"line_number":613,"context_line":"        self.client.update_instance_allocation(cn, inst, -1)"},{"line_number":614,"context_line":"        mock_delete.return_value.__nonzero__ \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_88fbb07a","line":614,"updated":"2016-09-01 20:47:37.000000000","message":"ditto","commit_id":"850401f55c27ba045561f032030ca07ae5afe707"}]}