)]}'
{"nova/tests/unit/test_api_validation.py":[{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"0bad8ab0308a6820618fd8a2a8008be74c93588f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        super(APIValidationTestCase, self).setUp()"},{"line_number":100,"context_line":"        self.post \u003d None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if schema is not None:"},{"line_number":103,"context_line":"            @validation.schema(request_body_schema\u003dschema)"},{"line_number":104,"context_line":"            def post(req, body):"},{"line_number":105,"context_line":"                return \u0027Validation succeeded.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_4f8490d3","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":30},"updated":"2016-09-06 06:33:30.000000000","message":"Is it necessary to check this? As far as I can tell schema is specified in all subclasses of APIValidationTestCase.\nMaybe we can set {} as a default value for schema just in case and leave out this check.","commit_id":"ebfe74570b9fa485d273079a66d292f0b78b51a3"},{"author":{"_account_id":22793,"name":"Hussain Chachuliya","email":"hussain.chachuliya@nttdata.com","username":"hussainchachuliya"},"change_message_id":"34925cf3643f9b6c0d07e84858c142e85b54cce9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        super(APIValidationTestCase, self).setUp()"},{"line_number":100,"context_line":"        self.post \u003d None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if schema is not None:"},{"line_number":103,"context_line":"            @validation.schema(request_body_schema\u003dschema)"},{"line_number":104,"context_line":"            def post(req, body):"},{"line_number":105,"context_line":"                return \u0027Validation succeeded.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_6a2048b1","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":30},"in_reply_to":"9a89bdaa_4f8490d3","updated":"2016-12-01 06:21:26.000000000","message":"Done","commit_id":"ebfe74570b9fa485d273079a66d292f0b78b51a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"948b6781d2cefe0005e3aa80d4afd490678eef1b","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class APIValidationTestCase(test.NoDBTestCase):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def setUp(self, schema\u003dNone):"},{"line_number":136,"context_line":"        super(APIValidationTestCase, self).setUp()"},{"line_number":137,"context_line":"        self.post \u003d None"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_c5ee53b3","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":31},"updated":"2017-04-07 09:41:43.000000000","message":"nit: rather than passing schema as an attribute here, couldn\u0027t you make schema a class-level attribute in all of the below and check for that here instead, e.g.\n\n  if self.schema is not None:","commit_id":"376eb8e4689f3f0fc0e660ecfb98510c6804e57f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"948b6781d2cefe0005e3aa80d4afd490678eef1b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"class MicroversionsSchemaTestCase(APIValidationTestCase):"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def setUp(self):"},{"line_number":195,"context_line":"        super(MicroversionsSchemaTestCase, self).setUp(schema\u003d{})"},{"line_number":196,"context_line":"        schema_v21_int \u003d {"},{"line_number":197,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":198,"context_line":"            \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_6599c76c","line":195,"range":{"start_line":195,"start_character":55,"end_line":195,"end_character":64},"updated":"2017-04-07 09:41:43.000000000","message":"This seems unnecessary. The value of \u0027self.post\u0027 will be overridden again on line 212","commit_id":"376eb8e4689f3f0fc0e660ecfb98510c6804e57f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ef0f5d77728b5b0fa5b81d9b8eb8a4f8e54bc84b","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class APIValidationTestCase(test.NoDBTestCase):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    schema \u003d None"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def setUp(self):"},{"line_number":138,"context_line":"        super(APIValidationTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_6e45e642","line":135,"updated":"2017-04-10 15:49:55.000000000","message":"I think this should be a little more descriptive, e.g., \u0027post_schema\u0027.","commit_id":"0ec086be391ed7702f2bf6e8c527b591378f83aa"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ef0f5d77728b5b0fa5b81d9b8eb8a4f8e54bc84b","unresolved":false,"context_lines":[{"line_number":317,"context_line":"class RequiredDisableTestCase(APIValidationTestCase):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    schema \u003d {"},{"line_number":320,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":321,"context_line":"            \u0027properties\u0027: {"},{"line_number":322,"context_line":"                \u0027foo\u0027: {"},{"line_number":323,"context_line":"                    \u0027type\u0027: \u0027integer\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_aead2eea","line":320,"updated":"2017-04-10 15:49:55.000000000","message":"All of these really should be dedented by 4 spaces, since they\u0027re no longer enclosed in a \u0027def setUp(self):\u0027.","commit_id":"0ec086be391ed7702f2bf6e8c527b591378f83aa"}]}