)]}'
{"nova/tests/unit/virt/hyperv/test_migrationops.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8928bc6cfebafc429140d6b67b81c448682bcbfc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            expected_get_dir)"},{"line_number":102,"context_line":"        self._migrationops._pathutils.copy.assert_has_calls("},{"line_number":103,"context_line":"            mock.call(fake_disk_file, fake_dest_path)"},{"line_number":104,"context_line":"            for fake_disk_file in fake_disk_files)"},{"line_number":105,"context_line":"        self._migrationops._pathutils.move_folder_files.assert_has_calls("},{"line_number":106,"context_line":"            expected_move_calls)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_63c77a98","line":104,"updated":"2016-09-12 15:19:55.000000000","message":"FYI assert_has_calls is unbounded, so whenever you use it, it\u0027s best to pair it with, for example:\n\n self.assertEqual(len(fake_disk_files),\n                  self._migrationops._pathutils.copy.call_count)\n\notherwise it could have been called more times than you expected and assert_has_calls would still pass [1]. \"There can be extra calls before or after the specified calls.\"\n\n[1] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls","commit_id":"f97e08a89f6abae6f3b458bf284c7160a338b7ee"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"467b647e1900be0e47cec2117b6089224bf849a3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            expected_get_dir)"},{"line_number":102,"context_line":"        self._migrationops._pathutils.copy.assert_has_calls("},{"line_number":103,"context_line":"            mock.call(fake_disk_file, fake_dest_path)"},{"line_number":104,"context_line":"            for fake_disk_file in fake_disk_files)"},{"line_number":105,"context_line":"        self._migrationops._pathutils.move_folder_files.assert_has_calls("},{"line_number":106,"context_line":"            expected_move_calls)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_a442683c","line":104,"in_reply_to":"9a89bdaa_63c77a98","updated":"2016-09-12 15:50:57.000000000","message":"That makes sense. I guess I\u0027ll have to make a habit of adding an extra assertion on the call count.","commit_id":"f97e08a89f6abae6f3b458bf284c7160a338b7ee"}],"nova/virt/hyperv/migrationops.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"eeef7b2c5a4e4daa5e3b65ed301ac4c135446019","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._pathutils.makedirs(dest_path)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for disk_file in disk_files:"},{"line_number":75,"context_line":"                self._pathutils.copy(disk_file, dest_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            self._pathutils.move_folder_files(instance_path, revert_path)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_abaa7917","line":75,"updated":"2016-09-09 22:13:36.000000000","message":"Did you intend to lose the debug log statement along with the check? Currently it logs each copied file.","commit_id":"9e725a2a4fb977fff787f4c946f49a2f998e4997"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"3209a6882ea29f853aab05265a9c56f1cfc24164","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._pathutils.makedirs(dest_path)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for disk_file in disk_files:"},{"line_number":75,"context_line":"                self._pathutils.copy(disk_file, dest_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            self._pathutils.move_folder_files(instance_path, revert_path)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_5274199b","line":75,"in_reply_to":"9a89bdaa_a0c5333e","updated":"2016-09-12 08:58:50.000000000","message":"Sure.","commit_id":"9e725a2a4fb977fff787f4c946f49a2f998e4997"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"448d96423ef0e52d943dd93478cfd4f6f9caccf7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._pathutils.makedirs(dest_path)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for disk_file in disk_files:"},{"line_number":75,"context_line":"                self._pathutils.copy(disk_file, dest_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            self._pathutils.move_folder_files(instance_path, revert_path)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_a0c5333e","line":75,"in_reply_to":"9a89bdaa_abaa7917","updated":"2016-09-10 01:00:40.000000000","message":"Also, can we test this? For example by adding a config drive filename to the _check_migrate_disk_files in nova/tests/unit/virt/hyperv/test_migrationops.py to verify it gets copied over too and would catch a regression in the future?","commit_id":"9e725a2a4fb977fff787f4c946f49a2f998e4997"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"3209a6882ea29f853aab05265a9c56f1cfc24164","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._pathutils.makedirs(dest_path)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for disk_file in disk_files:"},{"line_number":75,"context_line":"                self._pathutils.copy(disk_file, dest_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            self._pathutils.move_folder_files(instance_path, revert_path)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_52ffb900","line":75,"in_reply_to":"9a89bdaa_abaa7917","updated":"2016-09-12 08:58:50.000000000","message":"Well, at a second thought I think I should add it back.","commit_id":"9e725a2a4fb977fff787f4c946f49a2f998e4997"}]}