)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f06b251ed8b0330c9519830cd9e15c5f2fa6b015","unresolved":false,"context_lines":[{"line_number":11,"context_line":"PV could be used. This patch removes this functionality. Also some"},{"line_number":12,"context_line":"cleanup is made around the ImageType mess."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"From now RAW and unknown disks will not be investigated for PV-ness."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Fixes bug 1196570"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAP3%2F%2FxvE%3D","line":14,"updated":"2013-07-11 16:15:53.000000000","message":"add \"and will boot as HVM.\"","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"}],"nova/tests/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"799a8a4f98f6478e7da64933814011364002c455","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"    def test_iso(self):"},{"line_number":1880,"context_line":"        self.assert_pv_status(vm_utils.ImageType.DISK_ISO, None, False)"},{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1883,"context_line":"    def test_none(self):"},{"line_number":1884,"context_line":"        self.assert_pv_status(None, None, True)"},{"line_number":1885,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Lo%3D","side":"PARENT","line":1882,"updated":"2013-07-10 18:53:53.000000000","message":"This decorator was always setting the return value for is_pv to True","commit_id":"c6f832073dd4c157dd83150989d30a6c97ab5f49"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"799a8a4f98f6478e7da64933814011364002c455","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"        self.assert_pv_status(vm_utils.ImageType.DISK_VHD, \u0027linux\u0027, True)"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    def test_raw(self):"},{"line_number":1865,"context_line":"        self.assert_pv_status(vm_utils.ImageType.DISK_RAW, \u0027linux\u0027, False)"},{"line_number":1866,"context_line":""},{"line_number":1867,"context_line":"    def test_disk(self):"},{"line_number":1868,"context_line":"        self.assert_pv_status(vm_utils.ImageType.DISK, None, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1LE%3D","line":1865,"updated":"2013-07-10 18:53:53.000000000","message":"raw images are HVM","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f06b251ed8b0330c9519830cd9e15c5f2fa6b015","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        # 4. ISO"},{"line_number":1463,"context_line":"        is_pv \u003d False"},{"line_number":1464,"context_line":"    elif not disk_image_type:"},{"line_number":1465,"context_line":"        LOG.warning(_(\"Image format is None: trying to determine PV status \""},{"line_number":1466,"context_line":"                      \"using pygrub; if instance with vdi %s does not boot \""},{"line_number":1467,"context_line":"                      \"correctly, try with image metadata.\") % vdi_ref)"},{"line_number":1468,"context_line":"        with vdi_attached_here(session, vdi_ref, read_only\u003dTrue) as dev:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2FxvU%3D","side":"PARENT","line":1465,"updated":"2013-07-11 16:15:53.000000000","message":"I\u0027d keep this warning.","commit_id":"c6f832073dd4c157dd83150989d30a6c97ab5f49"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"799a8a4f98f6478e7da64933814011364002c455","unresolved":false,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    disk_format \u003d image_meta[\u0027disk_format\u0027]"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    disk_format_map \u003d {"},{"line_number":1400,"context_line":"        \u0027ami\u0027: ImageType.DISK,"},{"line_number":1401,"context_line":"        \u0027aki\u0027: ImageType.KERNEL,"},{"line_number":1402,"context_line":"        \u0027ari\u0027: ImageType.RAMDISK,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1K4%3D","line":1399,"updated":"2013-07-10 18:53:53.000000000","message":"to get rid of the getattr magic","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5829a2d567b60e3cdb5c19e1a1c87475acb0741","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"    disk_format \u003d image_meta[\u0027disk_format\u0027]"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    disk_format_map \u003d {"},{"line_number":1400,"context_line":"        \u0027ami\u0027: ImageType.DISK,"},{"line_number":1401,"context_line":"        \u0027aki\u0027: ImageType.KERNEL,"},{"line_number":1402,"context_line":"        \u0027ari\u0027: ImageType.RAMDISK,"},{"line_number":1403,"context_line":"        \u0027raw\u0027: ImageType.DISK_RAW,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2Fjv0%3D","line":1400,"updated":"2013-07-16 15:51:57.000000000","message":"This should really be in a separate change, but its only tiny.","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"2038f3c53b34ba09560e49fff8119665955aba0c","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"    will use hardware virtualization."},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"        1. Glance (VHD): then we use `os_type`, raise if not set"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        2. Glance (DISK_RAW): use Pygrub to figure out if pv kernel is"},{"line_number":1433,"context_line":"           available"},{"line_number":1434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Ftow%3D","line":1431,"updated":"2013-07-24 15:55:48.000000000","message":"Comment needs fixing","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d44c39300d61837ad68d08073369c9f3706f0a7c","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"    LOG.debug(_(\"Looking up vdi %s for PV kernel\"), vdi_ref)"},{"line_number":1451,"context_line":"    if disk_image_type \u003d\u003d ImageType.DISK_VHD:"},{"line_number":1452,"context_line":"        # 1. VHD"},{"line_number":1453,"context_line":"        if os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":1454,"context_line":"            is_pv \u003d False"},{"line_number":1455,"context_line":"        else:"},{"line_number":1456,"context_line":"            is_pv \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FtpU%3D","line":1453,"updated":"2013-07-24 15:55:55.000000000","message":"I think this should be pulled outside, if there his a hint for windows, its no PV, no matter what the disk type.\n\nAt least, we should decide what the hint for is_pv is, like os_type\u003d\"linux\"\n\nI am not sure the default should be disk specific, except DISK_ISO where it should by HVM.","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5829a2d567b60e3cdb5c19e1a1c87475acb0741","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        is_pv \u003d True"},{"line_number":1463,"context_line":"    elif disk_image_type \u003d\u003d ImageType.DISK_ISO:"},{"line_number":1464,"context_line":"        # 4. ISO"},{"line_number":1465,"context_line":"        is_pv \u003d False"},{"line_number":1466,"context_line":"    elif not disk_image_type:"},{"line_number":1467,"context_line":"        is_pv \u003d False"},{"line_number":1468,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2Fjt8%3D","line":1465,"updated":"2013-07-16 15:51:57.000000000","message":"This all seems like madness at the moment.\n\n* Anything that is os_type\u003dwindows should by HVM\n\n* DISK_ISO should be HVM, because they usually are\n\n* Maybe just make everything else PV?","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9992d28dc4f766f48252f08130c1275cc93aa4c5","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        is_pv \u003d True"},{"line_number":1463,"context_line":"    elif disk_image_type \u003d\u003d ImageType.DISK_ISO:"},{"line_number":1464,"context_line":"        # 4. ISO"},{"line_number":1465,"context_line":"        is_pv \u003d False"},{"line_number":1466,"context_line":"    elif not disk_image_type:"},{"line_number":1467,"context_line":"        is_pv \u003d False"},{"line_number":1468,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F6WM%3D","line":1465,"in_reply_to":"AAAAP3%2F%2Fjt8%3D","updated":"2013-07-19 10:36:51.000000000","message":"We can\u0027t assume it\u0027s PV otherwise it might not boot.\nThe only safe fallback is for HVM.","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d44c39300d61837ad68d08073369c9f3706f0a7c","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        is_pv \u003d True"},{"line_number":1463,"context_line":"    elif disk_image_type \u003d\u003d ImageType.DISK_ISO:"},{"line_number":1464,"context_line":"        # 4. ISO"},{"line_number":1465,"context_line":"        is_pv \u003d False"},{"line_number":1466,"context_line":"    elif not disk_image_type:"},{"line_number":1467,"context_line":"        is_pv \u003d False"},{"line_number":1468,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Ftos%3D","line":1465,"in_reply_to":"AAAAQn%2F%2F6WM%3D","updated":"2013-07-24 15:55:55.000000000","message":"OK, but we need to pick a single default really.\n\nIf xenserver don\u0027t support linux on HVM, then when its marked as linux, should we default to PV right?","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"8c0738a92a398f4f487eb8cca9107475e57d4a5b","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        is_pv \u003d True"},{"line_number":1463,"context_line":"    elif disk_image_type \u003d\u003d ImageType.DISK_ISO:"},{"line_number":1464,"context_line":"        # 4. ISO"},{"line_number":1465,"context_line":"        is_pv \u003d False"},{"line_number":1466,"context_line":"    elif not disk_image_type:"},{"line_number":1467,"context_line":"        is_pv \u003d False"},{"line_number":1468,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FtnQ%3D","line":1465,"in_reply_to":"AAAAQn%2F%2Ftos%3D","updated":"2013-07-24 16:02:28.000000000","message":"This is already a fallback.  If we use VHD (above) then we assume PV unless it\u0027s windows.  Plus we have also already checked the vm_mode metadata which would typically be set.\nIf we\u0027re removing pygrub then we can\u0027t \"guess\" correctly so have to default to HVM.  The \"supported\" configuration will be for vm_mode to be set in the metadata - in the same way as you have to use the right template when booting from XS itself.","commit_id":"ca68c1cac3f4030add6285cdff6dfe0b55de9fe0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"693f17789eacb2c7fa4bc2a2051b6816ed6a3fa1","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"    LOG.debug(_(\"Looking up vdi %s for PV kernel\"), vdi_ref)"},{"line_number":1484,"context_line":"    if disk_image_type \u003d\u003d ImageType.DISK_VHD:"},{"line_number":1485,"context_line":"        # 1. VHD"},{"line_number":1486,"context_line":"        if os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":1487,"context_line":"            is_pv \u003d False"},{"line_number":1488,"context_line":"        else:"},{"line_number":1489,"context_line":"            is_pv \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fb8I%3D","line":1486,"updated":"2013-07-31 08:30:24.000000000","message":"Can we just use this os_type check for every disk type?\n\nAlthough, a better check is probably, if os_type\u003dlinux PV else HVM.\n\nWe have at this point, I think, already respected the image flag of vm_mode\u003dhvm or pv anyway, so this is really just an extra safety net.","commit_id":"e3ef5214c664e44c125fd80a25418141146ff381"}]}