)]}'
{"nova/cells/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"acf9b2d99d345d6c75b5f1903df771f52ec0ebc6","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        response \u003d self.msg_runner.stop_instance(ctxt, instance,"},{"line_number":428,"context_line":"                                                 do_cast\u003ddo_cast)"},{"line_number":429,"context_line":"        if not do_cast:"},{"line_number":430,"context_line":"            return response.value_or_raise()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2FxDM%3D","line":430,"updated":"2013-07-11 19:37:11.000000000","message":"Any reason not to just return the result directly, which will be None if do_cast\u003dTrue?","commit_id":"e0add411fc7a24fbc907aff7c25d889f8aa0f90f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"5a4348b5bbdda9f4c9ba02e9f25ffaae70707396","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        response \u003d self.msg_runner.stop_instance(ctxt, instance,"},{"line_number":428,"context_line":"                                                 do_cast\u003ddo_cast)"},{"line_number":429,"context_line":"        if not do_cast:"},{"line_number":430,"context_line":"            return response.value_or_raise()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fw6M%3D","line":430,"in_reply_to":"AAAAP3%2F%2FxDM%3D","updated":"2013-07-11 19:42:18.000000000","message":"I think \u0027response\u0027 will be None if do_cast is True... so I can\u0027t value_or_raise() it.   Otherwise, it\u0027s an encoded Response object.  So I need to convert it (or re-raise the exception from child cell).","commit_id":"e0add411fc7a24fbc907aff7c25d889f8aa0f90f"}],"nova/cells/messaging.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"acf9b2d99d345d6c75b5f1903df771f52ec0ebc6","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"            self._instance_action(ctxt, instance, \u0027stop_instance\u0027)"},{"line_number":1526,"context_line":"        else:"},{"line_number":1527,"context_line":"            return self._instance_action(ctxt, instance, \u0027stop_instance\u0027,"},{"line_number":1528,"context_line":"                                         need_response\u003dTrue)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    @staticmethod"},{"line_number":1531,"context_line":"    def get_message_types():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2FxBs%3D","line":1528,"updated":"2013-07-11 19:37:11.000000000","message":"Same deal here, can we just return the function and pass need_response\u003d(not do_cast) ?","commit_id":"e0add411fc7a24fbc907aff7c25d889f8aa0f90f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"5a4348b5bbdda9f4c9ba02e9f25ffaae70707396","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"            self._instance_action(ctxt, instance, \u0027stop_instance\u0027)"},{"line_number":1526,"context_line":"        else:"},{"line_number":1527,"context_line":"            return self._instance_action(ctxt, instance, \u0027stop_instance\u0027,"},{"line_number":1528,"context_line":"                                         need_response\u003dTrue)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    @staticmethod"},{"line_number":1531,"context_line":"    def get_message_types():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fw6E%3D","line":1528,"in_reply_to":"AAAAP3%2F%2FxBs%3D","updated":"2013-07-11 19:42:18.000000000","message":"Yeah, I could do that with this one. :)  I was trying to be a little too explicit I guess.  I\u0027ll fix it up if there\u0027s any other negative feedback since I see you +2\u0027d the new patchset.","commit_id":"e0add411fc7a24fbc907aff7c25d889f8aa0f90f"}],"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"310ddde481453b55740504df3c7af729bfe972ff","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        return self._compute_task_api"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @property"},{"line_number":232,"context_line":"    def cell_type(self):"},{"line_number":233,"context_line":"        try:"},{"line_number":234,"context_line":"            return getattr(self, \u0027_cell_type\u0027)"},{"line_number":235,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F06Y%3D","line":232,"updated":"2013-07-10 20:27:46.000000000","message":"Left this addition in by accident before I moved code to compute rpcapi","commit_id":"7bf25b771759f84670b4d59a1b36446615a96b8a"}]}