)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"66d9860a5a5c3dcc13aedc1457d4ad35fb392cd5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-10-10 15:27:47 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: add supported vif types for virtuozzo virt_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ied17a5406d5625f1e9f704e5b9b46d300f2870c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_59383dd3","line":8,"updated":"2016-10-10 15:37:56.000000000","message":"Isn\u0027t that related to the spec to enable virtuozzo to libvirt ?","commit_id":"f83499f4c0c81eaec7d1300a930d2105f6228c49"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"274388edc073684bb806cf4cebc86f93e0492819","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                       group\u003d\u0027libvirt\u0027)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"            d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":660,"context_line":"            if virt \u003d\u003d \u0027parallels\u0027:"},{"line_number":661,"context_line":"                supported \u003d (network_model.VIF_MODEL_RTL8139,"},{"line_number":662,"context_line":"                             network_model.VIF_MODEL_E1000)"},{"line_number":663,"context_line":"            else:"},{"line_number":664,"context_line":"                supported \u003d (network_model.VIF_MODEL_NE2K_PCI,"},{"line_number":665,"context_line":"                             network_model.VIF_MODEL_PCNET,"},{"line_number":666,"context_line":"                             network_model.VIF_MODEL_RTL8139,"},{"line_number":667,"context_line":"                             network_model.VIF_MODEL_E1000,"},{"line_number":668,"context_line":"                             network_model.VIF_MODEL_SPAPR_VLAN)"},{"line_number":669,"context_line":"            for model in supported:"},{"line_number":670,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":671,"context_line":"                    {\u0027properties\u0027: {\u0027hw_vif_model\u0027: model}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_6ae4f53a","line":668,"range":{"start_line":660,"start_character":0,"end_line":668,"end_character":64},"updated":"2016-10-18 14:09:44.000000000","message":"nit:\n\n    supported \u003d [network_model.VIF_MODEL_RTL8139,\n                 network_model.VIF_MODEL_E1000]\n    if virt !\u003d \u0027parallels\u0027:\n        supported +\u003d [network_model...","commit_id":"e4d66484fc42f0c8c6b87ce3ab9b8100f94dad4a"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"ee68b5893f4fcb7ad45e8b8195d0624622fc0950","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                             network_model.VIF_MODEL_PCNET,"},{"line_number":666,"context_line":"                             network_model.VIF_MODEL_RTL8139,"},{"line_number":667,"context_line":"                             network_model.VIF_MODEL_E1000,"},{"line_number":668,"context_line":"                             network_model.VIF_MODEL_SPAPR_VLAN)"},{"line_number":669,"context_line":"            for model in supported:"},{"line_number":670,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":671,"context_line":"                    {\u0027properties\u0027: {\u0027hw_vif_model\u0027: model}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_f54b9c57","line":668,"in_reply_to":"da6895a0_d32079fa","updated":"2016-10-21 13:00:01.000000000","message":"I agree. That\u0027s why I didn\u0027t change this piece.","commit_id":"e4d66484fc42f0c8c6b87ce3ab9b8100f94dad4a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8ecd752963b9efa099aa82dc7157cbc773ba27d9","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                             network_model.VIF_MODEL_PCNET,"},{"line_number":666,"context_line":"                             network_model.VIF_MODEL_RTL8139,"},{"line_number":667,"context_line":"                             network_model.VIF_MODEL_E1000,"},{"line_number":668,"context_line":"                             network_model.VIF_MODEL_SPAPR_VLAN)"},{"line_number":669,"context_line":"            for model in supported:"},{"line_number":670,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":671,"context_line":"                    {\u0027properties\u0027: {\u0027hw_vif_model\u0027: model}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_d32079fa","line":668,"in_reply_to":"fa6399be_6ae4f53a","updated":"2016-10-21 10:23:11.000000000","message":"I would say the actual implementation is better, no need to have a negative condition and it\u0027s better to have a static tuple than mutable list.","commit_id":"e4d66484fc42f0c8c6b87ce3ab9b8100f94dad4a"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"274388edc073684bb806cf4cebc86f93e0492819","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027lxc\u0027: [],"},{"line_number":70,"context_line":"        \u0027uml\u0027: [],"},{"line_number":71,"context_line":"        \u0027parallels\u0027: [network_model.VIF_MODEL_VIRTIO,"},{"line_number":72,"context_line":"                 network_model.VIF_MODEL_RTL8139,"},{"line_number":73,"context_line":"                 network_model.VIF_MODEL_E1000],"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if vif_model is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_ea72c5ac","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":48},"updated":"2016-10-18 14:09:44.000000000","message":"nit: these should be aligned under the other option","commit_id":"e4d66484fc42f0c8c6b87ce3ab9b8100f94dad4a"}]}