)]}'
{"nova/cmd/scheduler.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e92b3b4e53ea9e9997e41090f18c43bf11550fe","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if CONF.debug:"},{"line_number":43,"context_line":"        LOG.warning(_LW(\u0027Running in debug mode will cause a negative impact\u0027"},{"line_number":44,"context_line":"                        \u0027on scheduler performance\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_078de37a","line":43,"range":{"start_line":43,"start_character":69,"end_line":43,"end_character":75},"updated":"2016-09-06 19:05:00.000000000","message":"need a space after this","commit_id":"72e3434ce9aaf989d4e0e05cf683071600c9d417"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"727c76f4879811d581c9c32b50020b8b5c7cf3b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if CONF.debug:"},{"line_number":43,"context_line":"        LOG.warning(_LW(\u0027Running in debug mode will cause a negative impact\u0027"},{"line_number":44,"context_line":"                        \u0027on scheduler performance\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c7f5bbcb","line":43,"range":{"start_line":43,"start_character":69,"end_line":43,"end_character":75},"in_reply_to":"9a89bdaa_078de37a","updated":"2016-09-06 19:09:06.000000000","message":"Done","commit_id":"72e3434ce9aaf989d4e0e05cf683071600c9d417"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"916d1520e88f15009dbbb4d06c1eaa165b4ad9fb","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if CONF.debug:"},{"line_number":43,"context_line":"        LOG.warning(_LW(\u0027Running in debug mode will cause a negative impact \u0027"},{"line_number":44,"context_line":"                        \u0027on scheduler performance\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":47,"context_line":"                                    topic\u003dCONF.scheduler_topic)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_47ba8bc1","line":44,"updated":"2016-09-06 19:13:15.000000000","message":"Not really sold on the idea... You know, it\u0027s in general a bad idea to use DEBUG logs in production when you\u0027re not really looking at an issue. Here, I think the warning is rather a truism, nope ?","commit_id":"c42585cd14a77e9d125a4c4c535868c25b2a36be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36ad328ff4f044353ac8f46c2fccbb38439e8fff","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if CONF.debug:"},{"line_number":43,"context_line":"        LOG.warning(_LW(\u0027Running in debug mode will cause a negative impact \u0027"},{"line_number":44,"context_line":"                        \u0027on scheduler performance\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":47,"context_line":"                                    topic\u003dCONF.scheduler_topic)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_ef46114e","line":44,"in_reply_to":"9a89bdaa_18bb7ee6","updated":"2016-09-06 21:19:32.000000000","message":"The problem with adding a warning to the debug config option is it comes from oslo.log, so it\u0027s not going to be appropriate to say something about nova-scheduler having performance issues with debug logging on, at least I don\u0027t think so.","commit_id":"c42585cd14a77e9d125a4c4c535868c25b2a36be"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a2169cac3920921399cb5cecbfccfbf1cd26fc11","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if CONF.debug:"},{"line_number":43,"context_line":"        LOG.warning(_LW(\u0027Running in debug mode will cause a negative impact \u0027"},{"line_number":44,"context_line":"                        \u0027on scheduler performance\u0027))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":47,"context_line":"                                    topic\u003dCONF.scheduler_topic)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_18bb7ee6","line":44,"in_reply_to":"9a89bdaa_47ba8bc1","updated":"2016-09-06 20:30:38.000000000","message":"I think the warning is useful, but I don\u0027t think this is the right place for it. I think this should be added to the config option comments where it will be available when the config is being set.","commit_id":"c42585cd14a77e9d125a4c4c535868c25b2a36be"}]}