)]}'
{"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27a1bb437c8c98616b7fc0f7bcf08605b0be1919","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        A missing endpoint entry should permanently disable the"},{"line_number":46,"context_line":"        client. And make future calls to it not happen."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        req.side_effect \u003d ks_exc.EndpointNotFound()"},{"line_number":49,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":50,"context_line":"        self.assertTrue(self.client._disabled)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e661a53a","line":47,"updated":"2016-09-07 17:30:40.000000000","message":"femto-nit: we generally don\u0027t put docstrings on test methods. Instead, we typically just use # code comments. But, meh :)","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0492029e6dd1398c3a60417207cc879a3aa340c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        A missing endpoint entry should permanently disable the"},{"line_number":46,"context_line":"        client. And make future calls to it not happen."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        req.side_effect \u003d ks_exc.EndpointNotFound()"},{"line_number":49,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":50,"context_line":"        self.assertTrue(self.client._disabled)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e9bb36e3","line":47,"in_reply_to":"9a89bdaa_e661a53a","updated":"2016-09-07 17:45:11.000000000","message":"That\u0027s an old rule for nose, we actually want docstrings now.","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27a1bb437c8c98616b7fc0f7bcf08605b0be1919","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # work"},{"line_number":54,"context_line":"        req.reset_mock()"},{"line_number":55,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":56,"context_line":"        req.assert_not_called()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @mock.patch(\u0027keystoneauth1.session.Session.request\u0027)"},{"line_number":59,"context_line":"    def test_missing_auth(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_0667694d","line":56,"updated":"2016-09-07 17:30:40.000000000","message":"I would be inconsistent if I didn\u0027t point out that assert_not_called() is not a method on py2\u0027s mock library:\n\nhttp://www.voidspace.org.uk/python/mock/\n\nI\u0027ve asked mdbooth in the past to write the above as:\n\n self.assertFalse(req.called)\n\nwhich is correct for both py2 and py3.","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0492029e6dd1398c3a60417207cc879a3aa340c1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # work"},{"line_number":54,"context_line":"        req.reset_mock()"},{"line_number":55,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":56,"context_line":"        req.assert_not_called()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @mock.patch(\u0027keystoneauth1.session.Session.request\u0027)"},{"line_number":59,"context_line":"    def test_missing_auth(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_a9ef6ee7","line":56,"in_reply_to":"9a89bdaa_0667694d","updated":"2016-09-07 17:45:11.000000000","message":"assert_not_called is in the 2.0 mock lib that we use:\n\nhttps://github.com/testing-cabal/mock/blob/2.0.0/mock/mock.py#L890\n\nAnd it\u0027s in mock on py3.5.\n\nhttps://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_not_called\n\nAnd we\u0027re testing against python 3.5 now instead of py3.4 I thought.","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27a1bb437c8c98616b7fc0f7bcf08605b0be1919","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # work"},{"line_number":91,"context_line":"        req.reset_mock()"},{"line_number":92,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":93,"context_line":"        req.assert_called()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class SchedulerReportClientTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2658ed89","line":93,"updated":"2016-09-07 17:30:40.000000000","message":"self.assertTrue(req.called)\n\neven in Python 3.5\u0027s stdlib mock library, there is no assert_called() method on mock.Mock():\n\nhttps://docs.python.org/3/library/unittest.mock.html","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0492029e6dd1398c3a60417207cc879a3aa340c1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # work"},{"line_number":91,"context_line":"        req.reset_mock()"},{"line_number":92,"context_line":"        self.client._get_resource_provider(\"fake\")"},{"line_number":93,"context_line":"        req.assert_called()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class SchedulerReportClientTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_09a85a8c","line":93,"in_reply_to":"9a89bdaa_2658ed89","updated":"2016-09-07 17:45:11.000000000","message":"https://github.com/testing-cabal/mock/blob/2.0.0/mock/mock.py#L899\n\nBut yeah it\u0027s not in 3.5:\n\nhttps://docs.python.org/3/library/unittest.mock.html","commit_id":"25abb68039ca122b4b3796a9f8c9e3495db22772"}]}