)]}'
{"nova/db/sqlalchemy/api_migrations/migrate_repo/versions/020_block_device_mappings_mediumtext.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a38b8f0fe1bccf40e9d9a7663912fdfb09d06d2a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from sqlalchemy import Text"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def MediumText():"},{"line_number":20,"context_line":"    return Text().with_variant(MEDIUMTEXT(), \u0027mysql\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e8bf625e","line":19,"updated":"2016-09-08 23:52:39.000000000","message":"Let\u0027s import this from the api_models module to avoid the duplication.","commit_id":"0e9b74a29bd4f2789a296a7dfa9dc1973029664f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77f571e5429b66eeb154fd6271cb095af4940cf7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    build_requests \u003d Table(\u0027build_requests\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    build_requests.c.block_device_mappings.alter(type\u003dapi_models.MediumText())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_0b9e4007","line":24,"updated":"2016-09-09 00:23:25.000000000","message":"The only thing I\u0027m not sure about with this is if it\u0027s idempotent, i.e. if you already have this change and run it twice, does it blow up or is it a noop?","commit_id":"80795f2dc58d7210fb8a1564632e4dd34fbeaae3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f2abbf79de137beda9556fc64e035f74097481e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    build_requests \u003d Table(\u0027build_requests\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    build_requests.c.block_device_mappings.alter(type\u003dapi_models.MediumText())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_be8d902c","line":24,"in_reply_to":"9a89bdaa_0b9e4007","updated":"2016-09-09 00:54:10.000000000","message":"Yeah it is, the tests here passed:\n\nhttps://review.openstack.org/#/c/367703/","commit_id":"80795f2dc58d7210fb8a1564632e4dd34fbeaae3"}],"nova/tests/functional/db/api/test_migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a38b8f0fe1bccf40e9d9a7663912fdfb09d06d2a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def _check_020(self, engine, data):"},{"line_number":456,"context_line":"        build_requests \u003d db_utils.get_table(engine, \u0027build_requests\u0027)"},{"line_number":457,"context_line":"        self.assertIsInstance(build_requests.c.block_device_mappings.type,"},{"line_number":458,"context_line":"                              sqlalchemy.dialects.mysql.MEDIUMTEXT)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        fake_build_req \u003d build_requests.select("},{"line_number":461,"context_line":"            build_requests.c.id \u003d\u003d 2020).execute().first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c8161e58","line":458,"range":{"start_line":458,"start_character":30,"end_line":458,"end_character":66},"updated":"2016-09-08 23:52:39.000000000","message":"Wouldn\u0027t the type actually be the MediumText type from the api_models and schema migration?","commit_id":"0e9b74a29bd4f2789a296a7dfa9dc1973029664f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70f8c7b7ad8d0962e579e067a62450a1ebeb2924","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def _check_020(self, engine, data):"},{"line_number":456,"context_line":"        build_requests \u003d db_utils.get_table(engine, \u0027build_requests\u0027)"},{"line_number":457,"context_line":"        self.assertIsInstance(build_requests.c.block_device_mappings.type,"},{"line_number":458,"context_line":"                              sqlalchemy.dialects.mysql.MEDIUMTEXT)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        fake_build_req \u003d build_requests.select("},{"line_number":461,"context_line":"            build_requests.c.id \u003d\u003d 2020).execute().first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_6b0fcc2e","line":458,"range":{"start_line":458,"start_character":30,"end_line":458,"end_character":66},"in_reply_to":"9a89bdaa_c8161e58","updated":"2016-09-08 23:53:54.000000000","message":"Otherwise the tests are failing for postgres and sqlite because they don\u0027t use the mysql variant:\n\nhttp://logs.openstack.org/55/366955/3/check/gate-nova-tox-db-functional-ubuntu-xenial/22ae96a/console.html#_2016-09-08_19_51_07_122447\n\nSo that\u0027s probably your issue, the alter table doesn\u0027t change for non-mysql databases.","commit_id":"0e9b74a29bd4f2789a296a7dfa9dc1973029664f"}]}