)]}'
{"nova/compute/cells_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13e2f295197404183503d7d0f9c58c23792fe424","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            except exception.ObjectActionError:"},{"line_number":228,"context_line":"                # NOTE(alaski): We very likely got here because the host"},{"line_number":229,"context_line":"                # constraint in instance.destroy() failed.  This likely means"},{"line_number":230,"context_line":"                # that an update came up from a child cell and cell_name is"},{"line_number":231,"context_line":"                # set now.  We handle this similarly to how the"},{"line_number":232,"context_line":"                # ObjectActionError is handled below."},{"line_number":233,"context_line":"                with excutils.save_and_reraise_exception() as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_93544c22","line":230,"range":{"start_line":230,"start_character":63,"end_line":230,"end_character":72},"updated":"2016-09-08 22:01:09.000000000","message":"In the case of the bug you\u0027re fixing, the host is set. Will the cell_name also get set when the host is changed?","commit_id":"193e71bd30bbc6dd0a22b4e07d98e8a763ddda7b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f2cbc392edb1332536893507c71f083866fab8e0","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            except exception.ObjectActionError:"},{"line_number":228,"context_line":"                # NOTE(alaski): We very likely got here because the host"},{"line_number":229,"context_line":"                # constraint in instance.destroy() failed.  This likely means"},{"line_number":230,"context_line":"                # that an update came up from a child cell and cell_name is"},{"line_number":231,"context_line":"                # set now.  We handle this similarly to how the"},{"line_number":232,"context_line":"                # ObjectActionError is handled below."},{"line_number":233,"context_line":"                with excutils.save_and_reraise_exception() as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_79ac078d","line":230,"range":{"start_line":230,"start_character":63,"end_line":230,"end_character":72},"in_reply_to":"9a89bdaa_93544c22","updated":"2016-09-08 22:27:39.000000000","message":"cell_name is set in the rpc layer when any message comes up from a child cell. So the host name being set, or any other update, will ensure that cell_name is set.","commit_id":"193e71bd30bbc6dd0a22b4e07d98e8a763ddda7b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f0b84fae8224cc0d4426fb49aca4c9fca2ac718","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                    instance \u003d self._lookup_instance(context, instance.uuid)"},{"line_number":235,"context_line":"                    if instance is None:"},{"line_number":236,"context_line":"                        exc.reraise \u003d False"},{"line_number":237,"context_line":"                    elif instance.cell_name:"},{"line_number":238,"context_line":"                        exc.reraise \u003d False"},{"line_number":239,"context_line":"                        self._handle_cell_delete(context, instance,"},{"line_number":240,"context_line":"                                                 method_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_d915139c","line":237,"updated":"2016-09-08 22:34:17.000000000","message":"OK, so if host was set, then cell_name would be set and this should be pass? Then I think we\u0027re good. It doesn\u0027t seem like we\u0027d be any worse off anyway.","commit_id":"193e71bd30bbc6dd0a22b4e07d98e8a763ddda7b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"93d7cb33d724d977d6e877757dd35bd0aae6fdbf","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                    instance \u003d self._lookup_instance(context, instance.uuid)"},{"line_number":235,"context_line":"                    if instance is None:"},{"line_number":236,"context_line":"                        exc.reraise \u003d False"},{"line_number":237,"context_line":"                    elif instance.cell_name:"},{"line_number":238,"context_line":"                        exc.reraise \u003d False"},{"line_number":239,"context_line":"                        self._handle_cell_delete(context, instance,"},{"line_number":240,"context_line":"                                                 method_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_b4869614","line":237,"in_reply_to":"9a89bdaa_d915139c","updated":"2016-09-08 22:57:50.000000000","message":"Yep, this should pass. I copied the approach from below where the possibility is left open that cell_name is not set in which case the exception is bubbled up as a 500. But since that should not happen I think that\u0027s the right thing to do.","commit_id":"193e71bd30bbc6dd0a22b4e07d98e8a763ddda7b"}]}