)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"42d269f44766ea1cfaab1bb038cc4a153d29cdbf","unresolved":false,"context_lines":[{"line_number":285,"context_line":"Possible values:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":288,"context_line":"  libvirt)"},{"line_number":289,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":290,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_5f60a235","line":288,"updated":"2016-09-12 08:54:43.000000000","message":"The default is not guaranteed to be ps2 - it is only ps2 on x86 guests. This is why we really want the separate ps2mouse option to let admins be explicit.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"251733c41f92482ee29bed0439ec4f845048c6fb","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Possible values:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":288,"context_line":"  libvirt)"},{"line_number":289,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":290,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_84eb03b0","line":289,"range":{"start_line":287,"start_character":0,"end_line":289,"end_character":58},"updated":"2016-09-09 12:39:52.000000000","message":"If None and ps2mouse are effectively the same thing, maybe we should make ps2mouse the default?","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fe3fae7f38f53c3ae61f3623c8f5070679941b4d","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":288,"context_line":"  libvirt)"},{"line_number":289,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":290,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_fabaa409","line":289,"in_reply_to":"9a89bdaa_274cf975","updated":"2016-09-09 13:08:26.000000000","message":"Yes I understand your point - I don\u0027t really know why that option use_usb_tablet as been defaulted to True as I don\u0027t know why that option has been implemented to be configured in the host.\n\nI would say we should just let the default behavior of each drivers and encourage operators to use spice or tablet when it\u0027s necessary from the image properties.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1270120d3105e2bab6a59055df12d66b2364e009","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Possible values:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":288,"context_line":"  libvirt)"},{"line_number":289,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":290,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_274cf975","line":289,"range":{"start_line":287,"start_character":0,"end_line":289,"end_character":58},"in_reply_to":"9a89bdaa_84eb03b0","updated":"2016-09-09 12:47:17.000000000","message":"Actually, I think we should make usbtablet the default, since use_usb_tablet defaulted to True. Then people can use ps2mouse if needed, or set to None and let the code figure out the proper default, which in our case right now would be usbtablet because use_usb_tablet\u003dTrue, but after we remove use_usb_tablet, pointer_model\u003dNone would result in effectively ps2mouse for libvirt.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"251733c41f92482ee29bed0439ec4f845048c6fb","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_448c9b35","line":295,"range":{"start_line":295,"start_character":2,"end_line":295,"end_character":11},"updated":"2016-09-09 12:39:52.000000000","message":"deactivate","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"251733c41f92482ee29bed0439ec4f845048c6fb","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_248eb727","line":295,"range":{"start_line":295,"start_character":30,"end_line":295,"end_character":49},"updated":"2016-09-09 12:39:52.000000000","message":"should be set to","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e00182fa5fe62a07da3292f7e2cd56105a5cfa72","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_78ce402e","line":295,"range":{"start_line":295,"start_character":2,"end_line":295,"end_character":11},"in_reply_to":"9a89bdaa_0915ede3","updated":"2016-09-12 16:17:03.000000000","message":"To be clear, I think we should just change pointer_model\u003dusbtablet by default so it matches the use_usb_tablet default of True. We drop use_usb_tablet in Ocata (in a week or so). If people don\u0027t want USB they are already having to disable it via use_usb_tablet\u003dFalse. I want to avoid changing the default behavior in a deprecated option.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7ff60f651ec825795805d02e48193dfdbcfd6a3a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_f76f9fc1","line":295,"in_reply_to":"9a89bdaa_1b18ce74","updated":"2016-09-13 08:29:23.000000000","message":"I think we can\u0027t change the default behavior of use_usb_tablet to False - After the upgrade admins are going to get USB tablet if they did not have specifically added the option pointer_model to ps2mouse of None.\n\nAdmins which do not have set use_usb_tablet do not get any notifications or deprecated messages, we should have the ponter_model to return \u0027usbtablet\u0027 to do not break upgrade behavior, so by default:\n\n  pointer_model\u003dusbtablet\n\nAdmins which have specifically set use_usb_tablet\u003dTrue|False are going to get notifications or deprecated messages so they are going to look at the option pointer_model and remove the option use_usb_tablet.\n\n  pointer_model\u003dps2mouse or\n  pointer_model\u003dusbtablet","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b06092316a1d835a1e706dfcd1664c55c300616f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_0915ede3","line":295,"range":{"start_line":295,"start_character":2,"end_line":295,"end_character":11},"in_reply_to":"9a89bdaa_3ff83e49","updated":"2016-09-12 15:42:44.000000000","message":"use_usb_tablet is a boolean parameter, so the default has to be True or False, which I think we\u0027re saying leave as True for the default and then change the default for pointer_model\u003dusbtablet.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"42d269f44766ea1cfaab1bb038cc4a153d29cdbf","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_3ff83e49","line":295,"range":{"start_line":295,"start_character":2,"end_line":295,"end_character":11},"in_reply_to":"9a89bdaa_448c9b35","updated":"2016-09-12 08:54:43.000000000","message":"If \u0027use_usb_tablet\u0027 previously defaulted to True, then it seems that duration time when we have both we should\n\n - Set use_usb_table\u003dNone by default\n - Set pointer_model\u003dusbtablet by default\n\nThat gives us consistent default behaviour with past practice, while preventing use_usb_table overriding pointer_model by default.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6aaaea23807d6020b3de6a7fd50294f6fca4fc64","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_1b18ce74","line":295,"range":{"start_line":295,"start_character":2,"end_line":295,"end_character":11},"in_reply_to":"9a89bdaa_78ce402e","updated":"2016-09-12 16:20:55.000000000","message":"Oh, hmm, well, I\u0027m forgetting the context that we\u0027re getting deprecation warnings from devstack because we\u0027re forced to set use_usb_tablet\u003dFalse. And we can\u0027t set pointer_model\u003dNone to get around that, so we might need to go with Daniel\u0027s suggestion of changing use_usb_tablet\u003dFalse. And then change pointer_model\u003dusbtablet to match the previous default of use_usb_tablet\u003dTrue for upgrades. With doing that, you can disable USB by setting pointer_model\u003dNone and you don\u0027t have to change the default for use_usb_tablet. So let\u0027s go that route, and we\u0027ll need a release note for the upgrade impact.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1f6ff12cca3c27e5bd6176ab09d7dd969b88c11","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Note: For libvirt only, while the deprecated option use_usb_tablet is"},{"line_number":293,"context_line":"  available, using the default value for pointer_model does not"},{"line_number":294,"context_line":"  provide any effect as use_usb_tablet is enable by default. To"},{"line_number":295,"context_line":"  desactive it, pointer_model as to be defined as \u0027ps2mouse\u0027."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Interdependencies to other options:"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ca43bb40","line":295,"in_reply_to":"9a89bdaa_f76f9fc1","updated":"2016-09-13 13:42:33.000000000","message":"If you\u0027re going to make pointer_model a boolean, i.e. only ps2mouse or usbtablet, then you\u0027d need to also drop None as a value, even though we want None \u003d\u003d ps2mouse as the default, but can only really do that after we\u0027ve deleted use_usb_tablet.\n\nI agree with making the default for pointer_model\u003dusbtablet to match the default for use_usb_tablet\u003dTrue. I think I\u0027m OK with the compromise of add ps2mouse as an option to pointer_model to allow an explicit way to override the default behavior and whatever is set, or not set, for use_usb_tablet, as pointer_model\u003dNone is a problem until we drop use_usb_tablet.","commit_id":"6685be3cfb20205267f19d1d3bdf20aea2a4a8e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec1532eea9f95b757b5519f085111b042cc3f06e","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    cfg.StrOpt("},{"line_number":274,"context_line":"        \u0027pointer_model\u0027,"},{"line_number":275,"context_line":"        default\u003d\u0027usbtablet\u0027,"},{"line_number":276,"context_line":"        choices\u003d[None, \u0027ps2mouse\u0027, \u0027usbtablet\u0027],"},{"line_number":277,"context_line":"        help\u003d\"\"\""},{"line_number":278,"context_line":"Generic property to specify the pointer type."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5822e5ba","line":275,"updated":"2016-09-13 19:49:58.000000000","message":"Interesting, this was disabled in devstack a long time ago because usb makes qemu poll for usb events even when idle:\n\nhttps://review.openstack.org/#/c/42562/\n\nI wonder if that\u0027s still an issue, or how much of an issue it was. Seems like disabling that in devstack was not really the right way to fix it though, it should have been a change in nova if the default wasn\u0027t / isn\u0027t sane.\n\nThis old article looks related:\n\nhttps://www.kraxel.org/blog/2014/03/qemu-and-usb-tablet-cpu-consumtion/","commit_id":"22a28bdd257a0f6ead663a4f5fe3ab8072da5ea9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"897b76c2b458a17904347442479c1bf1892724f6","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":289,"context_line":"        libvirt x86)"},{"line_number":290,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":291,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_b6e97e81","line":288,"updated":"2016-09-13 14:39:14.000000000","message":"I\u0027m thinking we should add a note that until use_usb_tablet is gone, this value will fallback to the value of use_usb_tablet. The only reason to no do that is we\u0027d have to remember to update this once we drop the use_usb_tablet option, but anyone grepping the code for use_usb_tablet should find it and remove it.","commit_id":"22a28bdd257a0f6ead663a4f5fe3ab8072da5ea9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"405dbd0fafac56762e050cd2a6e3ae4176135ab6","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"* None: Uses default behavior provided by drivers (mouse on PS2 for"},{"line_number":289,"context_line":"        libvirt x86)"},{"line_number":290,"context_line":"* ps2mouse: Uses relative movement. Mouse connected by PS2"},{"line_number":291,"context_line":"* usbtablet: Uses absolute movement. Tablet connect by USB"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c517e952","line":288,"in_reply_to":"9a89bdaa_b6e97e81","updated":"2016-09-13 20:29:12.000000000","message":"Nevermind, let\u0027s not add something about this since use_usb_tablet is in the libvirt group and this is in the DEFAULT group, so it would be confusing to mention it.","commit_id":"22a28bdd257a0f6ead663a4f5fe3ab8072da5ea9"}]}