)]}'
{"nova/tests/compute/test_compute.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"36ad911931ac9907473bd1ed8494f1fcb18a50e9","unresolved":false,"context_lines":[{"line_number":6162,"context_line":"        # min_ram and min_disk are not returned when set to default"},{"line_number":6163,"context_line":"        self.assertFalse(\u0027min_ram\u0027 in image)"},{"line_number":6164,"context_line":"        self.assertFalse(\u0027min_disk\u0027 in image)"},{"line_number":6165,"context_line":"        #self.assertEquals(image[\u0027min_disk\u0027], 1)"},{"line_number":6166,"context_line":""},{"line_number":6167,"context_line":"        properties \u003d image[\u0027properties\u0027]"},{"line_number":6168,"context_line":"        self.assertTrue(\u0027backup_type\u0027 not in properties)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2F7uY%3D","line":6165,"updated":"2013-07-18 21:28:58.000000000","message":"don\u0027t comment out an assert, if you are removing just do so.","commit_id":"44a3bd9c55a6f1b50377bc4828cd4fa422538143"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b118df394d2e4c642062d9ae7fc80187d031c874","unresolved":false,"context_lines":[{"line_number":6154,"context_line":""},{"line_number":6155,"context_line":"        self.stubs.Set(fake_image._FakeImageService, \u0027show\u0027, fake_show)"},{"line_number":6156,"context_line":"        instance \u003d self._create_fake_instance()"},{"line_number":6157,"context_line":"        image \u003d self.compute_api.snapshot(self.context, instance, \u0027snap1\u0027,"},{"line_number":6158,"context_line":"                                          {\u0027extra_param\u0027: \u0027value1\u0027})"},{"line_number":6159,"context_line":""},{"line_number":6160,"context_line":"        self.assertEqual(image[\u0027name\u0027], \u0027snap1\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2Fp0w%3D","line":6157,"updated":"2013-07-25 18:17:35.000000000","message":"These changes seem unrelated.  Are the required for this fix?","commit_id":"107b0cc0f54369698e19825b8a1d7d3453098de3"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8635d8592792de2e527bed732e0b819993c82004","unresolved":false,"context_lines":[{"line_number":6154,"context_line":""},{"line_number":6155,"context_line":"        self.stubs.Set(fake_image._FakeImageService, \u0027show\u0027, fake_show)"},{"line_number":6156,"context_line":"        instance \u003d self._create_fake_instance()"},{"line_number":6157,"context_line":"        image \u003d self.compute_api.snapshot(self.context, instance, \u0027snap1\u0027,"},{"line_number":6158,"context_line":"                                          {\u0027extra_param\u0027: \u0027value1\u0027})"},{"line_number":6159,"context_line":""},{"line_number":6160,"context_line":"        self.assertEqual(image[\u0027name\u0027], \u0027snap1\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2Fklc%3D","line":6157,"in_reply_to":"AAAAQn%2F%2Fp0w%3D","updated":"2013-07-28 13:49:36.000000000","message":"It doesn\u0027t work without these changes because now minDisk is being  taken from flavor and appears as 1 here.\n\nThey make this test more correct anyway.","commit_id":"107b0cc0f54369698e19825b8a1d7d3453098de3"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"4f2af3f9f9959bdaf04d3915ef9e76d4314a5b33","unresolved":false,"context_lines":[{"line_number":6145,"context_line":"        # Cells tests will call this a 2nd time in child cell with"},{"line_number":6146,"context_line":"        # the newly created image_id, and we want that one to succeed."},{"line_number":6147,"context_line":"        old_show \u003d fake_image._FakeImageService.show"},{"line_number":6148,"context_line":"        flag \u003d []"},{"line_number":6149,"context_line":""},{"line_number":6150,"context_line":"        def fake_show(*args):"},{"line_number":6151,"context_line":"            if not flag:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQn%2F%2B50I%3D","line":6148,"updated":"2013-08-10 13:27:01.000000000","message":"A list is probably overkill here.  A boolean would do.  Not a big deal though ...","commit_id":"6104225fd0c7c71811635eb0e0e5cbdee8306fc4"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a493c1563246aa14efe148fd903fe287be359c3a","unresolved":false,"context_lines":[{"line_number":6145,"context_line":"        # Cells tests will call this a 2nd time in child cell with"},{"line_number":6146,"context_line":"        # the newly created image_id, and we want that one to succeed."},{"line_number":6147,"context_line":"        old_show \u003d fake_image._FakeImageService.show"},{"line_number":6148,"context_line":"        flag \u003d []"},{"line_number":6149,"context_line":""},{"line_number":6150,"context_line":"        def fake_show(*args):"},{"line_number":6151,"context_line":"            if not flag:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQ3%2F%2F8Og%3D","line":6148,"in_reply_to":"AAAAQn%2F%2B50I%3D","updated":"2013-08-12 18:18:18.000000000","message":"Actually, I don\u0027t think a simple boolean would work here; if you use an assignment in fake_show(), that would give rise to a new local within fake_show() only—and since the value of flag is tested before it would be assigned, Python would give a compilation about the variable being used before it was defined.\n\nA lot of tests have this idiom for just this reason: to allow an inner function to communicate state to the enclosing function.","commit_id":"6104225fd0c7c71811635eb0e0e5cbdee8306fc4"}]}