)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4ffeb0edd67c03c7137472fe5d959cbdef29758a","unresolved":false,"context_lines":[{"line_number":5526,"context_line":"        #                  this is called a second time because"},{"line_number":5527,"context_line":"        #                  multi_host does not create the bridge in"},{"line_number":5528,"context_line":"        #                  plug_vifs"},{"line_number":5529,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5530,"context_line":"                                                         self.host)"},{"line_number":5531,"context_line":"        migration \u003d {\u0027source_compute\u0027: instance.host,"},{"line_number":5532,"context_line":"                     \u0027dest_compute\u0027: self.host, }"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_190eb98b","side":"PARENT","line":5529,"updated":"2016-11-29 14:49:52.000000000","message":"I do not know much about why we have to call that one here, but according to the note it seems that we need to investigate little more before to remove it.","commit_id":"e3662147dc5f73730baa8493417fa52e9a9fd563"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3036ef90a7c792a30a85867ae5f8b68c9395b30a","unresolved":false,"context_lines":[{"line_number":5572,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"},{"line_number":5573,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5574,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5575,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5576,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":5577,"context_line":"        self._notify_about_instance_usage("},{"line_number":5578,"context_line":"                     context, instance, \"live_migration.post.dest.end\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_8dffcda9","side":"PARENT","line":5575,"updated":"2016-09-19 13:36:53.000000000","message":"Isn\u0027t this still the case?","commit_id":"e3662147dc5f73730baa8493417fa52e9a9fd563"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4ffeb0edd67c03c7137472fe5d959cbdef29758a","unresolved":false,"context_lines":[{"line_number":5572,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"},{"line_number":5573,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5574,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5575,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5576,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":5577,"context_line":"        self._notify_about_instance_usage("},{"line_number":5578,"context_line":"                     context, instance, \"live_migration.post.dest.end\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_fc580633","side":"PARENT","line":5575,"in_reply_to":"7a8ec9b2_54f8e9c4","updated":"2016-11-29 14:49:52.000000000","message":"We can\u0027t remove that code. We need to first teardown on source host to update the dhcp on destination in context of multi_node.\n\nSo basically we should have one call of setup_networks_on_host at pre_live_migration to initialize networks if they do not exist on destination, then we migrate, then we teardown on source, then we update the hostsfile for the dhcp on destination.","commit_id":"e3662147dc5f73730baa8493417fa52e9a9fd563"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"537132849330afa8179120b1afc9257c290ff42c","unresolved":false,"context_lines":[{"line_number":5572,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"},{"line_number":5573,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5574,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5575,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5576,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":5577,"context_line":"        self._notify_about_instance_usage("},{"line_number":5578,"context_line":"                     context, instance, \"live_migration.post.dest.end\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_54f8e9c4","side":"PARENT","line":5575,"in_reply_to":"7a8ec9b2_8dffcda9","updated":"2016-09-19 15:16:04.000000000","message":"This will be the third time we\u0027ve run it. What would be different from the previous 2? Can we do it and see?","commit_id":"e3662147dc5f73730baa8493417fa52e9a9fd563"}]}