)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d4dfbe281c0a91ce95b4db87173bbc0f611e3be4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"parsing and acting on the network info. For now we just set the mtu for"},{"line_number":15,"context_line":"a second time once os-vif has done what it wants to do."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Releated-Bug: #1623876"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id4ca38fa1bb84f8cdb5edcd9ccb7acd8c8e9b60c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_f06e012e","line":17,"updated":"2016-09-15 11:28:01.000000000","message":"Shouldn\u0027t it be Closes-Bug?","commit_id":"891060ac75c1ea101ed6b026b6fbeb22ea2a3047"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4ea8093665a5de3f121f9cf46ab16d23997f05bd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Override MTU for os_vif attachments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os-vif does not current respect the neutron provided mtu, it just uses"},{"line_number":10,"context_line":"the configuration inside os-vif. This is a big regression from mitaka"},{"line_number":11,"context_line":"and liberty."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8ec9b2_987f8a65","line":9,"updated":"2016-09-15 20:36:19.000000000","message":"s/current/currently/","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e262f16997c76efa1fe60d032150b46e5a747d33","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":1613,"context_line":"        d.plug(self.instance, self.vif_bridge)"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        mock_set_mtu.assert_called_once_with(\"br0\", 9000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_709cb1c0","line":1615,"updated":"2016-09-15 11:16:21.000000000","message":"We should have a second test with a vif where \u0027mtu\u0027 is not set, or set to None to ensure set_mtu is not called","commit_id":"fd1d66a4f0c0e3e90a2f3c2186963987e4142688"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b38c26869f1ce8ad6290f61f53b11f51c30e5a39","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"                 mock.call("},{"line_number":1310,"context_line":"                     \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1311,"context_line":"                     \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1312,"context_line":"                     \u0027f0000000-0000-0000-0000-000000000001\u0027, None,"},{"line_number":1313,"context_line":"                     interface_type\u003dnetwork_model.OVS_VHOSTUSER_INTERFACE_TYPE"},{"line_number":1314,"context_line":"                 )]"},{"line_number":1315,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_9a5bfaf5","line":1312,"range":{"start_line":1312,"start_character":61,"end_line":1312,"end_character":65},"updated":"2016-09-15 20:48:32.000000000","message":"What\u0027s up with the vhostuser mtu changes here?","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"539e3ec8bcfa3704fa675a5a9a70e41469bf41e6","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"                 mock.call("},{"line_number":1310,"context_line":"                     \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1311,"context_line":"                     \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1312,"context_line":"                     \u0027f0000000-0000-0000-0000-000000000001\u0027, None,"},{"line_number":1313,"context_line":"                     interface_type\u003dnetwork_model.OVS_VHOSTUSER_INTERFACE_TYPE"},{"line_number":1314,"context_line":"                 )]"},{"line_number":1315,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_bad35603","line":1312,"range":{"start_line":1312,"start_character":61,"end_line":1312,"end_character":65},"in_reply_to":"7a8ec9b2_9a5bfaf5","updated":"2016-09-15 20:53:12.000000000","message":"Is it because self.vif_vhostuser_ovs uses network_bridge which now doesn\u0027t have mtu set?","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9399246ed5738546139db0825b79c61171135bdb","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"        mock_convert_inst.return_value \u003d self.os_vif_inst_info"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":1613,"context_line":"        d.plug(self.instance, self.vif_bridge)"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        self.assertFalse(mock_set_mtu.called)"},{"line_number":1616,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_da8822c8","line":1613,"updated":"2016-09-15 20:57:00.000000000","message":"I think we could avoid hacking up all of the vhostuser tests above if we use a different vif/network_bridge for this test, or just hack the network mtu that\u0027s in vif_bridge. That would be my preference.","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d46eedfc0f8cbb68cde12335b52f0497b591750","unresolved":false,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"},{"line_number":1613,"context_line":"        # Hack the network mtu in the vif_bridge object"},{"line_number":1614,"context_line":"        self.vif_bridge[\u0027network\u0027]._set_meta({\u0027mtu\u0027: None})"},{"line_number":1615,"context_line":"        d.plug(self.instance, self.vif_bridge)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"        self.assertFalse(mock_set_mtu.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_96f10e04","line":1614,"updated":"2016-09-15 23:54:56.000000000","message":"This is probably a global state change messing up other tests:\n\nhttp://logs.openstack.org/81/370681/8/gate/gate-nova-python27-db-ubuntu-xenial/87b6e37/console.html#_2016-09-15_22_54_49_868786\n\nI\u0027ll see if I can just deepcopy that object and mutate it.","commit_id":"1ce571abe4dc135f3671257c21a47bbb266a52a8"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8b448ba03c0d1c730699c784f4be8c112060fdd1","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        # TODO(johngarbutt) really this should be done by os_vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        linux_net._set_device_mtu(vif.network.bridge, mtu)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def plug(self, instance, vif):"},{"line_number":791,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3aaa0a71","line":788,"updated":"2016-09-15 10:45:29.000000000","message":"You should surround this in \u0027if mtu is not None\u0027, otherwise set_device_mtu is going to apply nova\u0027s global default MTU, which will override the os-vif global default MTU - we only want to override os-vif if a per-VIF mtu is set in the network object.","commit_id":"c84e4fcd7eb533e2075761ec0b06b04b77c2c0aa"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f83456785f4318b68578fd01a4374d644f1cf276","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        if network is not None:"},{"line_number":788,"context_line":"            mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    def plug(self, instance, vif):"},{"line_number":792,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_35f4db84","line":789,"updated":"2016-09-15 11:08:02.000000000","message":"You\u0027re checking for network being None twice now - it is \u0027mtu\u0027 that you need to check before calling _set_device_mtu","commit_id":"1a52540e1417e90616228391507dfd5a175937f1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2034876e932b8918dcd7401d2ae5e62a8fd6fabe","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        if network is not None:"},{"line_number":788,"context_line":"            mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    def plug(self, instance, vif):"},{"line_number":792,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_d024a5b0","line":789,"updated":"2016-09-15 11:15:37.000000000","message":"Still checking network \u003d\u003d None twice, and still needs to skip _set_device_mtu if mtu is None","commit_id":"fd1d66a4f0c0e3e90a2f3c2186963987e4142688"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"5ff223549d7a0a15a83f841c17081c6c10077839","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                   % {\u0027ex\u0027: ex})"},{"line_number":783,"context_line":"            raise exception.NovaException(msg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # TODO(johngarbutt) really this should be done by os_vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_1009ad31","line":785,"updated":"2016-09-15 11:31:38.000000000","message":"Nitpick, lets explicitly mention the bug number and explicitly say this must be reverted when Nova updats to next os-vif release.","commit_id":"891060ac75c1ea101ed6b026b6fbeb22ea2a3047"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93cc5c8fd929b39791267712434d686406c937ef","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                   % {\u0027ex\u0027: ex})"},{"line_number":783,"context_line":"            raise exception.NovaException(msg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # TODO(johngarbutt) really this should be done by os_vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_2b4d5a6c","line":785,"in_reply_to":"7a8ec9b2_1009ad31","updated":"2016-09-15 11:35:59.000000000","message":"yeah, I should do that, oops.","commit_id":"891060ac75c1ea101ed6b026b6fbeb22ea2a3047"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0e400a740522dbc5ac93d8d5bec5e6ec0a519726","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        # TODO(johngarbutt) really this should be done by os_vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_105b6d55","line":788,"updated":"2016-09-15 11:31:52.000000000","message":"this only gets the bridge. it would also need to get the veth interfaces that attach to OVS","commit_id":"891060ac75c1ea101ed6b026b6fbeb22ea2a3047"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93cc5c8fd929b39791267712434d686406c937ef","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        # TODO(johngarbutt) really this should be done by os_vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_ebde126c","line":788,"in_reply_to":"7a8ec9b2_105b6d55","updated":"2016-09-15 11:35:59.000000000","message":"ah, I guess that must be this bit: https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/linux_net.py#L122\n\nI will dig more into that.","commit_id":"891060ac75c1ea101ed6b026b6fbeb22ea2a3047"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0ee1588fb5b576874c4403523a4ceb3699d23d9","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_a82877e3","line":789,"range":{"start_line":789,"start_character":38,"end_line":789,"end_character":55},"updated":"2016-09-15 18:12:51.000000000","message":"This makes me a little nervous about a KeyError given:\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/os_vif_util.py#L209\n\nAnd bridge may not be set based on:\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/neutronv2/api.py#L2103","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6aa26c17233ecf0be7768f203bfaa0de25ed4702","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_23bc88db","line":789,"range":{"start_line":789,"start_character":38,"end_line":789,"end_character":55},"in_reply_to":"7a8ec9b2_a82877e3","updated":"2016-09-15 18:18:42.000000000","message":"Can\u0027t we check vif.bridge_name for this, just looking at:\n\nhttps://github.com/openstack/os-vif/blob/1.2.1/vif_plug_ovs/ovs.py#L61\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/os_vif_util.py#L271\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/os_vif_util.py#L279\n\nI guess in the case of vif_type\u003dbridge or ovs we\u0027d have network.bridge set in the raw_vif from https://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/neutronv2/api.py#L2103 - we don\u0027t care about the vhostuser case since we can\u0027t get this far in that case since we haven\u0027t converted to using os-vif for that vif_type yet.","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0ee1588fb5b576874c4403523a4ceb3699d23d9","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"},{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_03306ce7","line":791,"range":{"start_line":791,"start_character":47,"end_line":791,"end_character":56},"updated":"2016-09-15 18:12:51.000000000","message":"Looking at:\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/os_vif_util.py#L261\n\nWhy just os_vif.objects.vif.VIFBridge and not also check for os_vif.objects.vif.VIFOpenVSwitch?","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0ee1588fb5b576874c4403523a4ceb3699d23d9","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"},{"line_number":795,"context_line":"            veths \u003d ["},{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_88ebbb77","line":797,"range":{"start_line":796,"start_character":16,"end_line":797,"end_character":64},"updated":"2016-09-15 18:12:51.000000000","message":"I guess this is consistent with:\n\nhttps://github.com/openstack/nova/blob/59dd4a48b97f61564fa6b54e21a85fca62480d20/nova/network/neutronv2/api.py#L2198-L2199\n\nAnd matches what\u0027s going on here for devices:\n\nhttps://github.com/openstack/os-vif/blob/1.2.1/vif_plug_ovs/ovs.py#L61","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4ea8093665a5de3f121f9cf46ab16d23997f05bd","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"},{"line_number":795,"context_line":"            veths \u003d ["},{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_c4dda7e1","line":797,"range":{"start_line":796,"start_character":16,"end_line":797,"end_character":64},"in_reply_to":"7a8ec9b2_88ebbb77","updated":"2016-09-15 20:36:19.000000000","message":"I guess I don\u0027t understand why we\u0027re not just using the get_veth_pair_names() method of the plugin?","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f68680ae3f9e8e47161e7bb823c85e833ca6d3d","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"},{"line_number":795,"context_line":"            veths \u003d ["},{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_ff2dd0a8","line":797,"range":{"start_line":796,"start_character":16,"end_line":797,"end_character":64},"in_reply_to":"7a8ec9b2_c4dda7e1","updated":"2016-09-15 20:38:28.000000000","message":"+1","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec7944ad0e0f6d2abd130dba5e16b32e26d82607","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_55322b60","line":799,"updated":"2016-09-15 18:31:54.000000000","message":"Do we know that these devices exist? See here:\n\nhttps://review.openstack.org/#/c/284209/6/vif_plug_ovs/ovs_hybrid.py","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4ea8093665a5de3f121f9cf46ab16d23997f05bd","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_abc6ae97","line":799,"in_reply_to":"7a8ec9b2_55322b60","updated":"2016-09-15 20:36:19.000000000","message":"Yes, they will exist after line 779 above.","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f68680ae3f9e8e47161e7bb823c85e833ca6d3d","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_5f1fa46b","line":799,"in_reply_to":"7a8ec9b2_abc6ae97","updated":"2016-09-15 20:38:28.000000000","message":"whew","commit_id":"0703490d37debdd6385abafa47727aeb0d809265"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"510b189eea0790722b8c30367b2fdc7deff31890","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                   % {\u0027ex\u0027: ex})"},{"line_number":783,"context_line":"            raise exception.NovaException(msg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # TODO(johngarbutt) remove this hack once 1623876 is fixed in os-vif"},{"line_number":786,"context_line":"        network \u003d raw_vif.get(\u0027network\u0027)"},{"line_number":787,"context_line":"        mtu \u003d network.get_meta(\u0027mtu\u0027) if network else None"},{"line_number":788,"context_line":"        if mtu is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_40f16000","line":785,"updated":"2016-09-16 12:33:31.000000000","message":"This hack breaks networking-ovn.","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"510b189eea0790722b8c30367b2fdc7deff31890","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_c053b0e0","line":799,"updated":"2016-09-16 12:33:31.000000000","message":"If the devices don\u0027t exist then there\u0027s no need to set the device MTU which should fix the troubles networking-ovn is seeing: http://paste.openstack.org/show/579969/","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"504c95ef8fcd4edf2367f704fd2fa531012dc3e6","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_340d76e8","line":799,"in_reply_to":"7a8ec9b2_8622a050","updated":"2016-09-16 13:35:18.000000000","message":"Bug filed: https://bugs.launchpad.net/nova/+bug/1624392","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"484f2d4ae9e23dc605a9794003045fbece044eda","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_8622a050","line":799,"in_reply_to":"7a8ec9b2_a3dcee73","updated":"2016-09-16 13:01:17.000000000","message":"http://logs.openstack.org/75/371175/1/check/gate-tempest-dsvm-networking-ovn/7e52927/logs/screen-n-cpu.txt.gz?level\u003dTRACE#_2016-09-16_11_20_39_627","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30d8a82f0b3f7e95b7017bf033e1d7e3565b8a90","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_a3dcee73","line":799,"in_reply_to":"7a8ec9b2_c053b0e0","updated":"2016-09-16 12:51:01.000000000","message":"Hmm, I asked about this in an earlier review on this and Jay said that os_vif.plug on L779 would handle the device existence checks. I guess it\u0027s different for OVN?","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d4fccaf2bec7a45a259f201447cc1320369a575d","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                (\"qvb%s\" % vif.id)[:network_model.NIC_NAME_LEN],"},{"line_number":797,"context_line":"                (\"qvo%s\" % vif.id)[:network_model.NIC_NAME_LEN]]"},{"line_number":798,"context_line":"            for veth in veths:"},{"line_number":799,"context_line":"                linux_net._set_device_mtu(veth, mtu)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def plug(self, instance, vif):"},{"line_number":802,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_a3406e35","line":799,"in_reply_to":"7a8ec9b2_c053b0e0","updated":"2016-09-16 12:49:02.000000000","message":"Please file a bug rather than commenting on now-merged commits.","commit_id":"77f546623bb6c0b2a4441940f1740abd45bd3352"}]}