)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2dadf9e53f6a8c3672a4324029a0f7f71e46350c","unresolved":false,"context_lines":[{"line_number":708,"context_line":"]"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"libvirt_remotefs_opts \u003d ["},{"line_number":711,"context_line":"    cfg.StrOpt(\u0027remote_filesystem_transport\u0027,"},{"line_number":712,"context_line":"               default\u003d\u0027ssh\u0027,"},{"line_number":713,"context_line":"               choices\u003d(\u0027ssh\u0027, \u0027rsync\u0027),"},{"line_number":714,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_9bdd0117","line":711,"range":{"start_line":711,"start_character":16,"end_line":711,"end_character":43},"updated":"2016-11-16 10:23:59.000000000","message":"As a side note:\n\nThis config option got introduced with http://git.openstack.org/cgit/openstack/nova-specs/tree/specs/liberty/approved/implementation-of-remote-fs-driver-based-on-rsync-for-libvirt.rst and cleaned up the existing way of remote file/directory handling. It seems like this is mainly used in migration scenarios (copy config driver for example) but I can\u0027t escape the feeling that we don\u0027t want to do remote filesystem interaction between compute nodes. I thought that\u0027s the task of conductor to orchestrate such things. I don\u0027t want to add another item on the \"things to consider in the future\" pile though.","commit_id":"a413646532904d31d0d6afb70f090e6e565791ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9817820c81f0bb7b991a64f8bf6e09f0eb3f647b","unresolved":false,"context_lines":[{"line_number":712,"context_line":"               default\u003d\u0027ssh\u0027,"},{"line_number":713,"context_line":"               choices\u003d(\u0027ssh\u0027, \u0027rsync\u0027),"},{"line_number":714,"context_line":"               help\u003d\"\"\""},{"line_number":715,"context_line":"libvirt\u0027s transport method for remote file operations."},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"Because libvirt cannot use RPC to copy files over network to/from other"},{"line_number":718,"context_line":"compute nodes, other method must be used for:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_adef22af","line":715,"range":{"start_line":715,"start_character":0,"end_line":715,"end_character":10},"updated":"2016-09-28 15:51:54.000000000","message":"You could remove this bit as it\u0027s clearly libvirt related (hence the section)","commit_id":"a413646532904d31d0d6afb70f090e6e565791ea"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2dadf9e53f6a8c3672a4324029a0f7f71e46350c","unresolved":false,"context_lines":[{"line_number":717,"context_line":"Because libvirt cannot use RPC to copy files over network to/from other"},{"line_number":718,"context_line":"compute nodes, other method must be used for:"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"* creating directory on remote host"},{"line_number":721,"context_line":"* creating file on remote host"},{"line_number":722,"context_line":"* removing file from remote host"},{"line_number":723,"context_line":"* copying file to remote host"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_7b72e54a","line":720,"range":{"start_line":720,"start_character":2,"end_line":720,"end_character":10},"updated":"2016-11-16 10:23:59.000000000","message":"nit: It\u0027s also used to delete directories on the remote host, the class \"RemoteFilesystemDriver\" has an interface for that: https://github.com/openstack/nova/blob/270be6906c13bc621a7ad507b8ae729a940609d2/nova/virt/libvirt/volume/remotefs.py#L119-L119","commit_id":"a413646532904d31d0d6afb70f090e6e565791ea"}]}