)]}'
{"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ed2d2f5e8ffda0265d5855c66b848fde95537194","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"        self.assertEqual(3, mock_set_mtu.call_count)"},{"line_number":1639,"context_line":"        mock_set_mtu.assert_any_call(\"br0\", 9000)"},{"line_number":1640,"context_line":"        mock_set_mtu.assert_any_call(\"qvbdc065497-3c\", 9000)"},{"line_number":1641,"context_line":"        mock_set_mtu.assert_any_call(\"qvodc065497-3c\", 9000)"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @mock.patch(\u0027nova.network.linux_net._set_device_mtu\u0027)"},{"line_number":1644,"context_line":"    @mock.patch(\"nova.network.os_vif_util.nova_to_osvif_instance\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_4fa26b4c","line":1641,"updated":"2016-09-16 13:59:42.000000000","message":"well, we generally use assert_has_calls() with a list of calls, which means that we are sure they\u0027re all set correctly at the same order without no other left call, but that\u0027s a nit.","commit_id":"0947ba6d5331bb8b114f86fc5ad105fe4b521a6a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"44cecd95d4690e7a92dff2b3c892d5b98480aa54","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"        self.assertEqual(3, mock_set_mtu.call_count)"},{"line_number":1639,"context_line":"        mock_set_mtu.assert_any_call(\"br0\", 9000)"},{"line_number":1640,"context_line":"        mock_set_mtu.assert_any_call(\"qvbdc065497-3c\", 9000)"},{"line_number":1641,"context_line":"        mock_set_mtu.assert_any_call(\"qvodc065497-3c\", 9000)"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @mock.patch(\u0027nova.network.linux_net._set_device_mtu\u0027)"},{"line_number":1644,"context_line":"    @mock.patch(\"nova.network.os_vif_util.nova_to_osvif_instance\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5a230ba7","line":1641,"in_reply_to":"7a8ec9b2_4fa26b4c","updated":"2016-09-16 14:03:49.000000000","message":"yeah, thats the call I was trying to remember yesterday, and gave up trying.","commit_id":"0947ba6d5331bb8b114f86fc5ad105fe4b521a6a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6637b7eb21c45392abdfdfd14ce19d5b81d90750","unresolved":false,"context_lines":[{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"        self.assertEqual(1, mock_set_mtu.call_count)"},{"line_number":1657,"context_line":"        mock_set_mtu.assert_any_call(\"br0\", 1000)"},{"line_number":1658,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_9dabca74","line":1658,"updated":"2016-09-16 15:14:30.000000000","message":"pep8 fail:\n\nhttp://logs.openstack.org/43/371543/2/check/gate-nova-pep8-ubuntu-xenial/a3c5a32/console.html#_2016-09-16_13_58_58_572834","commit_id":"0947ba6d5331bb8b114f86fc5ad105fe4b521a6a"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cbf3c732cee52d2c0fc9f94f2681bc0d2b227968","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"},{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_54e042fa","line":791,"updated":"2016-09-16 13:36:31.000000000","message":"Probably better to make this do what I meant it to do.","commit_id":"789e8d4e4e0a4f0c7dccec883c9fe3391b0eb6cb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8c846de83fa9868d63cd6be0c3ebd8989ff5f0b5","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"},{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_34b2d606","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":56},"updated":"2016-09-16 13:36:39.000000000","message":"danpb pointed out this is wrong and why we\u0027re getting into this code block","commit_id":"789e8d4e4e0a4f0c7dccec883c9fe3391b0eb6cb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"50ba98bf936e417e513c012da58f260d18d4991d","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"},{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_2ffc3f71","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":56},"in_reply_to":"7a8ec9b2_2f56ffcd","updated":"2016-09-16 13:55:59.000000000","message":"Here\u0027s the OVN vif information when launching an instance: \n\n\nVIFOpenVSwitch(active\u003dFalse,address\u003dfa:16:3e:6f:05:c7,bridge_name\u003d\u0027br-int\u0027,has_traffic_filtering\u003dTrue,id\u003dfb8ece94-9a50-4fb0-ae00-8c680d20b458,network\u003dNetwork(b49a2fbd-1d51-454c-9019-e209597e6849),plugin\u003d\u0027ovs\u0027,port_profile\u003dVIFPortProfileBase,preserve_on_delete\u003dFalse,vif_name\u003d\u0027tapfb8ece94-9a\u0027)","commit_id":"789e8d4e4e0a4f0c7dccec883c9fe3391b0eb6cb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5612d7d75e2224902ecf2e4bda1ffb1980a1a12c","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        if mtu is not None:"},{"line_number":789,"context_line":"            linux_net._set_device_mtu(network[\"bridge\"], mtu)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFBridge) and"},{"line_number":792,"context_line":"            hasattr(vif, \"port_profile\") and"},{"line_number":793,"context_line":"            isinstance(vif.port_profile,"},{"line_number":794,"context_line":"                       os_vif.objects.vif.VIFPortProfileOpenVSwitch)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_2f56ffcd","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":56},"in_reply_to":"7a8ec9b2_34b2d606","updated":"2016-09-16 13:50:44.000000000","message":"OVN uses ovs vif type for port binding.  I\u0027ll have to dig into the code more to know what instance type is used here.","commit_id":"789e8d4e4e0a4f0c7dccec883c9fe3391b0eb6cb"}]}