)]}'
{"nova/api/openstack/compute/plugins/v3/agents.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"0fbc29bc9ca723c5446ae78799cf2a2932b9af05","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            md5hash \u003d para[\u0027md5hash\u0027]"},{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"},{"line_number":103,"context_line":"        except (TypeError, KeyError):"},{"line_number":104,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            db.agent_build_update(context, id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhQc%3D","line":104,"updated":"2013-07-17 02:35:14.000000000","message":"tchange here to the  following maybe better\n except KeyError as e:\n      msg \u003d _(\"Could not find %s parameter in the request\") % e.args[0]\n      raise webob.exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d1394a746ca701c9a36752dc548689a0f3f2e165","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            md5hash \u003d para[\u0027md5hash\u0027]"},{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"},{"line_number":103,"context_line":"        except (TypeError, KeyError):"},{"line_number":104,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            db.agent_build_update(context, id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhGY%3D","line":104,"in_reply_to":"AAAAP3%2F%2FhMU%3D","updated":"2013-07-17 03:24:28.000000000","message":"Hi, Ivan-Zhu, There is also TypeError. If we want to better error message, this need more modification. Actually after \u0027API input validation framework https://review.openstack.org/#/c/25358/\u0027 merged, all those will be removed. So is it ok we just leave this at here?","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ddebe452016a4a2bb6952a4bf52012d257c495bc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            md5hash \u003d para[\u0027md5hash\u0027]"},{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"},{"line_number":103,"context_line":"        except (TypeError, KeyError):"},{"line_number":104,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            db.agent_build_update(context, id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhMU%3D","line":104,"in_reply_to":"AAAAP3%2F%2FhQc%3D","updated":"2013-07-17 03:05:18.000000000","message":"done","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"0fbc29bc9ca723c5446ae78799cf2a2932b9af05","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            version \u003d agent[\u0027version\u0027]"},{"line_number":141,"context_line":"            url \u003d agent[\u0027url\u0027]"},{"line_number":142,"context_line":"            md5hash \u003d agent[\u0027md5hash\u0027]"},{"line_number":143,"context_line":"        except (TypeError, KeyError):"},{"line_number":144,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhPg%3D","line":143,"updated":"2013-07-17 02:35:14.000000000","message":"ditto","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c6c46bfd4b08da85d0fdf55c7064ef22e7e11e0f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"},{"line_number":103,"context_line":"        except TypeError as e:"},{"line_number":104,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":105,"context_line":"                \"The parameter must be dict\"))"},{"line_number":106,"context_line":"        except KeyError as e:"},{"line_number":107,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":108,"context_line":"                \"Could not find %s parameter in the request\") % e.args[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Ff%2Bc%3D","line":105,"updated":"2013-07-17 10:37:20.000000000","message":"Not sure that makes sense to XML folk, maybe no explanation for this one is easiest?","commit_id":"3c468a2be92785e94a9d92be39b578b4147d6d64"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3c3a8760c831d1322fd2f8ae3c923acf0d0d4651","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"},{"line_number":103,"context_line":"        except TypeError as e:"},{"line_number":104,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":105,"context_line":"                \"The parameter must be dict\"))"},{"line_number":106,"context_line":"        except KeyError as e:"},{"line_number":107,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":108,"context_line":"                \"Could not find %s parameter in the request\") % e.args[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F%2FCY%3D","line":105,"in_reply_to":"AAAAP3%2F%2Ff%2Bc%3D","updated":"2013-07-18 00:34:56.000000000","message":"Good point, thanks","commit_id":"3c468a2be92785e94a9d92be39b578b4147d6d64"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"99224612738ad3f1c93d9876b6c20417d5390cd9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        authorize(context)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            para \u003d body[\u0027agent\u0027]"},{"line_number":100,"context_line":"            url \u003d para[\u0027url\u0027]"},{"line_number":101,"context_line":"            md5hash \u003d para[\u0027md5hash\u0027]"},{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FvJk%3D","line":99,"updated":"2013-07-24 06:52:38.000000000","message":"To fit coding style in this file(line139-145), how about changing the name from \"para\" to \"agent\"?","commit_id":"f95ceb40a87d9113b2b2efa9142f4486d09e855c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"dc0ad6ce73c7dc888e02c344240a5e897f72035e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        authorize(context)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            para \u003d body[\u0027agent\u0027]"},{"line_number":100,"context_line":"            url \u003d para[\u0027url\u0027]"},{"line_number":101,"context_line":"            md5hash \u003d para[\u0027md5hash\u0027]"},{"line_number":102,"context_line":"            version \u003d para[\u0027version\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Ft9k%3D","line":99,"in_reply_to":"AAAAQn%2F%2FvJk%3D","updated":"2013-07-24 14:38:31.000000000","message":"i agree, its minor, but probably worth doing this cleanup while you\u0027re here if you have to do another rev anyway, otherwise I don\u0027t see it as a big deal.","commit_id":"f95ceb40a87d9113b2b2efa9142f4486d09e855c"}],"nova/tests/api/openstack/compute/plugins/v3/test_agents.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"0fbc29bc9ca723c5446ae78799cf2a2932b9af05","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                \u0027md5hash\u0027: \u0027add6bb58e139be103324d04d82d8f545\u0027}}"},{"line_number":134,"context_line":"        self.assertRaises(exc.HTTPConflict, self.controller.create, req, body)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_agents_create_with_bad_request(self):"},{"line_number":137,"context_line":"        req \u003d FakeRequest()"},{"line_number":138,"context_line":"        body \u003d {\u0027agent\u0027: {\u0027hypervisor\u0027: \u0027kvm\u0027,"},{"line_number":139,"context_line":"                \u0027os\u0027: \u0027win\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhPA%3D","line":136,"updated":"2013-07-17 02:35:14.000000000","message":"I think if we can split this to multiple tests, it will be better. One run can find all faild.","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ddebe452016a4a2bb6952a4bf52012d257c495bc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                \u0027md5hash\u0027: \u0027add6bb58e139be103324d04d82d8f545\u0027}}"},{"line_number":134,"context_line":"        self.assertRaises(exc.HTTPConflict, self.controller.create, req, body)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_agents_create_with_bad_request(self):"},{"line_number":137,"context_line":"        req \u003d FakeRequest()"},{"line_number":138,"context_line":"        body \u003d {\u0027agent\u0027: {\u0027hypervisor\u0027: \u0027kvm\u0027,"},{"line_number":139,"context_line":"                \u0027os\u0027: \u0027win\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhK4%3D","line":136,"in_reply_to":"AAAAP3%2F%2FhPA%3D","updated":"2013-07-17 03:05:18.000000000","message":"Done","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"0fbc29bc9ca723c5446ae78799cf2a2932b9af05","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        res_dict \u003d self.controller.update(req, 1, body)"},{"line_number":235,"context_line":"        self.assertEqual(res_dict, response)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_agents_update_with_bad_request(self):"},{"line_number":238,"context_line":"        req \u003d FakeRequest()"},{"line_number":239,"context_line":"        body \u003d {\u0027agent\u0027: {\u0027version\u0027: \u00277.0\u0027,"},{"line_number":240,"context_line":"                \u0027url\u0027: \u0027xxx://xxxx/xxx/xxx\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FhO8%3D","line":237,"updated":"2013-07-17 02:35:14.000000000","message":"ditto","commit_id":"f16f45ed072a8631adb141e282fdd947b9b0ca34"}]}