)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a1acdfaff1f995c2db895e1ec13be54e0dd7659","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Nova ignores aarch64 while verifying for hugepage and NUMA support."},{"line_number":10,"context_line":"AARCH64 also supports hugepage and NUMA on the same libvirt versions as of x86."},{"line_number":11,"context_line":"Hence adding this chek for aarch64 also."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7b5ae1dbdca4fdd0aee2eefd4099c4c4953b609a"},{"line_number":14,"context_line":"Closes-bug: #1623871"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a8bc5a2_273ac3cc","line":12,"updated":"2016-09-26 09:03:02.000000000","message":"IMHO, you should also add a reno releasenote saying \"feature\".\n\nhttp://docs.openstack.org/developer/nova/code-review.html#release-notes","commit_id":"190990e7c864deb7034d857630f34f6b26ceba4a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a1acdfaff1f995c2db895e1ec13be54e0dd7659","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Hence adding this chek for aarch64 also."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7b5ae1dbdca4fdd0aee2eefd4099c4c4953b609a"},{"line_number":14,"context_line":"Closes-bug: #1623871"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a8bc5a2_0744e747","line":14,"updated":"2016-09-26 09:03:02.000000000","message":"That really looks like a new architecture supported by Nova, hence me saying it shouldn\u0027t be a bugfix, rather a blueprint.","commit_id":"190990e7c864deb7034d857630f34f6b26ceba4a"}],"nova/compute/arch.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4c58e97344f53f112c71438fea75134a0085a664","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        newname \u003d X86_64"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    if newname \u003d\u003d \"aarch64\":"},{"line_number":160,"context_line":"        newname \u003d AARCH64"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if not is_valid(newname):"},{"line_number":163,"context_line":"        raise exception.InvalidArchitectureName(arch\u003dname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_0d9614f0","line":160,"updated":"2016-09-23 09:25:20.000000000","message":"WTF ? The AARCH64 constant expands to \u0027aarch64\u0027 already, so you\u0027re replacing \u0027newname\u0027 with the value it already has.","commit_id":"7311e74d141509c17015405112cb4017067e99ec"},{"author":{"_account_id":12485,"name":"Veena","email":"mveenasl@gmail.com","username":"Veena"},"change_message_id":"b9d771c97b889e014e5be643363aeded36617394","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        newname \u003d X86_64"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    if newname \u003d\u003d \"aarch64\":"},{"line_number":160,"context_line":"        newname \u003d AARCH64"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if not is_valid(newname):"},{"line_number":163,"context_line":"        raise exception.InvalidArchitectureName(arch\u003dname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_045eaa43","line":160,"in_reply_to":"5a8bc5a2_0d9614f0","updated":"2016-09-26 07:14:42.000000000","message":"Done","commit_id":"7311e74d141509c17015405112cb4017067e99ec"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4c58e97344f53f112c71438fea75134a0085a664","unresolved":false,"context_lines":[{"line_number":5109,"context_line":"                return False"},{"line_number":5110,"context_line":""},{"line_number":5111,"context_line":"        support_matrix \u003d {(arch.I686, arch.X86_64,"},{"line_number":5112,"context_line":"                           arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,"},{"line_number":5113,"context_line":"                          (arch.PPC64,"},{"line_number":5114,"context_line":"                           arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}"},{"line_number":5115,"context_line":"        caps \u003d self._host.get_capabilities()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_0d19b488","line":5112,"updated":"2016-09-23 09:25:20.000000000","message":"How have you verified that this version is sufficient for aarch64.","commit_id":"7311e74d141509c17015405112cb4017067e99ec"},{"author":{"_account_id":12485,"name":"Veena","email":"mveenasl@gmail.com","username":"Veena"},"change_message_id":"b9d771c97b889e014e5be643363aeded36617394","unresolved":false,"context_lines":[{"line_number":5109,"context_line":"                return False"},{"line_number":5110,"context_line":""},{"line_number":5111,"context_line":"        support_matrix \u003d {(arch.I686, arch.X86_64,"},{"line_number":5112,"context_line":"                           arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,"},{"line_number":5113,"context_line":"                          (arch.PPC64,"},{"line_number":5114,"context_line":"                           arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}"},{"line_number":5115,"context_line":"        caps \u003d self._host.get_capabilities()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_849c7a10","line":5112,"in_reply_to":"5a8bc5a2_0d19b488","updated":"2016-09-26 07:14:42.000000000","message":"NUMA support is there from version 1.2.1. \nWe have enabled the flag \"WITH_NUMA \u003d --with-numactl\" in libvirt while compiling it, which is not enabled for aarch64 by default. With this version of libvirt, we have not seen any arch specific issues. The test env details are in - http://pastebin.com/raw/7d6RNRZW.","commit_id":"7311e74d141509c17015405112cb4017067e99ec"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b7e3a2427e86f96e57d0c1ab6d13ff1e64b1d198","unresolved":false,"context_lines":[{"line_number":5109,"context_line":"                return False"},{"line_number":5110,"context_line":""},{"line_number":5111,"context_line":"        support_matrix \u003d {(arch.I686, arch.X86_64,"},{"line_number":5112,"context_line":"                           arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,"},{"line_number":5113,"context_line":"                          (arch.PPC64,"},{"line_number":5114,"context_line":"                           arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}"},{"line_number":5115,"context_line":"        caps \u003d self._host.get_capabilities()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_b547e275","line":5112,"in_reply_to":"5a8bc5a2_849c7a10","updated":"2016-09-26 08:22:00.000000000","message":"That capabilities XML does *not* show any NUMA support in the host hardware you tested on - you\u0027ve only got one NUMA cell listed there. Also it does not show any huge page support - no huge page sizes are listed.\n\nSo while you might have launched a guest with numa topology, it does not appear that you could have tested host numa placement with that hardware.","commit_id":"7311e74d141509c17015405112cb4017067e99ec"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0cd91f4df04650df38b2076a3ff31b63f86fe4cb","unresolved":false,"context_lines":[{"line_number":5109,"context_line":"                return False"},{"line_number":5110,"context_line":""},{"line_number":5111,"context_line":"        support_matrix \u003d {(arch.I686, arch.X86_64,"},{"line_number":5112,"context_line":"                           arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,"},{"line_number":5113,"context_line":"                          (arch.PPC64,"},{"line_number":5114,"context_line":"                           arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}"},{"line_number":5115,"context_line":"        caps \u003d self._host.get_capabilities()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_24dba1ed","line":5112,"in_reply_to":"5a8bc5a2_b547e275","updated":"2016-09-26 08:59:59.000000000","message":"Yeah, that\u0027s the main concern I have. How can we make sure that the above is supported ? If we merge the above, that means then that aarch64 would be supported by Nova too, which could be a problem if we have some regression.","commit_id":"7311e74d141509c17015405112cb4017067e99ec"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a1acdfaff1f995c2db895e1ec13be54e0dd7659","unresolved":false,"context_lines":[{"line_number":5126,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5127,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5128,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,"},{"line_number":5129,"context_line":"                           arch.AARCH64]"},{"line_number":5130,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5131,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5132,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_a43891f0","line":5129,"updated":"2016-09-26 09:03:02.000000000","message":"I\u0027d appreciate some way to test that, also within the UTs, so we\u0027re sure that we\u0027re not regressing that.","commit_id":"190990e7c864deb7034d857630f34f6b26ceba4a"},{"author":{"_account_id":18817,"name":"dann frazier","email":"dann.frazier@canonical.com","username":"dannf"},"change_message_id":"acf13b840569a8fd8e1bdf9e68cfb2b9ad62b142","unresolved":false,"context_lines":[{"line_number":5126,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5127,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5128,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,"},{"line_number":5129,"context_line":"                           arch.AARCH64]"},{"line_number":5130,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5131,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5132,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_0ffd553a","line":5129,"in_reply_to":"5a8bc5a2_a43891f0","updated":"2016-09-29 19:36:14.000000000","message":"You should probably add AARCH64 to the list of archs at nova/tests/unit/virt/libvirt/test_driver.py:test_does_want_hugepages()","commit_id":"190990e7c864deb7034d857630f34f6b26ceba4a"}]}