)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":21782,"name":"Takahiro Suzuki","email":"suzuki.thj@ncos.nec.co.jp","username":"T.Suzuki"},"change_message_id":"431cd814ed8aff0d26e55b3b3cce42e90b1c3fb1","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                help\u003d\"\"\""},{"line_number":572,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"Volumes can be connected in LibVirt as multi path devices"},{"line_number":575,"context_line":"to allow more robust and faster volumes"},{"line_number":576,"context_line":"\"\"\")"},{"line_number":577,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_d4a58004","line":574,"range":{"start_line":574,"start_character":39,"end_line":574,"end_character":49},"updated":"2016-09-20 23:57:56.000000000","message":"I think better to unity the words, \"multipath\" is used.","commit_id":"731b466a9a2a5dad66b89d34a015aa1d7eed2ce1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                help\u003d\"\"\""},{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in LibVirt as multipath devices"},{"line_number":579,"context_line":"to allow more robust and faster volumes"},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_f5aaaed3","line":578,"range":{"start_line":578,"start_character":27,"end_line":578,"end_character":28},"updated":"2016-09-22 19:42:39.000000000","message":"the","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                help\u003d\"\"\""},{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in LibVirt as multipath devices"},{"line_number":579,"context_line":"to allow more robust and faster volumes"},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_baa67851","line":578,"range":{"start_line":578,"start_character":27,"end_line":578,"end_character":28},"in_reply_to":"5a8bc5a2_f5aaaed3","updated":"2016-09-27 22:22:32.000000000","message":"Done","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in LibVirt as multipath devices"},{"line_number":579,"context_line":"to allow more robust and faster volumes"},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_b5ee6620","line":579,"range":{"start_line":579,"start_character":0,"end_line":579,"end_character":39},"updated":"2016-09-22 19:42:39.000000000","message":"This will provide high availability and fault tolerance.","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in LibVirt as multipath devices"},{"line_number":579,"context_line":"to allow more robust and faster volumes"},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_da618413","line":579,"range":{"start_line":579,"start_character":0,"end_line":579,"end_character":39},"in_reply_to":"5a8bc5a2_b5ee6620","updated":"2016-09-27 22:22:32.000000000","message":"Done","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":582,"context_line":""},{"line_number":583,"context_line":"libvirt_volume_aoe_opts \u003d ["},{"line_number":584,"context_line":"    cfg.IntOpt(\u0027num_aoe_discover_tries\u0027,"},{"line_number":585,"context_line":"               default\u003d3,"},{"line_number":586,"context_line":"               help\u003d\"\"\""},{"line_number":587,"context_line":"Number of times to rediscover AoE target to find volume"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_f5462e22","line":585,"updated":"2016-09-22 19:42:39.000000000","message":"Can we introduce min here?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":589,"context_line":"nova provides support for block storage attaching to hosts"},{"line_number":590,"context_line":"via AOE (ATA over Ethernet). This option allows"},{"line_number":591,"context_line":"the user to specify the maximum number of retry attempts that"},{"line_number":592,"context_line":"can be made to discover the AoE device."},{"line_number":593,"context_line":"\"\"\")"},{"line_number":594,"context_line":"]"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_d541320d","line":592,"updated":"2016-09-22 19:42:39.000000000","message":"What happens if set to 0?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":589,"context_line":"nova provides support for block storage attaching to hosts"},{"line_number":590,"context_line":"via AOE (ATA over Ethernet). This option allows"},{"line_number":591,"context_line":"the user to specify the maximum number of retry attempts that"},{"line_number":592,"context_line":"can be made to discover the AoE device."},{"line_number":593,"context_line":"\"\"\")"},{"line_number":594,"context_line":"]"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_3ab8a8e5","line":592,"in_reply_to":"5a8bc5a2_d541320d","updated":"2016-09-27 22:22:32.000000000","message":"https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/aoe.py#L104.\n\nIf the value is \u003c\u003d0, no attempts will be made to discover the volume. IMO, I don\u0027t think we need to mention this as it is obvious that if number of tries is 0, volume will not be discovered.","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":598,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":599,"context_line":"               help\u003d\"\"\""},{"line_number":600,"context_line":"Directory where the glusterfs volume is mounted on the"},{"line_number":601,"context_line":"compute node"},{"line_number":602,"context_line":"\"\"\")"},{"line_number":603,"context_line":"]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_955ecae7","line":601,"range":{"start_line":600,"start_character":0,"end_line":601,"end_character":12},"updated":"2016-09-22 19:42:39.000000000","message":"I think you need to fix line wrapping here and other places in this file.","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":598,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":599,"context_line":"               help\u003d\"\"\""},{"line_number":600,"context_line":"Directory where the glusterfs volume is mounted on the"},{"line_number":601,"context_line":"compute node"},{"line_number":602,"context_line":"\"\"\")"},{"line_number":603,"context_line":"]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_1a6ccc07","line":601,"range":{"start_line":600,"start_character":0,"end_line":601,"end_character":12},"in_reply_to":"5a8bc5a2_955ecae7","updated":"2016-09-27 22:22:32.000000000","message":"Done","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"libvirt_volume_iscsi_opts \u003d ["},{"line_number":606,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":607,"context_line":"               default\u003d5,"},{"line_number":608,"context_line":"               help\u003d\"\"\""},{"line_number":609,"context_line":"Number of times to rescan iSCSI target to find volume"},{"line_number":610,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_d55852fd","line":607,"updated":"2016-09-22 19:42:39.000000000","message":"Add min here?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"libvirt_volume_iscsi_opts \u003d ["},{"line_number":606,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":607,"context_line":"               default\u003d5,"},{"line_number":608,"context_line":"               help\u003d\"\"\""},{"line_number":609,"context_line":"Number of times to rescan iSCSI target to find volume"},{"line_number":610,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_5a7654d9","line":607,"in_reply_to":"5a8bc5a2_d55852fd","updated":"2016-09-27 22:22:32.000000000","message":"same as above","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":607,"context_line":"               default\u003d5,"},{"line_number":608,"context_line":"               help\u003d\"\"\""},{"line_number":609,"context_line":"Number of times to rescan iSCSI target to find volume"},{"line_number":610,"context_line":"\"\"\"),"},{"line_number":611,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":612,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_35709672","line":609,"updated":"2016-09-22 19:42:39.000000000","message":"What does 0 means?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":612,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":613,"context_line":"               help\u003d\"\"\""},{"line_number":614,"context_line":"The iSCSI transport iface to use to connect to target in"},{"line_number":615,"context_line":"case offload support is desired. Default format is of"},{"line_number":616,"context_line":"the form \u003ctransport_name\u003e.\u003chwaddress\u003e where"},{"line_number":617,"context_line":"\u003ctransport_name\u003e is one of (be2iscsi, bnx2i, cxgb3i,"},{"line_number":618,"context_line":"cxgb4i, qla4xxx, ocs) and \u003chwaddress\u003e is the MAC address"},{"line_number":619,"context_line":"of the interface and can be generated via the"},{"line_number":620,"context_line":"iscsiadm -m iface command. Do not confuse the"},{"line_number":621,"context_line":"iscsi_iface parameter to be provided here with the"},{"line_number":622,"context_line":"actual transport name."},{"line_number":623,"context_line":"\"\"\")"},{"line_number":624,"context_line":"# iser is also supported, but use LibvirtISERVolumeDriver"},{"line_number":625,"context_line":"# instead"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_f5146ef6","line":622,"range":{"start_line":614,"start_character":0,"end_line":622,"end_character":22},"updated":"2016-09-22 19:42:39.000000000","message":"Line wrapping is too short.","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":612,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":613,"context_line":"               help\u003d\"\"\""},{"line_number":614,"context_line":"The iSCSI transport iface to use to connect to target in"},{"line_number":615,"context_line":"case offload support is desired. Default format is of"},{"line_number":616,"context_line":"the form \u003ctransport_name\u003e.\u003chwaddress\u003e where"},{"line_number":617,"context_line":"\u003ctransport_name\u003e is one of (be2iscsi, bnx2i, cxgb3i,"},{"line_number":618,"context_line":"cxgb4i, qla4xxx, ocs) and \u003chwaddress\u003e is the MAC address"},{"line_number":619,"context_line":"of the interface and can be generated via the"},{"line_number":620,"context_line":"iscsiadm -m iface command. Do not confuse the"},{"line_number":621,"context_line":"iscsi_iface parameter to be provided here with the"},{"line_number":622,"context_line":"actual transport name."},{"line_number":623,"context_line":"\"\"\")"},{"line_number":624,"context_line":"# iser is also supported, but use LibvirtISERVolumeDriver"},{"line_number":625,"context_line":"# instead"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_9a80dc8d","line":622,"range":{"start_line":614,"start_character":0,"end_line":622,"end_character":22},"in_reply_to":"5a8bc5a2_f5146ef6","updated":"2016-09-27 22:22:32.000000000","message":"Done","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":627,"context_line":""},{"line_number":628,"context_line":"libvirt_volume_iser_opts \u003d ["},{"line_number":629,"context_line":"    cfg.IntOpt(\u0027num_iser_scan_tries\u0027,"},{"line_number":630,"context_line":"               default\u003d5,"},{"line_number":631,"context_line":"               help\u003d\"\"\""},{"line_number":632,"context_line":"Number of times to rescan iSER target to find volume"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_1521da4d","line":630,"updated":"2016-09-22 19:42:39.000000000","message":"min here?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":634,"context_line":"iSER is a server network protocol that extends iSCSI protocol"},{"line_number":635,"context_line":"to use Remote Direct Memory Access (RDMA). This option allows"},{"line_number":636,"context_line":"the user to specify the maximum number of retry attempts that"},{"line_number":637,"context_line":"can be made to find iSER volume."},{"line_number":638,"context_line":"\"\"\"),"},{"line_number":639,"context_line":"    cfg.BoolOpt(\u0027iser_use_multipath\u0027,"},{"line_number":640,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_95ba4ae0","line":637,"updated":"2016-09-22 19:42:39.000000000","message":"0 means?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"484b931735fd27c7adf0af010bfee2e73d757354","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    cfg.BoolOpt(\u0027iser_use_multipath\u0027,"},{"line_number":640,"context_line":"                default\u003dFalse,"},{"line_number":641,"context_line":"                help\u003d\"\"\""},{"line_number":642,"context_line":"Use multipath connection of the iSER volume"},{"line_number":643,"context_line":"\"\"\")"},{"line_number":644,"context_line":"]"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_95a16aac","line":642,"updated":"2016-09-22 19:42:39.000000000","message":"Add little more detail as how will this help?","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"58da495ea2bb6cd23d81281698388a3b3c8e63f7","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    cfg.BoolOpt(\u0027iser_use_multipath\u0027,"},{"line_number":640,"context_line":"                default\u003dFalse,"},{"line_number":641,"context_line":"                help\u003d\"\"\""},{"line_number":642,"context_line":"Use multipath connection of the iSER volume"},{"line_number":643,"context_line":"\"\"\")"},{"line_number":644,"context_line":"]"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_5540e735","line":642,"in_reply_to":"5a8bc5a2_95a16aac","updated":"2016-09-27 22:22:32.000000000","message":"Done","commit_id":"adc1f55517a13680e82bdc3aafb3c3464834e0fc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9434122ebbb63c9fb4ab1baec5f70a9a208fa82d","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    cfg.ListOpt(\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":562,"context_line":"                default\u003d[],"},{"line_number":563,"context_line":"                help\u003d\"\"\" "},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU. Currently supported"},{"line_number":565,"context_line":"protocols: [gluster]"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_cd362eb4","line":564,"range":{"start_line":564,"start_character":58,"end_line":564,"end_character":59},"updated":"2016-09-28 15:46:58.000000000","message":"Line break here","commit_id":"57f7e103792d58c5da2e91295017cf5179154581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9434122ebbb63c9fb4ab1baec5f70a9a208fa82d","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                default\u003dFalse,"},{"line_number":573,"context_line":"                deprecated_name\u003d\u0027iscsi_use_multipath\u0027,"},{"line_number":574,"context_line":"                help\u003d\"\"\""},{"line_number":575,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"Volumes can be connected in the LibVirt as multipath devices.  This will"},{"line_number":578,"context_line":"provide high availability and fault tolerance."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_0d5816fa","line":575,"updated":"2016-09-28 15:46:58.000000000","message":"fullstop on the end of each of these lines","commit_id":"57f7e103792d58c5da2e91295017cf5179154581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9434122ebbb63c9fb4ab1baec5f70a9a208fa82d","unresolved":false,"context_lines":[{"line_number":608,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":609,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":610,"context_line":"               help\u003d\"\"\""},{"line_number":611,"context_line":"The iSCSI transport iface to use to connect to target in case offload support"},{"line_number":612,"context_line":"is desired. Default format is of the form \u003ctransport_name\u003e.\u003chwaddress\u003e where"},{"line_number":613,"context_line":"\u003ctransport_name\u003e is one of (be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx, ocs) and"},{"line_number":614,"context_line":"\u003chwaddress\u003e is the MAC address of the interface and can be generated via the"},{"line_number":615,"context_line":"iscsiadm -m iface command. Do not confuse the iscsi_iface parameter to be"},{"line_number":616,"context_line":"provided here with the actual transport name."},{"line_number":617,"context_line":"\"\"\")"},{"line_number":618,"context_line":"# iser is also supported, but use LibvirtISERVolumeDriver"},{"line_number":619,"context_line":"# instead"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_4df93ec8","line":616,"range":{"start_line":611,"start_character":0,"end_line":616,"end_character":45},"updated":"2016-09-28 15:46:58.000000000","message":"Can you pull a summary line out of this?","commit_id":"57f7e103792d58c5da2e91295017cf5179154581"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":568,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"},{"line_number":569,"context_line":"pass a disk configuration to QEMU. This allows QEMU to access the volume using"},{"line_number":570,"context_line":"libgfapi rather than mounting GlusterFS via fuse."},{"line_number":571,"context_line":"\"\"\"),"},{"line_number":572,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"},{"line_number":573,"context_line":"                default\u003dFalse,"},{"line_number":574,"context_line":"                deprecated_name\u003d\u0027iscsi_use_multipath\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_fc133d0b","line":571,"updated":"2016-11-16 15:50:20.000000000","message":"That\u0027s indeed all the information which was needed to get this feature merged: https://blueprints.launchpad.net/nova/+spec/glusterfs-native-support","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                help\u003d\"\"\""},{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in the LibVirt as multipath devices.  This will"},{"line_number":579,"context_line":"provide high availability and fault tolerance."},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_9c832956","line":578,"range":{"start_line":578,"start_character":62,"end_line":578,"end_character":63},"updated":"2016-11-16 15:50:20.000000000","message":"nit: 1 space too much","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                help\u003d\"\"\""},{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in the LibVirt as multipath devices.  This will"},{"line_number":579,"context_line":"provide high availability and fault tolerance."},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_85273a63","line":578,"range":{"start_line":578,"start_character":62,"end_line":578,"end_character":63},"in_reply_to":"7a77a97e_9c832956","updated":"2016-11-17 17:15:30.000000000","message":"Done","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in the LibVirt as multipath devices.  This will"},{"line_number":579,"context_line":"provide high availability and fault tolerance."},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_17437243","line":579,"updated":"2016-11-16 15:50:20.000000000","message":"Again, very little detail on the bp (+ its wiki page) which introduced this: https://blueprints.launchpad.net/nova/+spec/libvirt-volume-multipath-iscsi\nI know too little about the whole volume topic, so I\u0027m not sure if it\u0027s worth mentioning that there will be a discovery for multipath devices: https://github.com/openstack/os-brick/blob/c2bad1f4009e518b927b437469961b650e550e13/os_brick/initiator/connectors/base.py#L90","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":576,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Volumes can be connected in the LibVirt as multipath devices.  This will"},{"line_number":579,"context_line":"provide high availability and fault tolerance."},{"line_number":580,"context_line":"\"\"\")"},{"line_number":581,"context_line":"]"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_e5fe2e37","line":579,"in_reply_to":"7a77a97e_17437243","updated":"2016-11-17 17:15:30.000000000","message":"I think mentioning about discovery would be too much information. Not sure though","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":586,"context_line":"               help\u003d\"\"\""},{"line_number":587,"context_line":"Number of times to rediscover AoE target to find volume."},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"nova provides support for block storage attaching to hosts via AOE (ATA over"},{"line_number":590,"context_line":"Ethernet). This option allows the user to specify the maximum number of retry"},{"line_number":591,"context_line":"attempts that can be made to discover the AoE device."},{"line_number":592,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_7ca72d4f","line":589,"range":{"start_line":589,"start_character":0,"end_line":589,"end_character":1},"updated":"2016-11-16 15:50:20.000000000","message":"nit: s/nova/Nova","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"44d23a13192d29372f02ee4bd6fdbb17c8773283","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":597,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":598,"context_line":"               help\u003d\"\"\""},{"line_number":599,"context_line":"Directory where the glusterfs volume is mounted on the compute node."},{"line_number":600,"context_line":"\"\"\")"},{"line_number":601,"context_line":"]"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_e2876e10","line":599,"range":{"start_line":599,"start_character":0,"end_line":599,"end_character":9},"updated":"2016-10-04 21:19:09.000000000","message":"IS this suppose to be absolute path of directory. If so then you should mention that here.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":597,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":598,"context_line":"               help\u003d\"\"\""},{"line_number":599,"context_line":"Directory where the glusterfs volume is mounted on the compute node."},{"line_number":600,"context_line":"\"\"\")"},{"line_number":601,"context_line":"]"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_57afaa80","line":599,"range":{"start_line":599,"start_character":0,"end_line":599,"end_character":9},"in_reply_to":"1a95cdbc_455ff50d","updated":"2016-11-16 15:50:20.000000000","message":"Evidence for expecting the absolute path is at: https://github.com/openstack/nova/blob/36322fdf48dc50a4518c0c9fd6aa787d3aa01fed/nova/virt/libvirt/volume/fs.py#L92-L92\nAnother evidence is following the default value of this config option, which uses the relative \"state_path\" which uses the absolute \"pybasedir\".\nIOW, stating here explicitly  that it should be the absolute path to the mount point would be helpful.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"01797171557e0b50346b0eff84e4273c3213e6e9","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":597,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":598,"context_line":"               help\u003d\"\"\""},{"line_number":599,"context_line":"Directory where the glusterfs volume is mounted on the compute node."},{"line_number":600,"context_line":"\"\"\")"},{"line_number":601,"context_line":"]"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_455ff50d","line":599,"range":{"start_line":599,"start_character":0,"end_line":599,"end_character":9},"in_reply_to":"1a95cdbc_e2876e10","updated":"2016-10-06 13:53:23.000000000","message":"I would not expect directory path here to be any different than absolute, but could not find any solid evidence for this.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":597,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":598,"context_line":"               help\u003d\"\"\""},{"line_number":599,"context_line":"Directory where the glusterfs volume is mounted on the compute node."},{"line_number":600,"context_line":"\"\"\")"},{"line_number":601,"context_line":"]"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_5fc94358","line":599,"range":{"start_line":599,"start_character":0,"end_line":599,"end_character":9},"in_reply_to":"7a77a97e_57afaa80","updated":"2016-11-17 17:15:30.000000000","message":"Done","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"44d23a13192d29372f02ee4bd6fdbb17c8773283","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"libvirt_volume_iscsi_opts \u003d ["},{"line_number":604,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":605,"context_line":"               default\u003d5,"},{"line_number":606,"context_line":"               help\u003d\"\"\""},{"line_number":607,"context_line":"Number of times to rescan iSCSI target to find volume."},{"line_number":608,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_62a35e9f","line":605,"updated":"2016-10-04 21:19:09.000000000","message":"Add min here?","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f9860ec0442c65e8670bc33db2f4d91074de6f57","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"libvirt_volume_iscsi_opts \u003d ["},{"line_number":604,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":605,"context_line":"               default\u003d5,"},{"line_number":606,"context_line":"               help\u003d\"\"\""},{"line_number":607,"context_line":"Number of times to rescan iSCSI target to find volume."},{"line_number":608,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_4249028b","line":605,"in_reply_to":"1a95cdbc_62a35e9f","updated":"2016-10-04 21:24:36.000000000","message":"Disregard this, I forgot to look at your comments from patchset 3","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":605,"context_line":"               default\u003d5,"},{"line_number":606,"context_line":"               help\u003d\"\"\""},{"line_number":607,"context_line":"Number of times to rescan iSCSI target to find volume."},{"line_number":608,"context_line":"\"\"\"),"},{"line_number":609,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":610,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":611,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_f75ef674","line":608,"updated":"2016-11-16 15:50:20.000000000","message":"This is just a reformat of the help text as a preparation for future changes, which is OK for me. Just in case you will work again on this specific config option, be aware that this is also used for other protocols, for example fibrechannel: https://github.com/openstack/nova/blob/36322fdf48dc50a4518c0c9fd6aa787d3aa01fed/nova/virt/libvirt/volume/fibrechannel.py#L37-L37\n\nThat means this should be renamed (in another change) in something like \"num_volume_scan_tries\".","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":605,"context_line":"               default\u003d5,"},{"line_number":606,"context_line":"               help\u003d\"\"\""},{"line_number":607,"context_line":"Number of times to rescan iSCSI target to find volume."},{"line_number":608,"context_line":"\"\"\"),"},{"line_number":609,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":610,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":611,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_9f491bba","line":608,"in_reply_to":"7a77a97e_f75ef674","updated":"2016-11-17 17:15:30.000000000","message":"True. This should be renamed. For now, I\u0027ll leave a TODO note.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"44d23a13192d29372f02ee4bd6fdbb17c8773283","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"libvirt_volume_iser_opts \u003d ["},{"line_number":626,"context_line":"    cfg.IntOpt(\u0027num_iser_scan_tries\u0027,"},{"line_number":627,"context_line":"               default\u003d5,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Number of times to rescan iSER target to find volume."},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_4203c273","line":627,"updated":"2016-10-04 21:19:09.000000000","message":"min here?","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f9860ec0442c65e8670bc33db2f4d91074de6f57","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"libvirt_volume_iser_opts \u003d ["},{"line_number":626,"context_line":"    cfg.IntOpt(\u0027num_iser_scan_tries\u0027,"},{"line_number":627,"context_line":"               default\u003d5,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Number of times to rescan iSER target to find volume."},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_825b0a54","line":627,"in_reply_to":"1a95cdbc_4203c273","updated":"2016-10-04 21:24:36.000000000","message":"Disregard this, I forgot to look at your comments from patchset 3","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    cfg.IntOpt(\u0027num_iser_scan_tries\u0027,"},{"line_number":627,"context_line":"               default\u003d5,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Number of times to rescan iSER target to find volume."},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"iSER is a server network protocol that extends iSCSI protocol to use Remote"},{"line_number":632,"context_line":"Direct Memory Access (RDMA). This option allows the user to specify the maximum"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_69ea0a11","line":629,"range":{"start_line":629,"start_character":19,"end_line":629,"end_character":25},"updated":"2016-11-16 15:50:20.000000000","message":"I\u0027m getting picky here, but it is important: The term \"rescan\" implies that a scan has already happened at least once. Which means, if I set this config option to a value of zero, one scan will happen nevertheless. But that is not the case, the value of this config option is the actual number of scans: https://github.com/openstack/os-brick/blob/9be0b3d2c451012506d23b9cfc5ee40d0dcdec27/os_brick/initiator/connectors/iscsi.py#L412\n\nIOW, please use the term \"scan\" here.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    cfg.IntOpt(\u0027num_iser_scan_tries\u0027,"},{"line_number":627,"context_line":"               default\u003d5,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Number of times to rescan iSER target to find volume."},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"iSER is a server network protocol that extends iSCSI protocol to use Remote"},{"line_number":632,"context_line":"Direct Memory Access (RDMA). This option allows the user to specify the maximum"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_1115ff3e","line":629,"range":{"start_line":629,"start_character":19,"end_line":629,"end_character":25},"in_reply_to":"7a77a97e_69ea0a11","updated":"2016-11-17 17:15:30.000000000","message":"Done","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"iSER is a server network protocol that extends iSCSI protocol to use Remote"},{"line_number":632,"context_line":"Direct Memory Access (RDMA). This option allows the user to specify the maximum"},{"line_number":633,"context_line":"number of retry attempts that can be made to find iSER volume."},{"line_number":634,"context_line":"\"\"\"),"},{"line_number":635,"context_line":"    cfg.BoolOpt(\u0027iser_use_multipath\u0027,"},{"line_number":636,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_a9cb42a4","line":633,"range":{"start_line":633,"start_character":10,"end_line":633,"end_character":15},"updated":"2016-11-16 15:50:20.000000000","message":"s/retry/scan\n\nSame arguments as in line 629.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5aae3c877db1f5ea09c65c1801bea57983734602","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"iSER is a server network protocol that extends iSCSI protocol to use Remote"},{"line_number":632,"context_line":"Direct Memory Access (RDMA). This option allows the user to specify the maximum"},{"line_number":633,"context_line":"number of retry attempts that can be made to find iSER volume."},{"line_number":634,"context_line":"\"\"\"),"},{"line_number":635,"context_line":"    cfg.BoolOpt(\u0027iser_use_multipath\u0027,"},{"line_number":636,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b12c4b9a","line":633,"range":{"start_line":633,"start_character":10,"end_line":633,"end_character":15},"in_reply_to":"7a77a97e_a9cb42a4","updated":"2016-11-17 17:15:30.000000000","message":"Done","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1397b7962ac8ae2aeeb6fb65301b2173df6fd19a","unresolved":false,"context_lines":[{"line_number":639,"context_line":""},{"line_number":640,"context_line":"iSER volumes can be connected as multipath devices. This will provide high"},{"line_number":641,"context_line":"availability and fault tolerance."},{"line_number":642,"context_line":"\"\"\")"},{"line_number":643,"context_line":"]"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"libvirt_volume_net_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_c9e15e00","line":642,"updated":"2016-11-16 15:50:20.000000000","message":"Same text as for \"volume_use_multipath\", which is OK for me, as it is the same reason but for a different protocol.","commit_id":"8a200962ee9b470df8b7be88bb53ad0d4b6ff796"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0b1e63ed3a318c36ea4aea9c5953f9c609092e42","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                help\u003d\"\"\""},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Currently supported protocols: [gluster]"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"},{"line_number":569,"context_line":"pass a disk configuration to QEMU. This allows QEMU to access the volume using"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_98503234","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":40},"updated":"2016-11-18 10:23:49.000000000","message":"Shouldn\u0027t this be formatted as a \u0027Possible values\u0027 section?","commit_id":"9af1cf65426f7fbd31257b4335361d6691c73931"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"1c0009e66e264bd7270062bc6122352013f81b64","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                help\u003d\"\"\""},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Currently supported protocols: [gluster]"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"},{"line_number":569,"context_line":"pass a disk configuration to QEMU. This allows QEMU to access the volume using"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ba80308d","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":40},"in_reply_to":"7a77a97e_5f72aeae","updated":"2016-11-21 17:38:08.000000000","message":"We need to mention which protocols are supported. So adding it under possible values section.","commit_id":"9af1cf65426f7fbd31257b4335361d6691c73931"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2f5ca603ee477bdc335661a55139c3ec05ed619","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                help\u003d\"\"\""},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Currently supported protocols: [gluster]"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"},{"line_number":569,"context_line":"pass a disk configuration to QEMU. This allows QEMU to access the volume using"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_a63620b2","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":40},"in_reply_to":"7a77a97e_5f72aeae","updated":"2016-11-22 16:42:19.000000000","message":"Yes, something like \u0027enable_gluster\u0027 seems a lot more logical, unless we intend to hook in more storage drivers in the future","commit_id":"9af1cf65426f7fbd31257b4335361d6691c73931"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6850b3c42228fabed425621ef35df7f88edb9afe","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                help\u003d\"\"\""},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"Currently supported protocols: [gluster]"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"If gluster is present in qemu_allowed_storage_drivers, glusterfs\u0027s backend will"},{"line_number":569,"context_line":"pass a disk configuration to QEMU. This allows QEMU to access the volume using"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_5f72aeae","line":566,"range":{"start_line":566,"start_character":0,"end_line":566,"end_character":40},"in_reply_to":"7a77a97e_98503234","updated":"2016-11-21 17:04:25.000000000","message":"If there is only one supported protocol, do we really need this option? From the description it seems that this option is for enabling libgfapi rather than for configuring the list of allowed storage drivers.\n\nSo, the way I see it is maybe we should either rename it or drop it.","commit_id":"9af1cf65426f7fbd31257b4335361d6691c73931"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b2a38f9c0e88f7e7bba579e7894aa073456ba53c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"]"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":561,"context_line":"    cfg.ListOpt(\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":562,"context_line":"                default\u003d[],"},{"line_number":563,"context_line":"                help\u003d\"\"\""},{"line_number":564,"context_line":"Protocols listed here will be accessed directly from QEMU."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_b5efcf1c","line":561,"range":{"start_line":561,"start_character":4,"end_line":561,"end_character":47},"updated":"2016-12-15 15:04:59.000000000","message":"nit: A TODO to address the comments from PS6 would be appreciated","commit_id":"ef1908900f3bbbbf73caef80708cac7d05586404"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b2a38f9c0e88f7e7bba579e7894aa073456ba53c","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                default\u003dFalse,"},{"line_number":576,"context_line":"                deprecated_name\u003d\u0027iscsi_use_multipath\u0027,"},{"line_number":577,"context_line":"                help\u003d\"\"\""},{"line_number":578,"context_line":"Use multipath connection of the iSCSI or FC volume"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"Volumes can be connected in the LibVirt as multipath devices. This will"},{"line_number":581,"context_line":"provide high availability and fault tolerance."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_b5d6ef4c","line":578,"updated":"2016-12-15 15:04:59.000000000","message":"nit: missing full stop","commit_id":"ef1908900f3bbbbf73caef80708cac7d05586404"}]}