)]}'
{"nova/auth/ldapdriver.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5c060291505dc94044033b56cdf414855ea59931","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def __user_exists(self, uid):"},{"line_number":499,"context_line":"        \"\"\"Check if user exists\"\"\""},{"line_number":500,"context_line":"        user \u003d None"},{"line_number":501,"context_line":"        try:"},{"line_number":502,"context_line":"            user \u003d self.get_user(uid) is not None"},{"line_number":503,"context_line":"        except exception.LDAPUserNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2FME%3D","line":500,"updated":"2012-02-03 09:21:29.000000000","message":"The previous definition of __user_exists returned a boolean.  While None is easily coerced to False in any conditional statement, there is no need to modify the original\u0027s contract and  False should be returned if the user is not found.\n\nSince the value to be returned is a boolean, a better name for the variable might be \u0027user_exists\u0027.  Simpler yet, return each result without assignment.","commit_id":"c25345504515043ad3be2d5c1e60a61a9f346f7d"}],"nova/tests/test_auth.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"bdff1457698739e0040cfbe750fa67294eb11377","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    def test_get_nonexistent_user_raises_exception(self):"},{"line_number":362,"context_line":"            self.assertRaises(exception.LDAPUserNotFound,"},{"line_number":363,"context_line":"                              self.manager.get_user,"},{"line_number":364,"context_line":"                              \u0027joeblow\u0027)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"class AuthManagerDbTestCase(_AuthManagerBaseTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2FQw%3D","line":364,"updated":"2012-02-03 06:32:49.000000000","message":"seems like it would be more useful to put this in the base class test case and assertRaises(exception.NotFound,\n\nThat way it tests the db driver as well.","commit_id":"c25345504515043ad3be2d5c1e60a61a9f346f7d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"520a65aa5cd77279bbd5046f89e21f5da6f8144e","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            self.assertTrue(user.is_admin())"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_get_nonexistent_user_raises_notfound_exception(self):"},{"line_number":349,"context_line":"            self.assertRaises(exception.NotFound,"},{"line_number":350,"context_line":"                              self.manager.get_user,"},{"line_number":351,"context_line":"                              \u0027joeblow\u0027)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BuU%3D","line":349,"updated":"2012-02-04 02:30:52.000000000","message":"Please use consistent indentation (4 spaces per level).","commit_id":"64ab5dca477180075340241a8bf17ef3cb8dbe77"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"0859dca893b711f5e8b9ed909bd7230e5517fd4a","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            fakeldap.server_fail \u003d False"},{"line_number":364,"context_line":"        self.manager.get_users()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    # NOTE(john-griffith): This checks the specific NotFound subtype"},{"line_number":367,"context_line":"    def test_get_nonexistent_LDAPuser_raises_exception(self):"},{"line_number":368,"context_line":"            self.assertRaises(exception.LDAPUserNotFound,"},{"line_number":369,"context_line":"                              self.manager.get_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2Bts%3D","line":366,"updated":"2012-02-04 02:59:31.000000000","message":"I think this extra test is overkill, NotFound from the above test is fine.","commit_id":"64ab5dca477180075340241a8bf17ef3cb8dbe77"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"520a65aa5cd77279bbd5046f89e21f5da6f8144e","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    # NOTE(john-griffith): This checks the specific NotFound subtype"},{"line_number":367,"context_line":"    def test_get_nonexistent_LDAPuser_raises_exception(self):"},{"line_number":368,"context_line":"            self.assertRaises(exception.LDAPUserNotFound,"},{"line_number":369,"context_line":"                              self.manager.get_user,"},{"line_number":370,"context_line":"                              \u0027joeblow\u0027)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BuM%3D","line":368,"updated":"2012-02-04 02:30:52.000000000","message":"Please use consistent indentation (4 spaces per level).","commit_id":"64ab5dca477180075340241a8bf17ef3cb8dbe77"}]}