)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6b5cdc5f91bc0b14b6f0b092dc014ac6dac6095b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-01 11:49:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Remove \u0027scheduler_json_file_location\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code that parses this file does nothing with the contents. Time to"},{"line_number":10,"context_line":"remove both the code and option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba5da102_dc601dd2","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":42},"updated":"2016-11-01 13:15:05.000000000","message":"Nit: it is: scheduler_json_config_location","commit_id":"6856c1757959d4b91bc608e6e6776995789194a1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"91401c60c09b61c1def80fe04ba5d858de3de5aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code that parses this file does nothing with the contents. Time to"},{"line_number":10,"context_line":"remove both the code and option."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I228349110f9a9551776b18fbf8729a59ac7f810d"},{"line_number":13,"context_line":"Implements: bp centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a77a97e_89821493","line":11,"updated":"2016-11-16 12:10:57.000000000","message":"nit: If you push a new ps, having the series of events/commits in the commit message would be great:\n\n* https://github.com/openstack/nova/commit/e6b8c4d introduced this behavior (config option + reloading of file contents)\n* https://github.com/openstack/nova/commit/aeae7040c7b4533fd4d5521d4c5172cb2fb598e7#diff-4c96ba5489ecf1cf69ec56a611010573R73 Moved the behavior into a legacy compat shim.\n* https://github.com/openstack/nova/commit/ffcbc50#diff-4c96ba5489ecf1cf69ec56a611010573L54 removed the compat legacy shim (and therefore made the code for that behavior obsolete)","commit_id":"41ad9ea6677dcdabcb62555d268366bbd466672f"}],"nova/conf/scheduler.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a4a02dcda22d0e7adc26ba7b7f393be5cfa9256e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"default_opts \u003d ["},{"line_number":19,"context_line":"    # TODO(sfinucan): Deprecate this option"},{"line_number":20,"context_line":"    cfg.StrOpt(\"scheduler_topic\","},{"line_number":21,"context_line":"        default\u003d\"scheduler\","},{"line_number":22,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_72d559e3","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":43},"updated":"2016-09-21 20:54:20.000000000","message":"Why not deprecate this as well?","commit_id":"35dbdc592804ae425a8154375997b17c9df84848"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6c352fe8850f7a8486db25ee4a9aef5e6413333","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"default_opts \u003d ["},{"line_number":19,"context_line":"    # TODO(sfinucan): Deprecate this option"},{"line_number":20,"context_line":"    cfg.StrOpt(\"scheduler_topic\","},{"line_number":21,"context_line":"        default\u003d\"scheduler\","},{"line_number":22,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_c681b34f","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":43},"in_reply_to":"7a8ec9b2_72d559e3","updated":"2016-09-22 08:25:04.000000000","message":"There\u0027s another review, authored by johnthetubaguy and taken over by macsz, which does this. I didn\u0027t want to step on toes.\n\nAlso, \"small, modular commits\" :)","commit_id":"35dbdc592804ae425a8154375997b17c9df84848"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a4a02dcda22d0e7adc26ba7b7f393be5cfa9256e","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* A valid AMQP topic name"},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    # TODO(sfinucan): Deprecate this option"},{"line_number":35,"context_line":"    cfg.StrOpt(\"scheduler_json_config_location\","},{"line_number":36,"context_line":"        default\u003d\"\","},{"line_number":37,"context_line":"        deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_12d25500","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":43},"updated":"2016-09-21 20:54:20.000000000","message":"Take off this TODO.","commit_id":"35dbdc592804ae425a8154375997b17c9df84848"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6c352fe8850f7a8486db25ee4a9aef5e6413333","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* A valid AMQP topic name"},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    # TODO(sfinucan): Deprecate this option"},{"line_number":35,"context_line":"    cfg.StrOpt(\"scheduler_json_config_location\","},{"line_number":36,"context_line":"        default\u003d\"\","},{"line_number":37,"context_line":"        deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_2681774b","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":43},"in_reply_to":"7a8ec9b2_12d25500","updated":"2016-09-22 08:25:04.000000000","message":"Good spot","commit_id":"35dbdc592804ae425a8154375997b17c9df84848"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"008d35c5532577b295892340cc87024162fae70d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":44,"context_line":"The file this configuration option references is no longer used anywhere.\"\"\","},{"line_number":45,"context_line":"        deprecated_since\u003d\"15.0.0\","},{"line_number":46,"context_line":"        help\u003d\"\"\""},{"line_number":47,"context_line":"The absolute path to the scheduler configuration JSON file, if any."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_96533d6c","line":45,"updated":"2016-10-18 11:53:09.000000000","message":"Deprecation is used for config options which still actually do something. If this config option is not used anywhere, then there is no point going through a deprecation cycle as there is no semantic behaviour to be preserved during the deprecation period - just delete it entirely now.","commit_id":"ddf17ca78e947b90bc8734599cd7a81a7bdaf47d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a6c7c7926b0c258d07ed4fa6f820f2251eff78a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":44,"context_line":"The file this configuration option references is no longer used anywhere.\"\"\","},{"line_number":45,"context_line":"        deprecated_since\u003d\"15.0.0\","},{"line_number":46,"context_line":"        help\u003d\"\"\""},{"line_number":47,"context_line":"The absolute path to the scheduler configuration JSON file, if any."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_85a3179e","line":45,"in_reply_to":"fa6399be_96533d6c","updated":"2016-11-23 12:33:45.000000000","message":"Honestly, we have still been giving people a release of warning. I am not sure about removing the configuration, mostly because of the plans to stop the service starting when there is \"invalid\" configuration.","commit_id":"ddf17ca78e947b90bc8734599cd7a81a7bdaf47d"}],"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d6bb070ab568b39ecc476d419c6e9434c6be0a79","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        selected_hosts \u003d []"},{"line_number":107,"context_line":"        num_instances \u003d spec_obj.num_instances"},{"line_number":108,"context_line":"        # NOTE(sbauza): Adding one field for any out-of-tree need"},{"line_number":109,"context_line":"        spec_obj.config_options \u003d config_options"},{"line_number":110,"context_line":"        for num in range(num_instances):"},{"line_number":111,"context_line":"            # Filter local hosts based on requirements ..."},{"line_number":112,"context_line":"            hosts \u003d self.host_manager.get_filtered_hosts(hosts,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_e5920457","side":"PARENT","line":109,"updated":"2016-10-11 13:54:00.000000000","message":"Nit: we should add a comment on the object that this isn\u0027t being used any more.","commit_id":"7d0381c91a6ba8a45ae6527f046f382166eb158d"}]}