)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78895a5a5fcba356b2ec9f0d9ddb88a4f7d676a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"objects to manually initialize os_vif when it will be used. os_vif"},{"line_number":17,"context_line":"objects can\u0027t be created until it is initialized, so some delayed"},{"line_number":18,"context_line":"object creation is also done in test_vif.py."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I89fe5c5b3d762f3a3238b587685df85d15ee56c4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_997930ff","line":19,"updated":"2016-09-21 19:47:15.000000000","message":"Closes-Bug: #1615676","commit_id":"eb772b282bf4675783169f0844ce6b29668c5cb0"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78895a5a5fcba356b2ec9f0d9ddb88a4f7d676a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Ensure os-vif objects are registered and plugins loaded"},{"line_number":37,"context_line":"os_vif.initialize()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _get_vif_name(vif):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_39a1fc94","side":"PARENT","line":37,"updated":"2016-09-21 19:47:15.000000000","message":"Don\u0027t we have to initialize this in https://github.com/openstack/nova/blob/master/nova/cmd/network.py then too?\n\nOr was os_vif_util just put in the wrong place to begin with?","commit_id":"10ee85c7256f5aa643dd874f17c9652f733a6396"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78895a5a5fcba356b2ec9f0d9ddb88a4f7d676a4","unresolved":false,"context_lines":[{"line_number":5435,"context_line":""},{"line_number":5436,"context_line":"    def test_get_guest_cpu_config_host_passthrough(self):"},{"line_number":5437,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5438,"context_line":"        os_vif.initialize()"},{"line_number":5439,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":5440,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":5441,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_794384af","line":5438,"updated":"2016-09-21 19:47:15.000000000","message":"Why not just do this in the test class setup so we don\u0027t have to remember this every time we need it?","commit_id":"eb772b282bf4675783169f0844ce6b29668c5cb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c933e891389a5a226f0c4a555019c089bc64b320","unresolved":false,"context_lines":[{"line_number":5435,"context_line":""},{"line_number":5436,"context_line":"    def test_get_guest_cpu_config_host_passthrough(self):"},{"line_number":5437,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5438,"context_line":"        os_vif.initialize()"},{"line_number":5439,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":5440,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":5441,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_9c603e37","line":5438,"updated":"2016-09-21 20:05:17.000000000","message":"Can we do this in the setUp rather than in every test case that needs it? I\u0027ve got a feeling we\u0027re going to forget why this is here at all.","commit_id":"bebd1ef8fc450a9804600d39e2dc89fdaf6c9fd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e545c4a00c73b1700171e2cf96d7a1334ec59dea","unresolved":false,"context_lines":[{"line_number":5435,"context_line":""},{"line_number":5436,"context_line":"    def test_get_guest_cpu_config_host_passthrough(self):"},{"line_number":5437,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5438,"context_line":"        os_vif.initialize()"},{"line_number":5439,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":5440,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":5441,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_b2528111","line":5438,"in_reply_to":"7a8ec9b2_4fe276a1","updated":"2016-09-21 20:40:20.000000000","message":"So I pulled this down and commented this line out, and 26 tests failed, not just this one, so this seems like a house of cards that is going to be really weird to untangle if you miss it in one new test. So I think we should really just throw this into setUp or a fixture or something and add a comment about why it\u0027s there.","commit_id":"bebd1ef8fc450a9804600d39e2dc89fdaf6c9fd9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"54572199337627a9e55e8d4e20550b0a3bbfd6f4","unresolved":false,"context_lines":[{"line_number":5435,"context_line":""},{"line_number":5436,"context_line":"    def test_get_guest_cpu_config_host_passthrough(self):"},{"line_number":5437,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5438,"context_line":"        os_vif.initialize()"},{"line_number":5439,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":5440,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":5441,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_efb182e1","line":5438,"in_reply_to":"7a8ec9b2_9c603e37","updated":"2016-09-21 20:26:51.000000000","message":"because the class is pretty big, and doing this for every method would be more overhead than we really should bother with","commit_id":"bebd1ef8fc450a9804600d39e2dc89fdaf6c9fd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3efb50d6b1fb2dae573f074b4785d5c57c3dd1cf","unresolved":false,"context_lines":[{"line_number":5435,"context_line":""},{"line_number":5436,"context_line":"    def test_get_guest_cpu_config_host_passthrough(self):"},{"line_number":5437,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5438,"context_line":"        os_vif.initialize()"},{"line_number":5439,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":5440,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":5441,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_4fe276a1","line":5438,"in_reply_to":"7a8ec9b2_efb182e1","updated":"2016-09-21 20:33:04.000000000","message":"Yeah but we were already doing it right? I\u0027m just not sure how obvious it\u0027s going to be to anyone that tries to write a new test that things are failing and this is what they forgot.","commit_id":"bebd1ef8fc450a9804600d39e2dc89fdaf6c9fd9"}]}