)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"35395a66bcec9b541e665817d093a41b021e216d","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            return True"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def task_powering_action_failed(self, instance, context):"},{"line_number":770,"context_line":"        if (self._task_powering_action(instance, task_states.POWERING_OFF,"},{"line_number":771,"context_line":"                                       \"stop\", context) or"},{"line_number":772,"context_line":"                self._task_powering_action(instance, task_states.POWERING_ON,"},{"line_number":773,"context_line":"                                           \"start\", context)):"},{"line_number":774,"context_line":"            return True"},{"line_number":775,"context_line":"        return False"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def vm_deleted_failed(self, instance, context):"},{"line_number":778,"context_line":"        if (instance.vm_state \u003d\u003d vm_states.SOFT_DELETED or"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_aaf8cfe6","line":775,"range":{"start_line":770,"start_character":8,"end_line":775,"end_character":20},"updated":"2016-09-22 15:26:28.000000000","message":"This could be simplified:\n\n    return (self._task_powering_action(…) or\n            self._task_powering_action(…))","commit_id":"340d0f98b929caf0117ba646c38d378246cfd8d5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"35395a66bcec9b541e665817d093a41b021e216d","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                     instance\u003dinstance)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"            block_device_info \u003d \\"},{"line_number":834,"context_line":"                self._get_instance_block_device_info(context, instance)"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"            try:"},{"line_number":837,"context_line":"                self.driver.resume_state_on_host_boot("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ea1d7710","line":834,"updated":"2016-09-22 15:26:28.000000000","message":"I hate backslash continuations, and this one should be able to be eliminated easily:\n\n    block_device_info \u003d self._get_instance_block_device_info(\n        context, instance)","commit_id":"340d0f98b929caf0117ba646c38d378246cfd8d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f232d087a73cd293317af146071efd92c08294e8","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def _task_powering_action(self, instance, powering_state,"},{"line_number":753,"context_line":"                             action_msg, context):"},{"line_number":754,"context_line":"        if instance.task_state \u003d\u003d powering_state:"},{"line_number":755,"context_line":"            try:"},{"line_number":756,"context_line":"                LOG.debug(\"Instance in transitional state %s at start-up \""},{"line_number":757,"context_line":"                          \"retrying %s request\","}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_fe10fdaa","line":754,"range":{"start_line":754,"start_character":8,"end_line":754,"end_character":49},"updated":"2016-10-11 14:01:26.000000000","message":"How about\n\n   if x !\u003d y:\n      return\n\n   ...rest of code without indent","commit_id":"f346818e01f13f8064ed8fdba546ac28ad5e5217"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"bb2e017369e7e882780ef99b29ec41d57b22762c","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        # initialized and are not attempted to be recovered. The exception"},{"line_number":838,"context_line":"        # to this are instances that are in RESIZE_MIGRATING or DELETING,"},{"line_number":839,"context_line":"        # which are dealt with further down."},{"line_number":840,"context_line":"        if (instance.vm_state \u003d\u003d vm_states.SOFT_DELETED or"},{"line_number":841,"context_line":"            (instance.vm_state \u003d\u003d vm_states.ERROR and"},{"line_number":842,"context_line":"            instance.task_state not in"},{"line_number":843,"context_line":"            (task_states.RESIZE_MIGRATING, task_states.DELETING))):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_5f720013","line":840,"updated":"2017-06-13 22:22:46.000000000","message":"How is this different? Other conditionals were changed.","commit_id":"a1535fe32b2dc7670c6785f359f8eed1756ca329"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"bb2e017369e7e882780ef99b29ec41d57b22762c","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                      instance.vm_state, instance\u003dinstance)"},{"line_number":846,"context_line":"            return"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        if instance.vm_state \u003d\u003d vm_states.DELETED:"},{"line_number":849,"context_line":"            try:"},{"line_number":850,"context_line":"                self._complete_partial_deletion(context, instance)"},{"line_number":851,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_3f63c444","line":848,"updated":"2017-06-13 22:22:46.000000000","message":"see :840","commit_id":"a1535fe32b2dc7670c6785f359f8eed1756ca329"}]}