)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a7c40f857eb4ccd495892b411ef12ff48295c26","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Prior to this change, a 404 caused by a not possible route being"},{"line_number":10,"context_line":"round (such as /placement/hello) would result in a proper 404"},{"line_number":11,"context_line":"response but also a log message about an uncaught expectation that"},{"line_number":12,"context_line":"made it appear that a 404 responses is unexpected and something that"},{"line_number":13,"context_line":"needs exceptional attention. It doesn\u0027t. This change makes sure"},{"line_number":14,"context_line":"that 404s propagate up the stack in a clean way and logged only by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_2fbada6e","line":11,"updated":"2016-09-23 12:52:17.000000000","message":"s/expectation/exception :)","commit_id":"8c82d676d0fa6a816de1acd5fac457f58c353ef1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a7c40f857eb4ccd495892b411ef12ff48295c26","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Prior to this change, a 404 caused by a not possible route being"},{"line_number":10,"context_line":"round (such as /placement/hello) would result in a proper 404"},{"line_number":11,"context_line":"response but also a log message about an uncaught expectation that"},{"line_number":12,"context_line":"made it appear that a 404 responses is unexpected and something that"},{"line_number":13,"context_line":"needs exceptional attention. It doesn\u0027t. This change makes sure"},{"line_number":14,"context_line":"that 404s propagate up the stack in a clean way and logged only by"},{"line_number":15,"context_line":"the existing INFO log for all requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_4fb1e68e","line":12,"updated":"2016-09-23 12:52:17.000000000","message":"s/responses/response/","commit_id":"8c82d676d0fa6a816de1acd5fac457f58c353ef1"}],"nova/tests/unit/api/openstack/placement/test_handler.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a7c40f857eb4ccd495892b411ef12ff48295c26","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":112,"context_line":"                          app, environ, start_response)"},{"line_number":113,"context_line":"        mocked_log.error.assert_not_called()"},{"line_number":114,"context_line":"        mocked_log.exception.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_6face235","line":114,"updated":"2016-09-23 12:52:17.000000000","message":"meh, not sure I should bother complaining about assert_not_called() any more... :)","commit_id":"8c82d676d0fa6a816de1acd5fac457f58c353ef1"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e3088c6208532d89a054e1e55aa04d6d9656536c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":112,"context_line":"                          app, environ, start_response)"},{"line_number":113,"context_line":"        mocked_log.error.assert_not_called()"},{"line_number":114,"context_line":"        mocked_log.exception.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_a519ab7b","line":114,"in_reply_to":"5a8bc5a2_6face235","updated":"2016-09-23 13:14:06.000000000","message":"Yeah, I\u0027m not a fan either, largely because of that word at the start, but in this case I was this was the semantics I wanted: we never called to log. But yeah, meh.","commit_id":"8c82d676d0fa6a816de1acd5fac457f58c353ef1"}]}