)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"181f4968e1383c206bce70af0d69db920da1f0c8","unresolved":false,"context_lines":[{"line_number":874,"context_line":"                                                         sign\u003dsign)"},{"line_number":875,"context_line":"                pci_devs \u003d self.pci_tracker.pci_devs"},{"line_number":876,"context_line":"            else:"},{"line_number":877,"context_line":"                pci_devs \u003d objects.PciDeviceList()"},{"line_number":878,"context_line":"            self.scheduler_client.reportclient.update_instance_allocation("},{"line_number":879,"context_line":"                self.compute_node, instance, pci_devs, sign)"},{"line_number":880,"context_line":"            # new instance, update compute node resource usage:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_0a02f509","line":877,"updated":"2016-10-03 14:02:57.000000000","message":"I might be wrong, but I don\u0027t see the test case for this alternative.","commit_id":"f6729f701aeda70c147826d68de23410ff8abce8"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"65a0c922881c90e887ad64b1fc20e5625682c2d3","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        :param pci_devices: `objects.PciDeviceList` object that contains"},{"line_number":485,"context_line":"                            information about the compute host\u0027s PCI devices"},{"line_number":486,"context_line":"                            along with which instance might have the device"},{"line_number":487,"context_line":"                            allocated to it"},{"line_number":488,"context_line":"        \"\"\""},{"line_number":489,"context_line":"        if sign \u003e 0:"},{"line_number":490,"context_line":"            self._allocate_for_instance(compute_node, instance, pci_devices)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_e793e1f8","line":487,"updated":"2016-10-11 16:54:26.000000000","message":"If you\u0027re going to list the other three, may as well list sign too?","commit_id":"065f1e7a40e34799cfb4329b6774472eb130c76f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d372e8987c03406b193901893e55b078da366cf9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        VCPU: instance.flavor.vcpus,"},{"line_number":128,"context_line":"        DISK_GB: disk,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"    if len(pci_devices) \u003e 0:"},{"line_number":131,"context_line":"        consumer_uuid \u003d instance.uuid"},{"line_number":132,"context_line":"        result[PCI_DEVICE] \u003d len([d for d in pci_devices"},{"line_number":133,"context_line":"                                  if d.dev_type \u003d\u003d DEVICE_TYPE_STANDARD"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_046d5304","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":28},"updated":"2016-10-26 15:34:07.000000000","message":"nit:\n\n  if len(pci_devices):","commit_id":"46cb3149647709eb773eaf5578d32b9b947754be"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d372e8987c03406b193901893e55b078da366cf9","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        :param pci_devices: `objects.PciDeviceList` object that contains"},{"line_number":485,"context_line":"                            information about the compute host\u0027s PCI devices"},{"line_number":486,"context_line":"                            along with which instance might have the device"},{"line_number":487,"context_line":"                            allocated to it"},{"line_number":488,"context_line":"        \"\"\""},{"line_number":489,"context_line":"        if sign \u003e 0:"},{"line_number":490,"context_line":"            self._allocate_for_instance(compute_node, instance, pci_devices)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_2a09412d","line":487,"updated":"2016-10-26 15:34:07.000000000","message":"Do we care on updating documentation for new argument?","commit_id":"46cb3149647709eb773eaf5578d32b9b947754be"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d372e8987c03406b193901893e55b078da366cf9","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                            along with which instance might have the device"},{"line_number":487,"context_line":"                            allocated to it"},{"line_number":488,"context_line":"        \"\"\""},{"line_number":489,"context_line":"        if sign \u003e 0:"},{"line_number":490,"context_line":"            self._allocate_for_instance(compute_node, instance, pci_devices)"},{"line_number":491,"context_line":"        else:"},{"line_number":492,"context_line":"            self._delete_allocation_for_instance(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_04447372","line":489,"range":{"start_line":489,"start_character":8,"end_line":489,"end_character":20},"updated":"2016-10-26 15:34:07.000000000","message":"Is there a particular reason, why sign have to be an int? Since what I see on resource_tracker, sign is used like a flag and can have two values: -1 and 1. This could be changed to bool, unless I missed a third value somewhere…","commit_id":"46cb3149647709eb773eaf5578d32b9b947754be"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"562c56f81292be3beffe406d470961b70ac176ec","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    return a dict, keyed by resource class of the amount used by the instance."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    :param instance: `objects.Instance` object to translate"},{"line_number":116,"context_line":"    :param pci_devices: `objects.PciDeviceList` object to query about PCI"},{"line_number":117,"context_line":"                        device usage"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    # NOTE(danms): Boot-from-volume instances consume no local disk"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_459d1a09","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":22},"updated":"2016-11-25 13:55:23.000000000","message":"nit: this is exactly the same https://review.openstack.org/#/c/375168/9/nova/scheduler/client/report.py@474 but the docstring is different","commit_id":"926c8159e50f8cc2b003325e222d9d4a65879573"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"790262582b6c88a135f3804b67d86abad0580ce7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        VCPU: instance.flavor.vcpus,"},{"line_number":128,"context_line":"        DISK_GB: disk,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"    if len(pci_devices) \u003e 0:"},{"line_number":131,"context_line":"        consumer_uuid \u003d instance.uuid"},{"line_number":132,"context_line":"        result[PCI_DEVICE] \u003d len([d for d in pci_devices"},{"line_number":133,"context_line":"                                  if d.dev_type \u003d\u003d DEVICE_TYPE_STANDARD"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_539c14c0","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":28},"updated":"2016-11-16 18:10:11.000000000","message":"nit: just use `if pci_devices:`","commit_id":"926c8159e50f8cc2b003325e222d9d4a65879573"}]}