)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"22dcece6276dc30d7efe43a0a18eaa7951af1a80","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Default vnc.keymap to None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recommendation from the libvirt developers is to not set a keymap on"},{"line_number":10,"context_line":"the outside, instead have only the guest OS configure it as needed [1]."},{"line_number":11,"context_line":"With the recent noVNC patches, instances have started receiving broken"},{"line_number":12,"context_line":"keycodes due to a keymap being set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_48e9ea7f","line":10,"updated":"2016-09-23 09:36:00.000000000","message":"Things are more complicated than the situation in that message. With virt-manager we know exactly what VNC client will be used - GTK-VNC - so we know that it supports the VNC scancode protocol extension.\n\nHistorically noVNC has *not* supported this extension. It was only added in noVNC commit 8f06673a25c18f6a0cb4ae46db6ad7083875becc in August 2016 and AFAICT there\u0027s no tagged release since then, so we can\u0027t depend on it yet. It also comes with the caveat that it requires the browser to support the KeyboardEvent.code property, but does not mention which browsers support that. We need to understand the level of browser compatibility before we consider changing that","commit_id":"9e16e4e8f9d3268434cf372478087ad745b4bc83"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a76db7d833737dd4d1fd0ac2342679952049331c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Default vnc.keymap to None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recommendation from the libvirt developers is to not set a keymap on"},{"line_number":10,"context_line":"the outside, instead have only the guest OS configure it as needed [1]."},{"line_number":11,"context_line":"With the recent noVNC patches, instances have started receiving broken"},{"line_number":12,"context_line":"keycodes due to a keymap being set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_c394fde3","line":10,"in_reply_to":"5a8bc5a2_48e9ea7f","updated":"2016-09-23 09:49:57.000000000","message":"You are right that there is no release of noVNC with this yet, the issue currently only seems to affect devstack installations which by default use noVNC from git master.\n\nMaybe you want to also look at the bug report [1], the currently proposed solution seems to be to add a new option [2], but getting things working with that in a backward compatible way seems difficult to me, too.\n\n[1] https://github.com/kanaka/noVNC/issues/666\n[2] https://github.com/kanaka/noVNC/pull/667","commit_id":"9e16e4e8f9d3268434cf372478087ad745b4bc83"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cdb85683181c93f5698b2e116dfcaef7762b2387","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Default vnc.keymap to None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recommendation from the libvirt developers is to not set a keymap on"},{"line_number":10,"context_line":"the outside, instead have only the guest OS configure it as needed [1]."},{"line_number":11,"context_line":"With the recent noVNC patches, instances have started receiving broken"},{"line_number":12,"context_line":"keycodes due to a keymap being set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_e66e66c8","line":10,"in_reply_to":"5a8bc5a2_c394fde3","updated":"2016-09-23 10:10:22.000000000","message":"That \"solution\" just looks plain wrong - I think there\u0027s simply a bug in the data that noVNC is sending in the first place.","commit_id":"9e16e4e8f9d3268434cf372478087ad745b4bc83"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"22dcece6276dc30d7efe43a0a18eaa7951af1a80","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The recommendation from the libvirt developers is to not set a keymap on"},{"line_number":10,"context_line":"the outside, instead have only the guest OS configure it as needed [1]."},{"line_number":11,"context_line":"With the recent noVNC patches, instances have started receiving broken"},{"line_number":12,"context_line":"keycodes due to a keymap being set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://www.redhat.com/archives/libvir-list/2009-May/msg00234.html"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_6886a614","line":12,"updated":"2016-09-23 09:36:00.000000000","message":"What recent patches are these ? Please provide the commit IDs from noVNC. If there are been regressions in keyboard handling, those must absolutely be fixed, regardless of what we set for nova keymap defaults, otherwise users will still hit the problem when they override the nova default.","commit_id":"9e16e4e8f9d3268434cf372478087ad745b4bc83"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a76db7d833737dd4d1fd0ac2342679952049331c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The recommendation from the libvirt developers is to not set a keymap on"},{"line_number":10,"context_line":"the outside, instead have only the guest OS configure it as needed [1]."},{"line_number":11,"context_line":"With the recent noVNC patches, instances have started receiving broken"},{"line_number":12,"context_line":"keycodes due to a keymap being set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://www.redhat.com/archives/libvir-list/2009-May/msg00234.html"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_03b7c5d8","line":12,"in_reply_to":"5a8bc5a2_6886a614","updated":"2016-09-23 09:49:57.000000000","message":"It seems to be exactly the patch you mention above, reverting to the patch before that one solves the issue, see the discussion in the bug report.","commit_id":"9e16e4e8f9d3268434cf372478087ad745b4bc83"}]}