)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4503e237186ba666606db85e5e83376fe1e32b75","unresolved":false,"context_lines":[{"line_number":4509,"context_line":"            for pci_dev in pci_manager.get_instance_pci_devs(instance):"},{"line_number":4510,"context_line":"                guest.add_device(self._get_guest_pci_device(pci_dev))"},{"line_number":4511,"context_line":"        else:"},{"line_number":4512,"context_line":"            # Get all PCI devices."},{"line_number":4513,"context_line":"            if len(pci_manager.get_instance_pci_devs(instance, \u0027all\u0027)) \u003e 0:"},{"line_number":4514,"context_line":"                raise exception.PciDeviceUnsupportedHypervisor("},{"line_number":4515,"context_line":"                    type\u003dvirt_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_2fd78824","line":4512,"range":{"start_line":4512,"start_character":12,"end_line":4512,"end_character":34},"updated":"2016-10-18 00:16:57.000000000","message":"It would be better to write the reason why we need to raise an exception here in this case.","commit_id":"5398a58dfbe4317787c5d0fed30a7143d41a419e"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"0d39a3c6bdf74556a322d24e7aa4488a9c0080b5","unresolved":false,"context_lines":[{"line_number":4509,"context_line":"            for pci_dev in pci_manager.get_instance_pci_devs(instance):"},{"line_number":4510,"context_line":"                guest.add_device(self._get_guest_pci_device(pci_dev))"},{"line_number":4511,"context_line":"        else:"},{"line_number":4512,"context_line":"            # Get all PCI devices."},{"line_number":4513,"context_line":"            if len(pci_manager.get_instance_pci_devs(instance, \u0027all\u0027)) \u003e 0:"},{"line_number":4514,"context_line":"                raise exception.PciDeviceUnsupportedHypervisor("},{"line_number":4515,"context_line":"                    type\u003dvirt_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_4799ed1e","line":4512,"range":{"start_line":4512,"start_character":12,"end_line":4512,"end_character":34},"in_reply_to":"fa6399be_2fd78824","updated":"2016-10-18 12:59:56.000000000","message":"Done","commit_id":"5398a58dfbe4317787c5d0fed30a7143d41a419e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4503e237186ba666606db85e5e83376fe1e32b75","unresolved":false,"context_lines":[{"line_number":4510,"context_line":"                guest.add_device(self._get_guest_pci_device(pci_dev))"},{"line_number":4511,"context_line":"        else:"},{"line_number":4512,"context_line":"            # Get all PCI devices."},{"line_number":4513,"context_line":"            if len(pci_manager.get_instance_pci_devs(instance, \u0027all\u0027)) \u003e 0:"},{"line_number":4514,"context_line":"                raise exception.PciDeviceUnsupportedHypervisor("},{"line_number":4515,"context_line":"                    type\u003dvirt_type)"},{"line_number":4516,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_cff0cccc","line":4513,"updated":"2016-10-18 00:16:57.000000000","message":"nit: how about just moving like\n\n pci_devs \u003d pci_manager.get_instance_pci_devs(instance, \u0027all\u0027)\n if len(pci_devs) \u003e 0:\n     ...\n\nThis is not a strong opinion at all, just wanted to make the code readable by avoiding many ()..","commit_id":"5398a58dfbe4317787c5d0fed30a7143d41a419e"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"0d39a3c6bdf74556a322d24e7aa4488a9c0080b5","unresolved":false,"context_lines":[{"line_number":4510,"context_line":"                guest.add_device(self._get_guest_pci_device(pci_dev))"},{"line_number":4511,"context_line":"        else:"},{"line_number":4512,"context_line":"            # Get all PCI devices."},{"line_number":4513,"context_line":"            if len(pci_manager.get_instance_pci_devs(instance, \u0027all\u0027)) \u003e 0:"},{"line_number":4514,"context_line":"                raise exception.PciDeviceUnsupportedHypervisor("},{"line_number":4515,"context_line":"                    type\u003dvirt_type)"},{"line_number":4516,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_a78809c8","line":4513,"in_reply_to":"fa6399be_cff0cccc","updated":"2016-10-18 12:59:56.000000000","message":"Done","commit_id":"5398a58dfbe4317787c5d0fed30a7143d41a419e"}]}