)]}'
{"id":"openstack%2Fnova~375506","triplet_id":"openstack%2Fnova~master~Ied4d0481bdd9cf11f0b44b307a0aeddc1a5878ed","project":"openstack/nova","branch":"master","topic":"fix_func_tests","hashtags":[],"change_id":"Ied4d0481bdd9cf11f0b44b307a0aeddc1a5878ed","subject":"remove extra error_log from gabbi test fixtures","status":"ABANDONED","created":"2016-09-23 14:03:27.000000000","updated":"2016-11-30 11:33:59.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f62119cf3fcf4c296bb518f1e1adfbda1379222c","_number":375506,"virtual_id_number":375506,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2016-09-23 20:50:24.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2016-09-23 14:41:24.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":1,"date":"2016-09-27 07:10:43.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"date":"2016-09-23 15:02:52.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2016-09-23 14:29:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":-1,"date":"2016-09-23 14:11:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"date":"2016-09-23 15:57:42.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-23 14:11:42.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2016-09-23 14:29:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-23 14:41:24.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-09-23 15:02:52.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-09-23 15:57:42.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-09-23 20:50:24.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-09-27 07:10:43.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5d7b1c150e9898e2039d4a39c6d281f4a0e4cf31","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-09-23 14:03:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed9fc2270094eb598c96a4696e4343641ab8b37d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-09-23 14:11:42.000000000","message":"Patch Set 1: Code-Review-1\n\nIf you read the commit message where I added in this functionality, without this you _cannot_ debug the application side of failures. You will only see the output of a test failure, but not the error underlying that test failure.\n\nFor example if you expected a 400 but got a 500, the test would show that it failed comparing status on the 500, but you wouldn\u0027t see the traceback for that 500 anywhere.\n\nBy having this change you are trying to remove, we do get the traceback.\n\nYes, that means you end up paying a small price of getting some tracebacks always (where gabbi is intentionally causing some errors), but they are inline with the tests that caused them and not blorty noise.\n\nIf I had the power to do so, I would -2 this because if we merge it, it means we have no effective way to debug or TDD with the tests that use this fixture.\n\nI agree that it would be nice to capture the output better, but until we figure out how to do it nicely, we shouldn\u0027t swallow it wholesale.\n\nI suspect there is a way to do it, but I couldn\u0027t figure it out, we probably can with some discussion, but please let\u0027s not do this change.","accounts_in_message":[],"_revision_number":1},{"id":"939b3b5500ec616435e3d3b51ec2148a5a3a789a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-23 14:29:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-nova-docs-ubuntu-xenial http://docs-draft.openstack.org/06/375506/1/check/gate-nova-docs-ubuntu-xenial/f91a134//doc/build/html/ : SUCCESS in 3m 31s\n- gate-nova-pep8-ubuntu-xenial http://logs.openstack.org/06/375506/1/check/gate-nova-pep8-ubuntu-xenial/3cbc29e/ : FAILURE in 6m 53s\n- gate-nova-python27-db-ubuntu-xenial http://logs.openstack.org/06/375506/1/check/gate-nova-python27-db-ubuntu-xenial/a1b0d1f/ : SUCCESS in 14m 00s\n- gate-nova-python34-db http://logs.openstack.org/06/375506/1/check/gate-nova-python34-db/59bbf99/ : SUCCESS in 12m 38s\n- gate-nova-python35-db-nv http://logs.openstack.org/06/375506/1/check/gate-nova-python35-db-nv/3c880ec/ : SUCCESS in 14m 50s (non-voting)\n- gate-nova-tox-db-functional-ubuntu-xenial http://logs.openstack.org/06/375506/1/check/gate-nova-tox-db-functional-ubuntu-xenial/245f8b5/ : SUCCESS in 17m 24s","accounts_in_message":[],"_revision_number":1},{"id":"973fb17f8ccde43661753c930d7d079220fae5d8","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2016-09-23 14:41:24.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/375506/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c0e7d47482a609655b1defa0939e1ef087b896fc","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-09-23 15:02:52.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Microsoft Hyper-V CI, add a review comment with check hyper-v\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/375506/1/ : FAILURE in 58m 15s","accounts_in_message":[],"_revision_number":1},{"id":"e19be9f5c4da3c7ac4cd67f7d7f69e638c071e3f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-09-23 17:15:54.000000000","message":"Patch Set 1:\n\nSean and I worked out a way to change gabbi such that this stuff will work out in a reasonable way, allowing the fixtures to work per test in gabbi: http://paste.openstack.org/show/582788/\n\nI\u0027ve got that working, but need to integrate it into a real gabbi version.","accounts_in_message":[],"_revision_number":1},{"id":"aee327eeaf850f1ee1e872759c929f49c26275c7","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-09-23 20:50:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/06/375506/1/check/tempest-dsvm-full-nfv-xenial/d1f07b4 : SUCCESS in 1h 42m 26s\n- tempest-dsvm-intel-nfv-xenial http://intel-openstack-ci-logs.ovh/06/375506/1/check/tempest-dsvm-intel-nfv-xenial/fa44965 : SUCCESS in 46m 17s\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/06/375506/1/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/6fdda47 : SUCCESS in 1h 04m 56s","accounts_in_message":[],"_revision_number":1},{"id":"c923d90eb5539f1ff8db523399173a952f23c299","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2016-09-27 07:10:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\n* vmware-dsvm-ext-nova http://208.91.1.172/logs/vmware-dsvm-ext-nova/375506/1/1321/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b5ea8617a280d67166f2cd88b117a8b1502d50a5","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-11-30 11:33:59.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1afbc587e7a2240288b6e424fb5f856777c906a4","revisions":{"1afbc587e7a2240288b6e424fb5f856777c906a4":{"kind":"REWORK","_number":1,"created":"2016-09-23 14:03:27.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/06/375506/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/375506/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/375506/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/375506/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/375506/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/375506/1"}}},"commit":{"parents":[{"commit":"f75c06aa8a2abb8eed2b47530b429cba8213b62e","subject":"properly capture logging during db functional tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f75c06aa8a2abb8eed2b47530b429cba8213b62e"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2016-09-23 14:01:51.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2016-09-23 14:01:51.000000000","tz":-240},"subject":"remove extra error_log from gabbi test fixtures","message":"remove extra error_log from gabbi test fixtures\n\nThe extra error_log part of gabbi test fixtures was specifically\nbypassing our output capture and ending up blasting into the output\nstream not under any control. This is exactly what we don\u0027t want to\nhappen and what we\u0027ve been trying to remove other places.\n\nChange-Id: Ied4d0481bdd9cf11f0b44b307a0aeddc1a5878ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1afbc587e7a2240288b6e424fb5f856777c906a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1afbc587e7a2240288b6e424fb5f856777c906a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}