)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b506eec5ff76230f6cb819dc13c635aa7fdf15b2","unresolved":false,"context_lines":[{"line_number":5379,"context_line":"            # for the case when instance.vcpu_model.cpu_model not specified."},{"line_number":5380,"context_line":"            # We have satisfied topology check via claims test and we are"},{"line_number":5381,"context_line":"            # using a generally compatible qemu CPU model in this case."},{"line_number":5382,"context_line":"            pass"},{"line_number":5383,"context_line":"        else:"},{"line_number":5384,"context_line":"            self._compare_cpu(instance.vcpu_model, None, instance)"},{"line_number":5385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_c08a8e1a","line":5382,"updated":"2016-09-27 14:23:53.000000000","message":"I think I would at least log something at debug level here.","commit_id":"cbf08cd58915015fef9c95ffea0a46bc0aa64b25"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0e68eb4f0bc88d392e461fbccee72731c95fb518","unresolved":false,"context_lines":[{"line_number":5379,"context_line":"            # for the case when instance.vcpu_model.cpu_model not specified."},{"line_number":5380,"context_line":"            # We have satisfied topology check via claims test and we are"},{"line_number":5381,"context_line":"            # using a generally compatible qemu CPU model in this case."},{"line_number":5382,"context_line":"            pass"},{"line_number":5383,"context_line":"        else:"},{"line_number":5384,"context_line":"            self._compare_cpu(instance.vcpu_model, None, instance)"},{"line_number":5385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_cb52af12","line":5382,"in_reply_to":"5a8bc5a2_c08a8e1a","updated":"2016-09-27 14:30:08.000000000","message":"No, this is really *not* something we should do. Making blind assumptions about compatibility is exactly the kind of thing that leads to impossible to debug failures on live migration and can lead to guests breaking. We need to be pessimistic about compatibility unless we can *prove* things are ok.\n\nUsers who care about being able to migrate guests, should never run without an explicit CPU model set.","commit_id":"cbf08cd58915015fef9c95ffea0a46bc0aa64b25"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"540c66f726aa7da4cfb2a2ef37e84e0f36d7892a","unresolved":false,"context_lines":[{"line_number":5379,"context_line":"            # for the case when instance.vcpu_model.cpu_model not specified."},{"line_number":5380,"context_line":"            # We have satisfied topology check via claims test and we are"},{"line_number":5381,"context_line":"            # using a generally compatible qemu CPU model in this case."},{"line_number":5382,"context_line":"            pass"},{"line_number":5383,"context_line":"        else:"},{"line_number":5384,"context_line":"            self._compare_cpu(instance.vcpu_model, None, instance)"},{"line_number":5385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_3d926fa0","line":5382,"in_reply_to":"5a8bc5a2_cb52af12","updated":"2016-09-27 17:33:37.000000000","message":"For what it\u0027s worth, with CentOS 7 I can\u0027t explicitly set a cpu_model of \"qemu64\", it chokes on instance startup with \" Exception during message handling: unsupported configuration: guest and host CPU are not compatible: Host CPU does not provide required features: svm\"\n\nFor some reason it wants to use \"svm\" even though I\u0027m on an Intel host.\n\n\"kvm64\" works, but some of the flags are missing compared to what I get if I don\u0027t specify a model.","commit_id":"cbf08cd58915015fef9c95ffea0a46bc0aa64b25"}]}