)]}'
{"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e16d06261971dead7b305c62f3f663b59aedd07","unresolved":false,"context_lines":[{"line_number":3558,"context_line":"        \"\"\"Tests that requesting auto networking is OK. This test"},{"line_number":3559,"context_line":"        short-circuits on a FlavorNotFound error."},{"line_number":3560,"context_line":"        \"\"\""},{"line_number":3561,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":3562,"context_line":"        ex \u003d self.assertRaises("},{"line_number":3563,"context_line":"            webob.exc.HTTPBadRequest, self._create_server, \u0027auto\u0027)"},{"line_number":3564,"context_line":"        # make sure it was a flavor not found error and not something else"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_b7d5ce1c","line":3561,"updated":"2016-09-27 13:41:51.000000000","message":"It seems like these could just be done in the setup rather than individual tests. There should actually be a test in here for a case that the minimum compute service version is lower than needed, but I\u0027m not finding that test - but should test this:\n\nhttps://github.com/openstack/nova/blob/723ee0195f11a2df819613728f12148290a100b4/nova/api/openstack/compute/servers.py#L436","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adb55751e01f9cea812d7c89897cfb8f5b42d860","unresolved":false,"context_lines":[{"line_number":3558,"context_line":"        \"\"\"Tests that requesting auto networking is OK. This test"},{"line_number":3559,"context_line":"        short-circuits on a FlavorNotFound error."},{"line_number":3560,"context_line":"        \"\"\""},{"line_number":3561,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":3562,"context_line":"        ex \u003d self.assertRaises("},{"line_number":3563,"context_line":"            webob.exc.HTTPBadRequest, self._create_server, \u0027auto\u0027)"},{"line_number":3564,"context_line":"        # make sure it was a flavor not found error and not something else"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_9700d203","line":3561,"in_reply_to":"5a8bc5a2_b7d5ce1c","updated":"2016-09-27 13:49:32.000000000","message":"I pulled this change down and moved self.useFixture(nova_fixtures.AllServicesCurrent()) to setUp and the tests all pass still, so we could just do that if we wanted. But I\u0027m OK either way.","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a900f31a8cdacd2b5c04bab152c8f4e5a2c32b5c","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"        self.assertRaises(exception.ValidationError, self._create_server,"},{"line_number":3600,"context_line":"                          [{\u0027uuid\u0027: uuid}])"},{"line_number":3601,"context_line":""},{"line_number":3602,"context_line":"    @mock.patch.object(objects.Service, \u0027get_minimum_version\u0027,"},{"line_number":3603,"context_line":"                       return_value\u003d11)"},{"line_number":3604,"context_line":"    def test_validate_auto_or_none_network_request_old_computes(self,"},{"line_number":3605,"context_line":"                                                                mock_get_ver):"},{"line_number":3606,"context_line":"        \"\"\"Tests that the network request is nulled out when the minimum"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_57d9eaf1","line":3603,"range":{"start_line":3602,"start_character":4,"end_line":3603,"end_character":39},"updated":"2016-09-27 13:44:19.000000000","message":"Ah here is what I was looking for.","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adb55751e01f9cea812d7c89897cfb8f5b42d860","unresolved":false,"context_lines":[{"line_number":4819,"context_line":"        self._create_policy_check(rule, rule_name)"},{"line_number":4820,"context_line":""},{"line_number":4821,"context_line":"    def test_create_attach_volume_policy_failed(self):"},{"line_number":4822,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":4823,"context_line":"        rule_name \u003d \"os_compute_api:servers:create:attach_volume\""},{"line_number":4824,"context_line":"        rules \u003d {\"os_compute_api:servers:create\": \"@\","},{"line_number":4825,"context_line":"                 \"os_compute_api:servers:create:forced_host\": \"@\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_7a616bd2","line":4822,"updated":"2016-09-27 13:49:32.000000000","message":"Hmm, I\u0027m interested to know what\u0027s hitting this in these tests.","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adf16f41e3e41f8b767dceff22d89fabe04b370a","unresolved":false,"context_lines":[{"line_number":4819,"context_line":"        self._create_policy_check(rule, rule_name)"},{"line_number":4820,"context_line":""},{"line_number":4821,"context_line":"    def test_create_attach_volume_policy_failed(self):"},{"line_number":4822,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":4823,"context_line":"        rule_name \u003d \"os_compute_api:servers:create:attach_volume\""},{"line_number":4824,"context_line":"        rules \u003d {\"os_compute_api:servers:create\": \"@\","},{"line_number":4825,"context_line":"                 \"os_compute_api:servers:create:forced_host\": \"@\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_3d443d48","line":4822,"in_reply_to":"5a8bc5a2_3a8c43d9","updated":"2016-09-27 14:03:08.000000000","message":"OK, I figured that was it. How about we move this fixture into the setUp for the test then? These tests aren\u0027t trying to test the 2.32 or 2.37 microversion, so using the latest service version always seems OK, and then new tests in this class don\u0027t have to worry about making sure they have this.","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"a015ec672f9d6652cf912a87877a17907df41e16","unresolved":false,"context_lines":[{"line_number":4819,"context_line":"        self._create_policy_check(rule, rule_name)"},{"line_number":4820,"context_line":""},{"line_number":4821,"context_line":"    def test_create_attach_volume_policy_failed(self):"},{"line_number":4822,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":4823,"context_line":"        rule_name \u003d \"os_compute_api:servers:create:attach_volume\""},{"line_number":4824,"context_line":"        rules \u003d {\"os_compute_api:servers:create\": \"@\","},{"line_number":4825,"context_line":"                 \"os_compute_api:servers:create:forced_host\": \"@\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_9d71d10e","line":4822,"in_reply_to":"5a8bc5a2_3d443d48","updated":"2016-09-27 14:14:28.000000000","message":"Done","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"ab61ddf70b8e8fcaa1f4d2b7d9d19c0d3c0c8dda","unresolved":false,"context_lines":[{"line_number":4819,"context_line":"        self._create_policy_check(rule, rule_name)"},{"line_number":4820,"context_line":""},{"line_number":4821,"context_line":"    def test_create_attach_volume_policy_failed(self):"},{"line_number":4822,"context_line":"        self.useFixture(nova_fixtures.AllServicesCurrent())"},{"line_number":4823,"context_line":"        rule_name \u003d \"os_compute_api:servers:create:attach_volume\""},{"line_number":4824,"context_line":"        rules \u003d {\"os_compute_api:servers:create\": \"@\","},{"line_number":4825,"context_line":"                 \"os_compute_api:servers:create:forced_host\": \"@\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_3a8c43d9","line":4822,"in_reply_to":"5a8bc5a2_7a616bd2","updated":"2016-09-27 14:00:14.000000000","message":"The trace: http://paste.openstack.org/show/583084/\n\nIt\u0027s hitting the new device tagging version check in create():\n\nhttps://github.com/openstack/nova/blob/69784047ea84bae60bac34fa193eb4a39007bc7a/nova/api/openstack/compute/servers.py#L574","commit_id":"bb7d5ce0253bdb2d79a5f4e97738ae10253c4a5d"}]}