)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ce17a4c1e56a615c0e63f9b05ac84e32d19dffc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Though Nova and oslo.utils implemented in different way. We can improve"},{"line_number":11,"context_line":"the version of oslo.utils to make it suitable to other projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]https://github.com/openstack/oslo.utils/blob\\"},{"line_number":14,"context_line":"/d1e08f533d4351f10b8103e24c254004b6627a29/oslo_utils/netutils.py#L170"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieed03ab210bd95563fd7acac130d393d988df40d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_2cb1b647","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":69},"updated":"2016-10-07 15:48:50.000000000","message":"nit: You could shorten the commit hash to ~6 characters - minimal chance of collisions","commit_id":"4cdb48c224be585605777218ae63c033435d7c75"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"2ce0c1164aab2517f808639b66bd95698f9f124c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Though Nova and oslo.utils implemented in different way. We can improve"},{"line_number":11,"context_line":"the version of oslo.utils to make it suitable to other projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]https://github.com/openstack/oslo.utils/blob\\"},{"line_number":14,"context_line":"/d1e08f533d4351f10b8103e24c254004b6627a29/oslo_utils/netutils.py#L170"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieed03ab210bd95563fd7acac130d393d988df40d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_fc42d766","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":69},"in_reply_to":"1a95cdbc_2cb1b647","updated":"2016-10-17 08:18:06.000000000","message":"Done","commit_id":"4cdb48c224be585605777218ae63c033435d7c75"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70eea9d8ab73ebe01746953e77265e14b2409b65","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.utils provides similar function[1] to check if ipv6 is supported."},{"line_number":10,"context_line":"Though Nova and oslo.utils implemented in different way. We can improve"},{"line_number":11,"context_line":"the version of oslo.utils to make it suitable to other projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]https://github.com/openstack/oslo.utils/blob/d1e08f/oslo_utils/netutils.py#L170"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_62f61c90","line":11,"updated":"2016-10-17 08:55:14.000000000","message":"Did you propose a corresponding patch to oslo.utils? If not then I\u0027m not sure what you intend to say with this sentence.\n\nAre the implementations similar enough so that they will yield the same result in all cases or are there corner cases that might break with your change?","commit_id":"433dd05c51c37f8cf05bb836c58189769b0bbeb1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"c7ed0e3b8f80e052c8a6ae07848928b2b1b729e7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.utils provides similar function[1] to check if ipv6 is supported."},{"line_number":10,"context_line":"Though Nova and oslo.utils implemented in different way. We can improve"},{"line_number":11,"context_line":"the version of oslo.utils to make it suitable to other projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]https://github.com/openstack/oslo.utils/blob/d1e08f/oslo_utils/netutils.py#L170"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_c6d53543","line":11,"in_reply_to":"fa6399be_62f61c90","updated":"2016-10-17 11:25:24.000000000","message":"nova specific version is different from oslo.utils one. It\u0027s hard to say which one is better, I would like to collect suggestions from Nova, I will propose them into oslo.utils if we need.","commit_id":"433dd05c51c37f8cf05bb836c58189769b0bbeb1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"7a52661a66bb1baba56ebf473fab94aa6ff32200","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.utils provides similar function[1] to check if ipv6 is supported."},{"line_number":10,"context_line":"Though Nova and oslo.utils implemented in different way. We can improve"},{"line_number":11,"context_line":"the version of oslo.utils to make it suitable to other projects."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]https://github.com/openstack/oslo.utils/blob/d1e08f/oslo_utils/netutils.py#L170"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_d6f055cc","line":11,"in_reply_to":"fa6399be_c6d53543","updated":"2016-10-18 11:45:02.000000000","message":"The oslo.utils method merely checks whether the kernel has ipv6 support present. The nova method checks whether ipv6 is actually usable in sockets calls, which is a stronger check and directly reflects the requirements of the test suite.\n\nSo I don\u0027t think it is right to replace the nova method call with the oslo.utils call, as it currently exists in oslo.utils. \n\nI don\u0027t think that the oslo.utils method is wrong per-se - it is simply trying to check for a different scenario than the nova one is checking. So whether we can change the oslo.util method, or have to add a different oslo.utils method I acn\u0027t say.","commit_id":"433dd05c51c37f8cf05bb836c58189769b0bbeb1"}]}