)]}'
{"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"618c907a11e9174ea8ee7aa633c1b7e973969cb6","unresolved":false,"context_lines":[{"line_number":2938,"context_line":"            self.assertEqual(node, instance.node)"},{"line_number":2939,"context_line":"            mock_set.assert_called_once_with(None, \u0027done\u0027)"},{"line_number":2940,"context_line":""},{"line_number":2941,"context_line":"    def _rebuild_instance(self, instance, recreate\u003dNone):"},{"line_number":2942,"context_line":"        kwargs \u003d {\"orig_image_ref\": None, \"image_ref\": None,"},{"line_number":2943,"context_line":"                  \"injected_files\": None, \"orig_sys_metadata\": None,"},{"line_number":2944,"context_line":"                  \"new_pass\": None, \"bdms\": None, \"recreate\": recreate}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_92be01fe","line":2941,"updated":"2016-09-28 15:34:29.000000000","message":"sorry, I missed it previous review. I think you should use \u0027False\u0027 as default value for \u0027recreate\u0027. I know that in line 2909 it was \u0027None\u0027. But it\u0027s not quite right. Recreate is a boolean parameter. Previously it worked only because in method rebuild_instance() \u0027recreate\u0027 parameted was used like:\n\n if recreate:\n      ******\n\nAs you see in this case \u0027None\u0027 and \u0027False\u0027 values wouldn\u0027t allow to go in \u0027if\u0027 body. But anyway I think if you are changing this part of code you should do it in right way.","commit_id":"e613fddb2e511da422e93fbc70697c0763890910"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3f892b3d2022b95766f411632f0564ca3cd3801b","unresolved":false,"context_lines":[{"line_number":2906,"context_line":"            mock.patch.object(self.compute, \u0027_notify_about_instance_usage\u0027),"},{"line_number":2907,"context_line":"            mock.patch.object(compute_utils, \u0027EventReporter\u0027)"},{"line_number":2908,"context_line":"        ) as (mock_get, mock_rebuild, mock_set, mock_notify, mock_event):"},{"line_number":2909,"context_line":"            self._rebuild_instance(instance, recreate\u003dNone)"},{"line_number":2910,"context_line":"            mock_set.assert_called_once_with(None, \u0027failed\u0027)"},{"line_number":2911,"context_line":"            mock_notify.assert_called_once_with(mock.ANY, instance,"},{"line_number":2912,"context_line":"                                                \u0027rebuild.error\u0027, fault\u003dex)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_1ea2654b","line":2909,"range":{"start_line":2909,"start_character":54,"end_line":2909,"end_character":58},"updated":"2016-10-07 13:59:37.000000000","message":"I think it would be better to change this to False","commit_id":"39adee733e5adebcae47a9b4998b47b480749ca4"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"8503ade01b78a62435b8bf49c499354d81f8a524","unresolved":false,"context_lines":[{"line_number":2906,"context_line":"            mock.patch.object(self.compute, \u0027_notify_about_instance_usage\u0027),"},{"line_number":2907,"context_line":"            mock.patch.object(compute_utils, \u0027EventReporter\u0027)"},{"line_number":2908,"context_line":"        ) as (mock_get, mock_rebuild, mock_set, mock_notify, mock_event):"},{"line_number":2909,"context_line":"            self._rebuild_instance(instance, recreate\u003dNone)"},{"line_number":2910,"context_line":"            mock_set.assert_called_once_with(None, \u0027failed\u0027)"},{"line_number":2911,"context_line":"            mock_notify.assert_called_once_with(mock.ANY, instance,"},{"line_number":2912,"context_line":"                                                \u0027rebuild.error\u0027, fault\u003dex)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_3ed60e28","line":2909,"range":{"start_line":2909,"start_character":54,"end_line":2909,"end_character":58},"in_reply_to":"1a95cdbc_1ea2654b","updated":"2016-10-10 08:00:56.000000000","message":"may be just remove \u0027recreate\u003dNone\u0027 and left \n\n self._rebuild_instance(instance)\n\nlook at my previous comment \n\nhttps://review.openstack.org/#/c/376004/4/nova/tests/unit/compute/test_compute_mgr.py","commit_id":"39adee733e5adebcae47a9b4998b47b480749ca4"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"e54e20a7ee91bbf57971a5869bda136797943735","unresolved":false,"context_lines":[{"line_number":2906,"context_line":"            mock.patch.object(self.compute, \u0027_notify_about_instance_usage\u0027),"},{"line_number":2907,"context_line":"            mock.patch.object(compute_utils, \u0027EventReporter\u0027)"},{"line_number":2908,"context_line":"        ) as (mock_get, mock_rebuild, mock_set, mock_notify, mock_event):"},{"line_number":2909,"context_line":"            self._rebuild_instance(instance, recreate\u003dNone)"},{"line_number":2910,"context_line":"            mock_set.assert_called_once_with(None, \u0027failed\u0027)"},{"line_number":2911,"context_line":"            mock_notify.assert_called_once_with(mock.ANY, instance,"},{"line_number":2912,"context_line":"                                                \u0027rebuild.error\u0027, fault\u003dex)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_8c0dd040","line":2909,"range":{"start_line":2909,"start_character":54,"end_line":2909,"end_character":58},"in_reply_to":"1a95cdbc_3ed60e28","updated":"2016-10-12 08:55:47.000000000","message":"Ok, i\u0027ve just thought that False and None can yield different result.","commit_id":"39adee733e5adebcae47a9b4998b47b480749ca4"}]}