)]}'
{"doc/notification_samples/instance-shelve-offload-end.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"18ad75abec3ead3acc1fb17c32dafab05f24bc80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a95cdbc_fea39d4d","updated":"2016-10-04 14:20:56.000000000","message":"Let\u0027s call the file instance-shelve_offload-end.json so the event_type itself does not contain hyphen. Also this makes it consistent with the already transformed power_on notification","commit_id":"dfaf5970c278730d9c692fbd8c0897d342d8c69e"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd8cabaae21ba3baa2f8b7325907b6f6960cc398","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":264,"context_line":"        self.flags(shelved_offload_time\u003d0)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":267,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":268,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_ffde70db","line":266,"updated":"2016-10-03 11:47:21.000000000","message":"Most probably the test fails because an active instance cannot be offloaded see the error from the test log:\n\nCannot \u0027shelveOffload\u0027 instance 476c187e-af52-43ad-a6f9-0f5d0be6bdb2 while it is in vm_state active\n\nThe _test_shelve_server unshelves the instance and that causes that the instance is active in this test. Try to remove the unshelve part of the _test_shelve_server to see if it helps.","commit_id":"18cd287c0e33c8996268c7cb5576d4f37c60bd64"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f0a26b24a73830d82641186b45b85c2acc259c69","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":264,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":265,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":266,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_0cfb3148","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":72},"updated":"2016-10-07 07:14:23.000000000","message":"Before calling this API, make a server\u0027s status be \u0027SHELVED\u0027 or check whether a server\u0027s status is \u0027SHELVED\u0027.","commit_id":"829320f39b5b18902ba087d614d2a5d55ca27fb4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"005d41615491e5832ca5310f999d479a291f5f34","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":264,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":265,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":266,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_90890b78","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":72},"in_reply_to":"1a95cdbc_0cfb3148","updated":"2016-10-07 11:09:36.000000000","message":"I think it is enough to check that the server status is selved.","commit_id":"829320f39b5b18902ba087d614d2a5d55ca27fb4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b9a2860d28526f466b6e6e11bb42555e00876a7","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":280,"context_line":"        self.flags(shelved_offload_time\u003d-1)"},{"line_number":281,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelve\u0027: {}})"},{"line_number":282,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":283,"context_line":"                                    expected_status\u003d\u0027SHELVED\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_d62b1532","line":280,"updated":"2016-10-21 01:36:17.000000000","message":"Why isn\u0027t this \u003d\u003d0 to trigger the shelve offload?\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4218","commit_id":"a6456a2a845aaf13a3cf5b9441049d49f8d6e6d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b9a2860d28526f466b6e6e11bb42555e00876a7","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelve\u0027: {}})"},{"line_number":282,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":283,"context_line":"                                    expected_status\u003d\u0027SHELVED\u0027)"},{"line_number":284,"context_line":"        self.flags(shelved_offload_time\u003d0)"},{"line_number":285,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":286,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":287,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_5620e549","line":284,"updated":"2016-10-21 01:36:17.000000000","message":"You don\u0027t need this is you\u0027re going to manually offload the shelved server below.","commit_id":"a6456a2a845aaf13a3cf5b9441049d49f8d6e6d5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d46c01f7e65ac6e42cbc13730004341e8a9ffd75","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelve\u0027: {}})"},{"line_number":282,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":283,"context_line":"                                    expected_status\u003d\u0027SHELVED\u0027)"},{"line_number":284,"context_line":"        self.flags(shelved_offload_time\u003d0)"},{"line_number":285,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":286,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":287,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_66460925","line":284,"in_reply_to":"da6895a0_5620e549","updated":"2016-10-21 10:41:14.000000000","message":"+1","commit_id":"a6456a2a845aaf13a3cf5b9441049d49f8d6e6d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b9a2860d28526f466b6e6e11bb42555e00876a7","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":283,"context_line":"                                    expected_status\u003d\u0027SHELVED\u0027)"},{"line_number":284,"context_line":"        self.flags(shelved_offload_time\u003d0)"},{"line_number":285,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027shelveOffload\u0027: {}})"},{"line_number":286,"context_line":"        self._wait_for_state_change(self.api, server,"},{"line_number":287,"context_line":"                                    expected_status\u003d\u0027SHELVED_OFFLOADED\u0027)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da6895a0_f63019a1","line":285,"updated":"2016-10-21 01:36:17.000000000","message":"Oh I guess it\u0027s because you are manually offloading the shelved instance.","commit_id":"a6456a2a845aaf13a3cf5b9441049d49f8d6e6d5"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2413daf97a7906dcc6f835862688bcdfcecef343","unresolved":false,"context_lines":[{"line_number":259,"context_line":"notification_object_data \u003d {"},{"line_number":260,"context_line":"    \u0027AuditPeriodPayload\u0027: \u00271.0-28345f72ca9d805eeb61b2c2385805dd\u0027,"},{"line_number":261,"context_line":"    \u0027BandwidthPayload\u0027: \u00271.0-49278639296f9939ff2c8947b2078a82\u0027,"},{"line_number":262,"context_line":"    \u0027EventType\u0027: \u00271.3-905c718d653eca4c3ddd46a72c394a39\u0027,"},{"line_number":263,"context_line":"    \u0027ExceptionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":264,"context_line":"    \u0027ExceptionPayload\u0027: \u00271.0-4516ae282a55fe2fd5c754967ee6248b\u0027,"},{"line_number":265,"context_line":"    \u0027FlavorPayload\u0027: \u00271.0-8ad962ab0bafc7270f474c7dda0b7c20\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_b4498bb9","line":262,"updated":"2016-10-14 10:49:13.000000000","message":"I think this is against the rule. We have to bump the EventType if a new possible enum value is added.","commit_id":"622d95fab7cfea5f643de98af54aebd189d8304d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b48f93d84dfdecf97bbad8de81d7bb7da4af876e","unresolved":false,"context_lines":[{"line_number":259,"context_line":"notification_object_data \u003d {"},{"line_number":260,"context_line":"    \u0027AuditPeriodPayload\u0027: \u00271.0-28345f72ca9d805eeb61b2c2385805dd\u0027,"},{"line_number":261,"context_line":"    \u0027BandwidthPayload\u0027: \u00271.0-49278639296f9939ff2c8947b2078a82\u0027,"},{"line_number":262,"context_line":"    \u0027EventType\u0027: \u00271.3-905c718d653eca4c3ddd46a72c394a39\u0027,"},{"line_number":263,"context_line":"    \u0027ExceptionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":264,"context_line":"    \u0027ExceptionPayload\u0027: \u00271.0-4516ae282a55fe2fd5c754967ee6248b\u0027,"},{"line_number":265,"context_line":"    \u0027FlavorPayload\u0027: \u00271.0-8ad962ab0bafc7270f474c7dda0b7c20\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_07403c33","line":262,"in_reply_to":"fa6399be_b4498bb9","updated":"2016-10-14 15:17:57.000000000","message":"I made a change where I pre-added the needed NotificationAction values so that we avoid merge conflict with each other bumping the version. Please rebase your change top of https://review.openstack.org/#/c/386659/","commit_id":"622d95fab7cfea5f643de98af54aebd189d8304d"}]}