)]}'
{"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"159c89ffb05e105da1aae544ff214e41da4db564","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        servers \u003d res_dict[\u0027servers\u0027]"},{"line_number":563,"context_line":"        self.assertEqual([s[\u0027id\u0027] for s in servers],"},{"line_number":564,"context_line":"                [getattr(uuids, str(i)) for i in range(len(servers))])"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        servers_links \u003d res_dict[\u0027servers_links\u0027]"},{"line_number":567,"context_line":"        self.assertEqual(servers_links[0][\u0027rel\u0027], \u0027next\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_5c6ef195","line":564,"range":{"start_line":564,"start_character":17,"end_line":564,"end_character":38},"updated":"2016-11-16 15:18:56.000000000","message":"I imagine if you didn\u0027t use purely-numerical names, you wouldn\u0027t need to use getattr below. Something like:\n\n    [getattr(uuids, \u0027var\u0027 + str(i))]\n\n?","commit_id":"13b08d99fed64228969881752457ec95d7cf2b9f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"159c89ffb05e105da1aae544ff214e41da4db564","unresolved":false,"context_lines":[{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        servers \u003d res[\u0027servers\u0027]"},{"line_number":600,"context_line":"        self.assertEqual([s[\u0027id\u0027] for s in servers],"},{"line_number":601,"context_line":"                [getattr(uuids, str(i)) for i in range(len(servers))])"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        servers_links \u003d res[\u0027servers_links\u0027]"},{"line_number":604,"context_line":"        self.assertEqual(servers_links[0][\u0027rel\u0027], \u0027next\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_9c06c9cc","line":601,"range":{"start_line":601,"start_character":0,"end_line":601,"end_character":70},"updated":"2016-11-16 15:18:56.000000000","message":"See above","commit_id":"13b08d99fed64228969881752457ec95d7cf2b9f"}],"nova/tests/unit/api/openstack/fakes.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c73b3365db02d0d86d667036ab818592a77a6f99","unresolved":false,"context_lines":[{"line_number":303,"context_line":"def get_fake_uuid(token\u003d0):"},{"line_number":304,"context_line":"    if token not in FAKE_UUIDS:"},{"line_number":305,"context_line":"        FAKE_UUIDS[token] \u003d uuidutils.generate_uuid()"},{"line_number":306,"context_line":"    return FAKE_UUIDS[token]"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"def fake_instance_get(**kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_5614964b","line":306,"updated":"2016-10-10 12:42:28.000000000","message":"so this whole function is escentially doing the same thing as the sentinel. Though in a bit less stable of a way. I would instead look at removing this entirely and reworking the tests that use this to use the sentinel.","commit_id":"77d53881a0159f8cf9f0d6c4105263a38523d9c7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"159c89ffb05e105da1aae544ff214e41da4db564","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def get_fake_uuid(token\u003d0):"},{"line_number":304,"context_line":"    if token not in FAKE_UUIDS:"},{"line_number":305,"context_line":"        FAKE_UUIDS[token] \u003d str(uuid.uuid4())"},{"line_number":306,"context_line":"    return FAKE_UUIDS[token]"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"def fake_instance_get(**kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_5c1c3112","side":"PARENT","line":306,"range":{"start_line":303,"start_character":0,"end_line":306,"end_character":28},"updated":"2016-11-16 15:18:56.000000000","message":"much better","commit_id":"b0d6ffe2bab03c40a0635751cf54b5f9ce1810df"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"159c89ffb05e105da1aae544ff214e41da4db564","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        with mock.patch.object(self.compute,"},{"line_number":472,"context_line":"                               \u0027_build_semaphore\u0027) as mock_sem:"},{"line_number":473,"context_line":"            instance \u003d objects.Instance(uuid\u003duuidutils.generate_uuid())"},{"line_number":474,"context_line":"            for i in (1, 2, 3):"},{"line_number":475,"context_line":"                self.compute.build_and_run_instance(self.context, instance,"},{"line_number":476,"context_line":"                                                    mock.sentinel.image,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_dcacc1a2","line":473,"range":{"start_line":473,"start_character":40,"end_line":473,"end_character":70},"updated":"2016-11-16 15:18:56.000000000","message":"Why is this not changed?","commit_id":"13b08d99fed64228969881752457ec95d7cf2b9f"}]}
