)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b9cc2c10c3cd5ef4691eba34014be44cd74ffd0","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    cfg.BoolOpt(\u0027snapshot_compression\u0027,"},{"line_number":549,"context_line":"                default\u003dFalse,"},{"line_number":550,"context_line":"                help\u003d\"\"\""},{"line_number":551,"context_line":"If enabled the snapshot images will be compressed."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_d25fa973","line":551,"range":{"start_line":551,"start_character":0,"end_line":551,"end_character":50},"updated":"2016-09-28 15:39:59.000000000","message":"Let\u0027s use active voice:\n\n    Enable snapshot compression.","commit_id":"8d4b5ee41c02997751853598c94be600837c16ed"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"62b5817adf27fa6f50ff5111b80f584f16b2e5e0","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"* snapshot_image_format - must be set to qcow2"},{"line_number":556,"context_line":"\"\"\"),"},{"line_number":557,"context_line":"]"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_9a9869c2","line":555,"updated":"2016-11-25 15:48:28.000000000","message":"I guees this is what you are trying to say: https://github.com/openstack/nova/blob/385b04c8cc9852b11125ee7a7eca3294b5720d41/nova/virt/libvirt/utils.py#L298\n\nI think its more accurate to say the setting is ignored if the snapshot format is not qcow2. Then you can add a note to say that you can set snapshot_image_format to force all snapshots to be in qcow2 format.","commit_id":"4ecdfefbd7789a3586bbb4206ab33e18f33960fc"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ed2aafa50b203d0adf331b71008056f645c47ed0","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"* snapshot_image_format - must be set to qcow2"},{"line_number":556,"context_line":"\"\"\"),"},{"line_number":557,"context_line":"]"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_b9b369e8","line":555,"in_reply_to":"5a74a57a_9a9869c2","updated":"2016-11-25 20:45:13.000000000","message":"Done","commit_id":"4ecdfefbd7789a3586bbb4206ab33e18f33960fc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c359216c97e2a0ee5873f4134bf8947bb54fb52","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                help\u003d\"\"\""},{"line_number":551,"context_line":"Enable snapshot compression."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"This option is ignored if the ``snapshot_image_format`` is not set to"},{"line_number":554,"context_line":"``qcow2``."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Note: you can set ``snapshot_image_format`` to ``qcow2`` to force all"},{"line_number":557,"context_line":"snapshots to be in ``qcow2`` format, independently from their original image"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_535c924a","line":554,"range":{"start_line":553,"start_character":0,"end_line":554,"end_character":10},"updated":"2016-11-29 12:41:49.000000000","message":"I believe this works whenever the snapshot is qcow2.\n\nYou only need to set snapshot_image_format \u003d qcow2 if you want *all* snapshots to be compressed.","commit_id":"7fd150146f51d573ad2d29cef7fbc4f356cf23dc"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8352db3782112d915ad7c90fc791bb56b797f4fb","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                help\u003d\"\"\""},{"line_number":551,"context_line":"Enable snapshot compression."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"This option is ignored if the ``snapshot_image_format`` is not set to"},{"line_number":554,"context_line":"``qcow2``."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Note: you can set ``snapshot_image_format`` to ``qcow2`` to force all"},{"line_number":557,"context_line":"snapshots to be in ``qcow2`` format, independently from their original image"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_97c9ad28","line":554,"range":{"start_line":553,"start_character":0,"end_line":554,"end_character":10},"in_reply_to":"5a74a57a_535c924a","updated":"2016-11-29 15:19:21.000000000","message":"Oh right. Enabling compression for qcow2 is optional, and is done in other formats independently. Got it. Somehow my brain got stuck on the if condition in nova/virt/libvirt/utils.py:288\n\nMaybe this option should be renamed to ``qcow2_snapshot_compression`` ?","commit_id":"7fd150146f51d573ad2d29cef7fbc4f356cf23dc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f37f7d38ea8f28d332850b30a5d8e53938719e83","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                help\u003d\"\"\""},{"line_number":551,"context_line":"Enable snapshot compression."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"This option is ignored if the ``snapshot_image_format`` is not set to"},{"line_number":554,"context_line":"``qcow2``."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Note: you can set ``snapshot_image_format`` to ``qcow2`` to force all"},{"line_number":557,"context_line":"snapshots to be in ``qcow2`` format, independently from their original image"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_85cf85af","line":554,"range":{"start_line":553,"start_character":0,"end_line":554,"end_character":10},"in_reply_to":"5a74a57a_97c9ad28","updated":"2016-12-13 12:01:42.000000000","message":"I think its more this is only partially implemented at the moment, which is fine.","commit_id":"7fd150146f51d573ad2d29cef7fbc4f356cf23dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b183a0fe2ce836c1cbc6fe32d931d89a803a876","unresolved":false,"context_lines":[{"line_number":545,"context_line":"]"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"libvirt_utils_opts \u003d ["},{"line_number":548,"context_line":"    cfg.BoolOpt(\u0027snapshot_compression\u0027,"},{"line_number":549,"context_line":"                default\u003dFalse,"},{"line_number":550,"context_line":"                help\u003d\"\"\""},{"line_number":551,"context_line":"Enable snapshot compression for ``qcow2`` images."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_d47a3f76","line":548,"updated":"2016-12-17 16:13:54.000000000","message":"Huh, this option is not actually tested anywhere in nova, i.e. there is no test that sets snapshot_compression\u003dTrue in a test and makes sure it\u0027s used. That\u0027s fun.","commit_id":"ada71553ffd1f9d70249e55ddf1fee156e0b9080"}]}