)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1daac3c2260682dd095e7262ca0fc54f7011bb5","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            if FLAGS.enable_instance_password:"},{"line_number":788,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d password"},{"line_number":789,"context_line":"            else:"},{"line_number":790,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d \u0027adminPass ignored\u0027"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        robj \u003d wsgi.ResponseObject(server)"},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2BvA%3D","line":790,"updated":"2012-02-04 02:18:49.000000000","message":"The value returned when instance passwords are not enabled should be stored in a constant that is used everywhere (in code and in tests).  This should be true regardless of whether a value or None is returned.","commit_id":"f134d3d55205f97144c83b8ff5adc1dacffa705d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"17f34de20d6d9362c8a71c4297cb62142f048cc5","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            if FLAGS.enable_instance_password:"},{"line_number":788,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d password"},{"line_number":789,"context_line":"            else:"},{"line_number":790,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d None"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        robj \u003d wsgi.ResponseObject(server)"},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2Buo%3D","line":790,"updated":"2012-02-04 02:22:58.000000000","message":"The value returned when instance passwords are not enabled should be stored in a constant that is used everywhere (in code and in tests). This should be true regardless of whether a value or None is returned.","commit_id":"83c31472463ef64c40b395f806ecbccf166c52ce"},{"author":{"_account_id":1419,"name":"Mike Pittaro","email":"mikeyp@LaHondaResearch.org","username":"mikeyp-3"},"change_message_id":"b127675665fac7858d671cc2501694153e78bb9e","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            if FLAGS.enable_instance_password:"},{"line_number":788,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d password"},{"line_number":789,"context_line":"            else:"},{"line_number":790,"context_line":"                server[\u0027server\u0027][\u0027adminPass\u0027] \u003d None"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        robj \u003d wsgi.ResponseObject(server)"},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BuE%3D","line":790,"in_reply_to":"AAAAEn%2F%2F%2Buo%3D","updated":"2012-02-04 02:37:54.000000000","message":"I\u0027m in agreement, just wasn\u0027t sure where it should go in the code tree - is there something already in place ?","commit_id":"83c31472463ef64c40b395f806ecbccf166c52ce"}],"nova/tests/api/openstack/compute/contrib/test_volumes.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8ec453d6f2a94e2e931a06136f8819251bdbd5a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":36,"context_line":"IMAGE_UUID \u003d \u0027c905cedb-7281-47e4-8a62-f26bc5fc4c77\u0027"},{"line_number":37,"context_line":"PW_IGNORED \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def fake_compute_api_create(cls, context, instance_type, image_href, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2Bs0%3D","line":37,"updated":"2012-02-04 05:39:57.000000000","message":"Looks like this isn\u0027t needed anymore","commit_id":"2aeec418f805622c7a87ec757aaf3693a8c83044"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e896ed8205244c7c463dc8e493eb1cf88402eb24","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(BootFromVolumeTest, self).setUp()"},{"line_number":65,"context_line":"        self.flags(enable_instance_password\u003dTrue)"},{"line_number":66,"context_line":"        self.stubs.Set(nova.compute.API, \u0027create\u0027, fake_compute_api_create)"},{"line_number":67,"context_line":"        fakes.stub_out_nw_api(self.stubs)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F90o%3D","line":65,"updated":"2012-02-07 23:38:46.000000000","message":"this is the default so you don\u0027t need to set it","commit_id":"a4046149541615ee595601cc3c71184f88a39376"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e896ed8205244c7c463dc8e493eb1cf88402eb24","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":91,"context_line":"            self.assertEqual(FLAGS.password_length, len(server[\u0027adminPass\u0027]))"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            self.assertTrue(\u0027adminPass\u0027 not in server)"},{"line_number":94,"context_line":"        self.assertEqual(len(_block_device_mapping_seen), 1)"},{"line_number":95,"context_line":"        self.assertEqual(_block_device_mapping_seen[0][\u0027volume_id\u0027], 1)"},{"line_number":96,"context_line":"        self.assertEqual(_block_device_mapping_seen[0][\u0027device_name\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F90g%3D","line":93,"updated":"2012-02-07 23:38:46.000000000","message":"not necessary, we are checking this in plenty of places.","commit_id":"a4046149541615ee595601cc3c71184f88a39376"}],"nova/tests/api/openstack/compute/test_server_actions.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1daac3c2260682dd095e7262ca0fc54f7011bb5","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        body \u003d robj.obj"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":282,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":283,"context_line":"            self.assertEqual(len(body[\u0027server\u0027][\u0027adminPass\u0027]),"},{"line_number":284,"context_line":"                             FLAGS.password_length)"},{"line_number":285,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2Bu4%3D","line":282,"updated":"2012-02-04 02:18:49.000000000","message":"Will the value of FLAGS.enable_instance_password ever deviate from the default of True in testing?  My understanding of flags may be flawed, please correct me if I\u0027m wrong.\n\nShouldn\u0027t the entire test be executed once for each possible value of FLAGS.enable_instance_password to ensure proper coverage?  This applies to the other tests as well.","commit_id":"f134d3d55205f97144c83b8ff5adc1dacffa705d"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c4b0ed2392680dbb683fc05cbe4447e3ca6bbed5","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                             FLAGS.password_length)"},{"line_number":285,"context_line":"        else:"},{"line_number":286,"context_line":"            self.assertEqual(len(body[\u0027server\u0027][\u0027adminPass\u0027]),"},{"line_number":287,"context_line":"                             len(PW_IGNORED)) "},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        self.assertEqual(robj[\u0027location\u0027], self_href)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2Bxc%3D","line":287,"updated":"2012-02-04 00:42:25.000000000","message":"whitespace","commit_id":"f134d3d55205f97144c83b8ff5adc1dacffa705d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"17f34de20d6d9362c8a71c4297cb62142f048cc5","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        body \u003d robj.obj"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":282,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":283,"context_line":"            self.assertEqual(len(body[\u0027server\u0027][\u0027adminPass\u0027]),"},{"line_number":284,"context_line":"                             FLAGS.password_length)"},{"line_number":285,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2Buk%3D","line":282,"updated":"2012-02-04 02:22:58.000000000","message":"Will the value of FLAGS.enable_instance_password ever deviate from the default of True in testing? My understanding of flags may be flawed, please correct me if I\u0027m wrong.\nShouldn\u0027t the entire test be executed once for each possible value of FLAGS.enable_instance_password to ensure proper coverage? This applies to the other tests as well.","commit_id":"83c31472463ef64c40b395f806ecbccf166c52ce"},{"author":{"_account_id":1419,"name":"Mike Pittaro","email":"mikeyp@LaHondaResearch.org","username":"mikeyp-3"},"change_message_id":"b127675665fac7858d671cc2501694153e78bb9e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        body \u003d robj.obj"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":282,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":283,"context_line":"            self.assertEqual(len(body[\u0027server\u0027][\u0027adminPass\u0027]),"},{"line_number":284,"context_line":"                             FLAGS.password_length)"},{"line_number":285,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BuQ%3D","line":282,"in_reply_to":"AAAAEn%2F%2F%2Buk%3D","updated":"2012-02-04 02:37:54.000000000","message":"This is a good point - I need to find out the preferred method for this.  I ran both cases manually.","commit_id":"83c31472463ef64c40b395f806ecbccf166c52ce"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8ec453d6f2a94e2e931a06136f8819251bdbd5a5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        body \u003d robj.obj"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":281,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":282,"context_line":"            self.assertEqual(len(body[\u0027server\u0027][\u0027adminPass\u0027]),"},{"line_number":283,"context_line":"                             FLAGS.password_length)"},{"line_number":284,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2Bsw%3D","line":281,"updated":"2012-02-04 05:39:57.000000000","message":"this doesn\u0027t reeally work, since the flags always set one way.  You could just assume they are true and then copy the test and do a self.flags(enable_instance_password\u003dFalse)\nto verify the other way.","commit_id":"2aeec418f805622c7a87ec757aaf3693a8c83044"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8ec453d6f2a94e2e931a06136f8819251bdbd5a5","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":397,"context_line":"            self.assertEqual(body[\u0027server\u0027][\u0027adminPass\u0027], \u0027asdf\u0027)"},{"line_number":398,"context_line":"        else:"},{"line_number":399,"context_line":"            self.assertTrue(\"adminPass\" not in body[\u0027server\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_rebuild_server_not_found(self):"},{"line_number":402,"context_line":"        def server_not_found(self, instance_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2Bss%3D","line":399,"updated":"2012-02-04 05:39:57.000000000","message":"same as above.","commit_id":"2aeec418f805622c7a87ec757aaf3693a8c83044"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c4b0ed2392680dbb683fc05cbe4447e3ca6bbed5","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"        \"\"\" utility - check adminPass length "},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"        factored out because behavior changes with "},{"line_number":1483,"context_line":"        config flag.  See bug 921814 "},{"line_number":1484,"context_line":"        \"\"\""},{"line_number":1485,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":1486,"context_line":"            self.assertEqual(FLAGS.password_length, len(adminPass))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2BxY%3D","line":1483,"updated":"2012-02-04 00:42:25.000000000","message":"more whitespace","commit_id":"f134d3d55205f97144c83b8ff5adc1dacffa705d"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8ec453d6f2a94e2e931a06136f8819251bdbd5a5","unresolved":false,"context_lines":[{"line_number":1485,"context_line":"            self.assertEqual(FLAGS.password_length,"},{"line_number":1486,"context_line":"                             len(server_dict[\"adminPass\"]))"},{"line_number":1487,"context_line":"        else:"},{"line_number":1488,"context_line":"            self.assertTrue(\"adminPass\" not in server_dict)"},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"    def _test_create_instance(self):"},{"line_number":1491,"context_line":"        image_uuid \u003d \u0027c905cedb-7281-47e4-8a62-f26bc5fc4c77\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2Bsk%3D","line":1488,"updated":"2012-02-04 05:39:57.000000000","message":"same comment","commit_id":"2aeec418f805622c7a87ec757aaf3693a8c83044"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8ec453d6f2a94e2e931a06136f8819251bdbd5a5","unresolved":false,"context_lines":[{"line_number":2056,"context_line":"        if FLAGS.enable_instance_password:"},{"line_number":2057,"context_line":"            self.assertEqual(server[\u0027adminPass\u0027], body[\u0027server\u0027][\u0027adminPass\u0027])"},{"line_number":2058,"context_line":"        else:"},{"line_number":2059,"context_line":"            self.assertTrue(\u0027adminPass\u0027 not in server)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"    def test_create_instance_admin_pass_empty(self):"},{"line_number":2062,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2Bso%3D","line":2059,"updated":"2012-02-04 05:39:57.000000000","message":"same as other file","commit_id":"2aeec418f805622c7a87ec757aaf3693a8c83044"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"a434d8ddc38a3bdd5039f239eaffd1a70d779a47","unresolved":false,"context_lines":[{"line_number":2120,"context_line":"        self.assertEqual(robj[\u0027Location\u0027], selfhref)"},{"line_number":2121,"context_line":""},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"class ServersControllerCreateTestNoInstPw(ServersControllerCreateTest):"},{"line_number":2124,"context_line":"    \"\"\"rerun ServersControllerCreateTest tests with"},{"line_number":2125,"context_line":"    enable_instance_password set to False."},{"line_number":2126,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F%2BSk%3D","line":2123,"updated":"2012-02-06 23:07:33.000000000","message":"I\u0027m really not a fan of reusing TestCase classes for this purpose. It\u0027s much more succinct to write a few specific tests for this behavior.","commit_id":"709296fff9e3a6978fe2dc6874e7cff31a8eb0ee"},{"author":{"_account_id":1419,"name":"Mike Pittaro","email":"mikeyp@LaHondaResearch.org","username":"mikeyp-3"},"change_message_id":"451968be440876b194fb108afe8c3e04d18e863b","unresolved":false,"context_lines":[{"line_number":2120,"context_line":"        self.assertEqual(robj[\u0027Location\u0027], selfhref)"},{"line_number":2121,"context_line":""},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"class ServersControllerCreateTestNoInstPw(ServersControllerCreateTest):"},{"line_number":2124,"context_line":"    \"\"\"rerun ServersControllerCreateTest tests with"},{"line_number":2125,"context_line":"    enable_instance_password set to False."},{"line_number":2126,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F92c%3D","line":2123,"in_reply_to":"AAAAEn%2F%2F%2BSk%3D","updated":"2012-02-07 23:12:00.000000000","message":"Done","commit_id":"709296fff9e3a6978fe2dc6874e7cff31a8eb0ee"}]}