)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d63329f7bc32761e999a3bbd5525f184cbe22f45","unresolved":false,"context_lines":[{"line_number":826,"context_line":"        print(migration.db_version())"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    @args(\u0027--max_rows\u0027, metavar\u003d\u0027\u003cnumber\u003e\u0027,"},{"line_number":829,"context_line":"            help\u003d\u0027Maximum number of deleted rows to archive\u0027)"},{"line_number":830,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":831,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":832,"context_line":"    def archive_deleted_rows(self, max_rows\u003dNone, verbose\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_762fb0a1","line":829,"updated":"2016-09-28 14:09:36.000000000","message":"You\u0027d want to update this help for the None option now (and fix the alignment when you do :) ).","commit_id":"d8f7c49ca468e483aed0ce356b872b5a09177118"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bcfe2a8fce28a50b67aac5870b22eaac2da95143","unresolved":false,"context_lines":[{"line_number":826,"context_line":"        print(migration.db_version())"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    @args(\u0027--max_rows\u0027, metavar\u003d\u0027\u003cnumber\u003e\u0027,"},{"line_number":829,"context_line":"            help\u003d\u0027Maximum number of deleted rows to archive\u0027)"},{"line_number":830,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":831,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":832,"context_line":"    def archive_deleted_rows(self, max_rows\u003dNone, verbose\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_f8171ceb","line":829,"in_reply_to":"3a98d1f4_762fb0a1","updated":"2016-09-28 18:17:36.000000000","message":"I think this doesn\u0027t need to be changed because what I did is make --max_rows optional. If you don\u0027t specify it, it defaults to None which will be \"all rows.\"","commit_id":"d8f7c49ca468e483aed0ce356b872b5a09177118"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fa998ceba87b99977980cc3392f90e119448c2","unresolved":false,"context_lines":[{"line_number":829,"context_line":"            help\u003d\u0027Maximum number of deleted rows to archive\u0027)"},{"line_number":830,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":831,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":832,"context_line":"    def archive_deleted_rows(self, max_rows\u003dNone, verbose\u003dFalse):"},{"line_number":833,"context_line":"        \"\"\"Move up to max_rows deleted rows from production tables to shadow"},{"line_number":834,"context_line":"        tables."},{"line_number":835,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_fe033d40","line":832,"updated":"2016-09-29 20:30:47.000000000","message":"The thing I don\u0027t like about this approach is that it can only do all rows in a table in a single query. That means (a) it can\u0027t be interrupted and have made partial progress and (b) I would think that it would choke on sufficiently large datasets.","commit_id":"df77c9167c1c6744cc018b2c05e79f9631b664ab"}]}