)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6f3d12d21c3c2d2add8f596be510a1f87cb1a30","unresolved":false,"context_lines":[{"line_number":539,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":540,"context_line":"               choices\u003d(\u0027none\u0027, \u0027zero\u0027, \u0027shred\u0027),"},{"line_number":541,"context_line":"               help\u003d\"\"\""},{"line_number":542,"context_line":"Method used to wipe volumes when they are deleted."},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Possible values:"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_9d0cde3c","line":542,"range":{"start_line":542,"start_character":20,"end_line":542,"end_character":27},"updated":"2016-11-25 17:33:38.000000000","message":"Nit: this is slightly confusing, its really ephemeral disks, assuming you are using LVM as the backing storage.\n\nThis in no way relates to Cinder volumes.","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3bc32d140fe9820566558ce600ff26aa2858c87e","unresolved":false,"context_lines":[{"line_number":539,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":540,"context_line":"               choices\u003d(\u0027none\u0027, \u0027zero\u0027, \u0027shred\u0027),"},{"line_number":541,"context_line":"               help\u003d\"\"\""},{"line_number":542,"context_line":"Method used to wipe volumes when they are deleted."},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Possible values:"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_f9f7a188","line":542,"range":{"start_line":542,"start_character":20,"end_line":542,"end_character":27},"in_reply_to":"5a74a57a_9d0cde3c","updated":"2016-11-25 21:32:39.000000000","message":"Done","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6f3d12d21c3c2d2add8f596be510a1f87cb1a30","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"Related options:"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"* volume_clear_size"},{"line_number":553,"context_line":"\"\"\"),"},{"line_number":554,"context_line":"    cfg.IntOpt(\u0027volume_clear_size\u0027,"},{"line_number":555,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_bdc6fa97","line":552,"updated":"2016-11-25 17:33:38.000000000","message":"I think you need to be using LVM as the backing store for the ephemeral disks, i.e. images_type\u003dlvm for this to do anything, we should probably mention that.","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3bc32d140fe9820566558ce600ff26aa2858c87e","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"Related options:"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"* volume_clear_size"},{"line_number":553,"context_line":"\"\"\"),"},{"line_number":554,"context_line":"    cfg.IntOpt(\u0027volume_clear_size\u0027,"},{"line_number":555,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_19f1bd95","line":552,"in_reply_to":"5a74a57a_bdc6fa97","updated":"2016-11-25 21:32:39.000000000","message":"Done","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6f3d12d21c3c2d2add8f596be510a1f87cb1a30","unresolved":false,"context_lines":[{"line_number":555,"context_line":"               default\u003d0,"},{"line_number":556,"context_line":"               min\u003d0,"},{"line_number":557,"context_line":"               help\u003d\"\"\""},{"line_number":558,"context_line":"Size in MiB to wipe at start of old volumes."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"Related options:"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_9dae9e96","line":558,"updated":"2016-11-25 17:33:38.000000000","message":"This isn\u0027t clear to me.\n\nHere is the code:\nhttps://github.com/openstack/nova/blob/02576d02375d5abaa3bba88f335e631b960a0c88/nova/virt/libvirt/storage/lvm.py#L208\n\nif volume_clear_size \u003d\u003d 0, then the whole volume is cleaned.\n\nIf volume_clear_size \u003e 0 then a maximum of the first volume_clear_size MiB\u0027s will be cleaned, I believe.","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3bc32d140fe9820566558ce600ff26aa2858c87e","unresolved":false,"context_lines":[{"line_number":555,"context_line":"               default\u003d0,"},{"line_number":556,"context_line":"               min\u003d0,"},{"line_number":557,"context_line":"               help\u003d\"\"\""},{"line_number":558,"context_line":"Size in MiB to wipe at start of old volumes."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"Related options:"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_3954b91f","line":558,"in_reply_to":"5a74a57a_9dae9e96","updated":"2016-11-25 21:32:39.000000000","message":"Missread the code, Done","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6f3d12d21c3c2d2add8f596be510a1f87cb1a30","unresolved":false,"context_lines":[{"line_number":560,"context_line":"Related options:"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* volume_clear - must be set and the value must be different than ``none``"},{"line_number":563,"context_line":"  for this option to have any impact"},{"line_number":564,"context_line":"\"\"\"),"},{"line_number":565,"context_line":"]"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_fdbcf207","line":563,"updated":"2016-11-25 17:33:38.000000000","message":"As above.","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3bc32d140fe9820566558ce600ff26aa2858c87e","unresolved":false,"context_lines":[{"line_number":560,"context_line":"Related options:"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* volume_clear - must be set and the value must be different than ``none``"},{"line_number":563,"context_line":"  for this option to have any impact"},{"line_number":564,"context_line":"\"\"\"),"},{"line_number":565,"context_line":"]"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_7c061f1e","line":563,"in_reply_to":"5a74a57a_fdbcf207","updated":"2016-11-25 21:32:39.000000000","message":"Done","commit_id":"bc07ffbae06576ea6be362b93842a7534f17b620"}]}