)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d7b299e8bbbdb65722de352b1ee50bf1732f053","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Remove libvirt imagecache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config options related to imagecache should be removed. However, it is"},{"line_number":10,"context_line":"not currently entirely possible due to the upgrade issue - if someone is"},{"line_number":11,"context_line":"doing a leap frog upgrades and would not run Ocata for a longer period"},{"line_number":12,"context_line":"of time there is high probability that imagecache files will still be"},{"line_number":13,"context_line":"around after the upgrade."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Removes ``checksum_base_images`` and ``checksum_interval_seconds``, and"},{"line_number":16,"context_line":"set the default value of ``remove_unused_resized_minumum_age_seconds``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f1d235d_26819f90","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":25},"updated":"2017-07-01 12:49:00.000000000","message":"FWIW, Nova doesn\u0027t support skip-level upgrades and never has.","commit_id":"7945e5b788f1bb26483078c5eedab1230ee5b49b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9240c19e490a9427e4696c12c9beb5c5dcf2977b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Remove libvirt imagecache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config options related to imagecache should be removed. However, it is"},{"line_number":10,"context_line":"not currently entirely possible due to the upgrade issue - if someone is"},{"line_number":11,"context_line":"doing a leap frog upgrades and would not run Ocata for a longer period"},{"line_number":12,"context_line":"of time there is high probability that imagecache files will still be"},{"line_number":13,"context_line":"around after the upgrade."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Removes ``checksum_base_images`` and ``checksum_interval_seconds``, and"},{"line_number":16,"context_line":"set the default value of ``remove_unused_resized_minumum_age_seconds``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f1d235d_2048fc59","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":25},"in_reply_to":"3f1d235d_26819f90","updated":"2017-07-05 16:39:45.000000000","message":"What if I skip from Ocata to Queens and missed this? Don\u0027t I have the same problem? What is the impact of just dropping the config deprecated config options - that\u0027s not clear here. Is it just that the files stay on local disk in the image cache and aren\u0027t automatically cleaned up? If so, couldn\u0027t we just put something in the release notes that auto-cleanup of image cache files no longer happens so on upgrade you need to purge anything local, and maybe provide some hints on how to look for those files?","commit_id":"7945e5b788f1bb26483078c5eedab1230ee5b49b"}],"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2a65371a1f98ee25f08d596eae290e8606670d26","unresolved":false,"context_lines":[{"line_number":501,"context_line":"]"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"libvirt_imagecache_opts \u003d ["},{"line_number":504,"context_line":"    cfg.StrOpt(\u0027image_info_filename_pattern\u0027,"},{"line_number":505,"context_line":"               default\u003d\u0027$instances_path/$image_cache_subdirectory_name/\u0027"},{"line_number":506,"context_line":"                       \u0027%(image)s.info\u0027,"},{"line_number":507,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":508,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":509,"context_line":"               deprecated_reason\u003d\"\"\""},{"line_number":510,"context_line":"Image info files are no longer used by the image cache."},{"line_number":511,"context_line":"\"\"\","},{"line_number":512,"context_line":"               help\u003d\"\"\""},{"line_number":513,"context_line":"Allows image information files to be stored in non-standard locations."},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"Related options:"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"* compute.instances_path"},{"line_number":518,"context_line":"* virt.image_cache_subdirectory_name"},{"line_number":519,"context_line":"\"\"\"),"},{"line_number":520,"context_line":"    cfg.IntOpt(\u0027remove_unused_resized_minimum_age_seconds\u0027,"},{"line_number":521,"context_line":"               default\u003d3600,"},{"line_number":522,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_4d30409f","line":519,"range":{"start_line":504,"start_character":0,"end_line":519,"end_character":5},"updated":"2016-09-28 11:12:34.000000000","message":"Can you just remove these options instead?","commit_id":"f3ca636e131b33095f9a8a5ae99f9d17091c81a4"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3a2e3a765e2a35931bf4879455d2d321ed474063","unresolved":false,"context_lines":[{"line_number":501,"context_line":"]"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"libvirt_imagecache_opts \u003d ["},{"line_number":504,"context_line":"    cfg.StrOpt(\u0027image_info_filename_pattern\u0027,"},{"line_number":505,"context_line":"               default\u003d\u0027$instances_path/$image_cache_subdirectory_name/\u0027"},{"line_number":506,"context_line":"                       \u0027%(image)s.info\u0027,"},{"line_number":507,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":508,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":509,"context_line":"               deprecated_reason\u003d\"\"\""},{"line_number":510,"context_line":"Image info files are no longer used by the image cache."},{"line_number":511,"context_line":"\"\"\","},{"line_number":512,"context_line":"               help\u003d\"\"\""},{"line_number":513,"context_line":"Allows image information files to be stored in non-standard locations."},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"Related options:"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"* compute.instances_path"},{"line_number":518,"context_line":"* virt.image_cache_subdirectory_name"},{"line_number":519,"context_line":"\"\"\"),"},{"line_number":520,"context_line":"    cfg.IntOpt(\u0027remove_unused_resized_minimum_age_seconds\u0027,"},{"line_number":521,"context_line":"               default\u003d3600,"},{"line_number":522,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_e5d06ccc","line":519,"range":{"start_line":504,"start_character":0,"end_line":519,"end_character":5},"in_reply_to":"5a8bc5a2_4d30409f","updated":"2016-09-28 13:24:55.000000000","message":"Isn\u0027t it to early to remove options deprecated @ 14?","commit_id":"f3ca636e131b33095f9a8a5ae99f9d17091c81a4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9465047bee6f669c146665618219d645dbd44f1e","unresolved":false,"context_lines":[{"line_number":619,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":620,"context_line":"               deprecated_reason\u003d\u0027\u0027\u0027"},{"line_number":621,"context_line":"Image info files are no longer used by the image cache, yet this option"},{"line_number":622,"context_line":"should exist until Ocata is released."},{"line_number":623,"context_line":"\u0027\u0027\u0027,"},{"line_number":624,"context_line":"               help\u003d\u0027Allows image information files to be stored in \u0027"},{"line_number":625,"context_line":"                    \u0027non-standard locations\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_62f04e68","line":622,"range":{"start_line":622,"start_character":13,"end_line":622,"end_character":36},"updated":"2017-02-07 15:28:40.000000000","message":"This is probably a bit specific, and an issue now we are in pike.\n\nMaybe reverse it. \"While image info files are no longer in use, keeping this around gives people another release of keeping the cleanup code that removes these unused files.\"\n\nHonestly, it might be fine just to have a release note telling operators they now have to manually delete these (given its pike now).","commit_id":"c0feac76d156d9521500e59d1a1ff008b021d6b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"07ee84166561d9d5e737ab20ca7879b822eb210f","unresolved":false,"context_lines":[{"line_number":619,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":620,"context_line":"               deprecated_reason\u003d\u0027\u0027\u0027"},{"line_number":621,"context_line":"Image info files are no longer used by the image cache, yet this option"},{"line_number":622,"context_line":"should exist until Ocata is released."},{"line_number":623,"context_line":"\u0027\u0027\u0027,"},{"line_number":624,"context_line":"               help\u003d\u0027Allows image information files to be stored in \u0027"},{"line_number":625,"context_line":"                    \u0027non-standard locations\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_179b0019","line":622,"range":{"start_line":622,"start_character":13,"end_line":622,"end_character":36},"in_reply_to":"1a430d35_62f04e68","updated":"2017-02-08 21:58:58.000000000","message":"What about having both? Or is the changed default below to invasive?","commit_id":"c0feac76d156d9521500e59d1a1ff008b021d6b9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9465047bee6f669c146665618219d645dbd44f1e","unresolved":false,"context_lines":[{"line_number":624,"context_line":"               help\u003d\u0027Allows image information files to be stored in \u0027"},{"line_number":625,"context_line":"                    \u0027non-standard locations\u0027),"},{"line_number":626,"context_line":"    cfg.IntOpt(\u0027remove_unused_resized_minimum_age_seconds\u0027,"},{"line_number":627,"context_line":"               default\u003d0,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Remove resized base images that are older than provided time in seconds."},{"line_number":630,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_829c5a10","line":627,"range":{"start_line":627,"start_character":1,"end_line":627,"end_character":25},"updated":"2017-02-07 15:28:40.000000000","message":"If we going to no longer use this setting, should we also deprecate it?","commit_id":"c0feac76d156d9521500e59d1a1ff008b021d6b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"07ee84166561d9d5e737ab20ca7879b822eb210f","unresolved":false,"context_lines":[{"line_number":624,"context_line":"               help\u003d\u0027Allows image information files to be stored in \u0027"},{"line_number":625,"context_line":"                    \u0027non-standard locations\u0027),"},{"line_number":626,"context_line":"    cfg.IntOpt(\u0027remove_unused_resized_minimum_age_seconds\u0027,"},{"line_number":627,"context_line":"               default\u003d0,"},{"line_number":628,"context_line":"               help\u003d\"\"\""},{"line_number":629,"context_line":"Remove resized base images that are older than provided time in seconds."},{"line_number":630,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_379e3c07","line":627,"range":{"start_line":627,"start_character":1,"end_line":627,"end_character":25},"in_reply_to":"1a430d35_829c5a10","updated":"2017-02-08 21:58:58.000000000","message":"Done","commit_id":"c0feac76d156d9521500e59d1a1ff008b021d6b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df3296771521a5a9841425f6eadf7fedc7c1fa96","unresolved":false,"context_lines":[{"line_number":627,"context_line":"               default\u003d0,"},{"line_number":628,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":629,"context_line":"               deprecated_since\u003d\u002716.0.0\u0027,"},{"line_number":630,"context_line":"               deprecated_reason\u003d\u0027\u0027\u0027"},{"line_number":631,"context_line":"While image info files are no longer in use, keeping this around gives people"},{"line_number":632,"context_line":"another release of keeping the cleanup code that removes these unused files."},{"line_number":633,"context_line":"\u0027\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a430d35_2a394ad9","line":630,"range":{"start_line":630,"start_character":33,"end_line":630,"end_character":36},"updated":"2017-02-09 17:29:31.000000000","message":"nit: could you use \"\"\" instead, per the \u0027help\u0027 option?","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"cb03ef45418af612fef2774d155ca25a5b4b543a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"               default\u003d0,"},{"line_number":628,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":629,"context_line":"               deprecated_since\u003d\u002716.0.0\u0027,"},{"line_number":630,"context_line":"               deprecated_reason\u003d\u0027\u0027\u0027"},{"line_number":631,"context_line":"While image info files are no longer in use, keeping this around gives people"},{"line_number":632,"context_line":"another release of keeping the cleanup code that removes these unused files."},{"line_number":633,"context_line":"\u0027\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa31d9ce_c902740b","line":630,"range":{"start_line":630,"start_character":33,"end_line":630,"end_character":36},"in_reply_to":"1a430d35_2a394ad9","updated":"2017-02-16 19:56:57.000000000","message":"+1","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"057c5550e339facf02217addb0ce1007b0881ebc","unresolved":false,"context_lines":[{"line_number":627,"context_line":"               default\u003d0,"},{"line_number":628,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":629,"context_line":"               deprecated_since\u003d\u002716.0.0\u0027,"},{"line_number":630,"context_line":"               deprecated_reason\u003d\u0027\u0027\u0027"},{"line_number":631,"context_line":"While image info files are no longer in use, keeping this around gives people"},{"line_number":632,"context_line":"another release of keeping the cleanup code that removes these unused files."},{"line_number":633,"context_line":"\u0027\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ffe62b97_a8bd1bd9","line":630,"range":{"start_line":630,"start_character":33,"end_line":630,"end_character":36},"in_reply_to":"fa31d9ce_c902740b","updated":"2017-03-28 14:09:13.000000000","message":"Done","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9240c19e490a9427e4696c12c9beb5c5dcf2977b","unresolved":false,"context_lines":[{"line_number":674,"context_line":"]"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"libvirt_imagecache_opts \u003d ["},{"line_number":677,"context_line":"    cfg.StrOpt(\u0027image_info_filename_pattern\u0027,"},{"line_number":678,"context_line":"               default\u003d\u0027$instances_path/$image_cache_subdirectory_name/\u0027"},{"line_number":679,"context_line":"                       \u0027%(image)s.info\u0027,"},{"line_number":680,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_c08a6868","line":677,"range":{"start_line":677,"start_character":16,"end_line":677,"end_character":43},"updated":"2017-07-05 16:39:45.000000000","message":"Is the issue with not being able to remove this because we aren\u0027t removing remove_unused_resized_minumum_age_seconds and remove_unused_resized_minumum_age_seconds depends on image_info_filename_pattern?","commit_id":"7945e5b788f1bb26483078c5eedab1230ee5b49b"}],"nova/tests/unit/virt/libvirt/test_imagecache.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9465047bee6f669c146665618219d645dbd44f1e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def test_list_base_images(self):"},{"line_number":98,"context_line":"        listing \u003d [\u002700000001\u0027,"},{"line_number":99,"context_line":"                   \u0027ephemeral_0_20_None\u0027,"},{"line_number":100,"context_line":"                   \u002717d1b00b81642842e514494a78e804e9a511637c_5368709120.info\u0027,"},{"line_number":101,"context_line":"                   \u002700000004\u0027,"},{"line_number":102,"context_line":"                   \u0027swap_1000\u0027]"},{"line_number":103,"context_line":"        images \u003d [\u0027e97222e91fc4241f49a7f520d1dcf446751129b3_sm\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_96149ba0","side":"PARENT","line":100,"updated":"2017-02-07 15:28:40.000000000","message":"We shouldn\u0027t delete the tests if we don\u0027t delete the code.","commit_id":"d92e56a99decfb645a8763c844542e26f1de83a8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"07ee84166561d9d5e737ab20ca7879b822eb210f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def test_list_base_images(self):"},{"line_number":98,"context_line":"        listing \u003d [\u002700000001\u0027,"},{"line_number":99,"context_line":"                   \u0027ephemeral_0_20_None\u0027,"},{"line_number":100,"context_line":"                   \u002717d1b00b81642842e514494a78e804e9a511637c_5368709120.info\u0027,"},{"line_number":101,"context_line":"                   \u002700000004\u0027,"},{"line_number":102,"context_line":"                   \u0027swap_1000\u0027]"},{"line_number":103,"context_line":"        images \u003d [\u0027e97222e91fc4241f49a7f520d1dcf446751129b3_sm\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_93b2a5e3","side":"PARENT","line":100,"in_reply_to":"1a430d35_96149ba0","updated":"2017-02-08 21:58:58.000000000","message":"I forgot to re-add this test. In previous PS related code was re-added.","commit_id":"d92e56a99decfb645a8763c844542e26f1de83a8"}],"releasenotes/notes/remove-deprecated-libvirt-imagecache-opts-0e784996fe12af8e.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5fd6f38f353c041e84002c4a5f68f45616a1f3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The config options ``image_info_filename_pattern``,"},{"line_number":4,"context_line":"    ``checksum_base_images`` and ``checksum_interval_seconds`` were"},{"line_number":5,"context_line":"    deprecated in Newton. Hence these options were completely removed in"},{"line_number":6,"context_line":"    Ocata as image info files are no longer used by the image cache and"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a95cdbc_8ced6ab9","line":3,"updated":"2016-10-07 15:58:47.000000000","message":"This needs to be written as below to make the reST parse:\n\n    - |\n      The config options...","commit_id":"b4fc7f2dca5798eab6a123ca226cf297e9259c81"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"69e2e380502267f621a7dd1a8723d14a073dd0ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The config options ``image_info_filename_pattern``,"},{"line_number":4,"context_line":"    ``checksum_base_images`` and ``checksum_interval_seconds`` were"},{"line_number":5,"context_line":"    deprecated in Newton. Hence these options were completely removed in"},{"line_number":6,"context_line":"    Ocata as image info files are no longer used by the image cache and"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a95cdbc_d4c26b84","line":3,"in_reply_to":"1a95cdbc_8ced6ab9","updated":"2016-10-10 08:43:43.000000000","message":"Done","commit_id":"b4fc7f2dca5798eab6a123ca226cf297e9259c81"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"cb03ef45418af612fef2774d155ca25a5b4b543a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``remove_unused_resized_minimum_age_seconds`` default value has been"},{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa31d9ce_8492219e","line":13,"range":{"start_line":13,"start_character":56,"end_line":13,"end_character":66},"updated":"2017-02-16 19:56:57.000000000","message":"Shouldn\u0027t this go under deprecated header?","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"057c5550e339facf02217addb0ce1007b0881ebc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``remove_unused_resized_minimum_age_seconds`` default value has been"},{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ffe62b97_880c97a5","line":13,"range":{"start_line":13,"start_character":56,"end_line":13,"end_character":66},"in_reply_to":"fa31d9ce_8492219e","updated":"2017-03-28 14:09:13.000000000","message":"We always did deprecations under the upgrade header.","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8fff4c155bb2d6a9b56b406b99eed10a7902c1a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``remove_unused_resized_minimum_age_seconds`` default value has been"},{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ffe62b97_d1291c8a","line":13,"range":{"start_line":13,"start_character":56,"end_line":13,"end_character":66},"in_reply_to":"ffe62b97_880c97a5","updated":"2017-04-03 15:02:59.000000000","message":"I doubt if this is true. Deprecated options should go under deprecated headers. renames and new cfg options are in upgrade section.","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5162655d105ece35d85a841d899588ddbf10a12","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``remove_unused_resized_minimum_age_seconds`` default value has been"},{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"bff0334d_8ff6c862","line":13,"range":{"start_line":13,"start_character":56,"end_line":13,"end_character":66},"in_reply_to":"ffe62b97_d1291c8a","updated":"2017-04-11 11:44:01.000000000","message":"Yeah, deprecations under the deprecated header. See\n\nhttps://github.com/openstack/nova/blob/master/releasenotes/notes/deprecate-barbican-config-options-68ae65643ac41e2f.yaml\nhttps://github.com/openstack/nova/blob/master/releasenotes/notes/deprecate-console_driver-opt-26475263aad3b655.yaml\nhttps://github.com/openstack/nova/blob/master/releasenotes/notes/deprecate-image-cache-checksumming-80e52279881ebc71.yaml\n...","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"cb03ef45418af612fef2774d155ca25a5b4b543a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Image info files are no longer in use and should be removed if any are left"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa31d9ce_44f749f5","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":22},"updated":"2017-02-16 19:56:57.000000000","message":"I will say \"in future release.\"","commit_id":"864766583ac4144004880cca2d08615b8b847a74"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5cd81994386d58d2a77d332092e615601d63e4d5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The config options ``checksum_base_images`` and"},{"line_number":5,"context_line":"    ``checksum_interval_seconds`` were deprecated in Newton. Hence these"},{"line_number":6,"context_line":"    options were completely removed in Pike as image info files are no"},{"line_number":7,"context_line":"    longer used by the image cache and the data integrity can be checked at"},{"line_number":8,"context_line":"    the block or filesystem level."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bff0334d_efa8b420","line":6,"range":{"start_line":5,"start_character":50,"end_line":6,"end_character":63},"updated":"2017-04-11 12:57:04.000000000","message":"in Newton and are now completely removed. Image info files...","commit_id":"0f42dfaa8e1283c8a5f065fc9083f59044c1b955"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5cd81994386d58d2a77d332092e615601d63e4d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``remove_unused_resized_minimum_age_seconds`` default value has been"},{"line_number":11,"context_line":"    changed from 3600 to 0. This should resolve the problem of leaving image"},{"line_number":12,"context_line":"    cache files in the upgrade process if Pike would not be run for a"},{"line_number":13,"context_line":"    longer period of time. This option is now marked as deprecated and will be"},{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Image info files are no longer in use and should be removed if any are left"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bff0334d_af64ec22","line":14,"range":{"start_line":13,"start_character":27,"end_line":14,"end_character":23},"updated":"2017-04-11 12:57:04.000000000","message":"Aye, this belongs in the deprecated section. Duplicate this information if you must","commit_id":"0f42dfaa8e1283c8a5f065fc9083f59044c1b955"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5cd81994386d58d2a77d332092e615601d63e4d5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    removed after Pike."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Image info files are no longer in use and should be removed if any are left"},{"line_number":18,"context_line":"    after the upgrade to Pike."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bff0334d_2f78dcc1","line":18,"range":{"start_line":17,"start_character":46,"end_line":18,"end_character":30},"updated":"2017-04-11 12:57:04.000000000","message":"How about:\n\n  will be automatically removed?\n\nshould be removed suggests the user must do something, which I\u0027m pretty sure is not the case?","commit_id":"0f42dfaa8e1283c8a5f065fc9083f59044c1b955"}]}