)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1b91eeda792e6f5799dd13be6eaac02ed6722b0c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As such, this is no longer a workaround so much as a configuration"},{"line_number":17,"context_line":"option. Move it to a more reasonable group, and rename so it\u0027s no longer"},{"line_number":18,"context_line":"a double negative."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I3bd92187cf3d077a45e0c030aba26a3515fd582d"},{"line_number":21,"context_line":"Co-Authored-By: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_ab31dca3","line":18,"updated":"2016-10-04 10:48:42.000000000","message":"I\u0027m not convinced we want to have a config parameter for this in libvirt. Originally the code was written such that it would always do a live snapshot if that was available if QEMU was new enough. IOW, once we raiased the min required QEMU beyond that version check, we would  ultimately be able to delete the non-live snapshot codepath.\n\nBy moving the config option into the libvirt group you\u0027re committing us to saying that non-live snapshot is a supported use case long term. I\u0027m not convinced we want todo that. As such I think we should either keep the config option the workarounds group, or delete it and *not* add a new config option. This keeps us on the original path whereby we\u0027ll drop support for non-live snapshots eventually.","commit_id":"f6e3a88edef9e67ff8ae9e3298e2be2cb5c8a0e5"}],"nova/conf/libvirt.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cb4f8a6a1dbee6d96639f7d650cd18ee3cc454d2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_5c084b28","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":44},"updated":"2016-10-03 13:27:38.000000000","message":"Typo; According to the reno this should be ``live_migrate_livesnapshot``, which is the cause of UT failing.","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"ade0b162d42a929643a51649b98b761fb2e42f8e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_bfadc1ea","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":31},"updated":"2016-10-03 13:45:10.000000000","message":"could you please explain why do you use live_migration prefix here?","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84a1dc5a55a7d5ac3382c64f1dadc09ace7d3d05","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_ce173343","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":31},"in_reply_to":"3a98d1f4_2bb5e97c","updated":"2016-10-03 18:06:29.000000000","message":"\u003e \u003e could you please explain why do you use live_migration prefix here?\n \u003e Good point - I\u0027ll drop it.\n\nActually, all the other live migration-related options in this file are prefixed with \u0027live_migration\u0027. I did this to be consistent","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"576ec5ed71460f70900aeedd5016fae93a768818","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_4bb87575","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":44},"in_reply_to":"3a98d1f4_5c084b28","updated":"2016-10-03 18:02:28.000000000","message":"Done","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8b406ced11e31016a57cdb4f35866d25bcd55868","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_95335d13","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":31},"in_reply_to":"3a98d1f4_69c7e763","updated":"2016-10-04 10:25:45.000000000","message":"Yes, I was about to comment to the effect of what Timofey says - that \"live_migration\" prefix is incorrect.  It is about live snapshots.  Let\u0027s just call it:\n\n \u0027live_snapshot\u0027 \u003d enable | disable","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"576ec5ed71460f70900aeedd5016fae93a768818","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_2bb5e97c","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":31},"in_reply_to":"3a98d1f4_bfadc1ea","updated":"2016-10-03 18:02:28.000000000","message":"\u003e could you please explain why do you use live_migration prefix here?\n\nGood point - I\u0027ll drop it.","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"8712c5482d840e0b1060e2352fbe2fd4af595734","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                     \u0027will choose a sensible default based on, for example \u0027"},{"line_number":259,"context_line":"                     \u0027the availability of native encryption support in the \u0027"},{"line_number":260,"context_line":"                     \u0027hypervisor.\u0027),"},{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027live_migration_livesnapshot\u0027,"},{"line_number":262,"context_line":"        default\u003dTrue,"},{"line_number":263,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":264,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_69c7e763","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":31},"in_reply_to":"3a98d1f4_ce173343","updated":"2016-10-04 07:46:58.000000000","message":"yeah, but it\u0027s about snapshot, not live_migration, I\u0027ve checked that code, this option is for snapshots","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8b406ced11e31016a57cdb4f35866d25bcd55868","unresolved":false,"context_lines":[{"line_number":269,"context_line":"interruption to the guest, using coordination with a guest agent to"},{"line_number":270,"context_line":"quiesce the filesystem."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"When using libvirt 1.2.2, live snapshots fail intermittently under load."},{"line_number":273,"context_line":"This is likely related to concurrent libvirt/qemu operations). This config"},{"line_number":274,"context_line":"option provides a mechanism to disable live snapshot, in favor of cold"},{"line_number":275,"context_line":"snapshot, when this issue is encountered. Cold snapshot causes an instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_103d9bc3","line":272,"updated":"2016-10-04 10:25:45.000000000","message":"This should be reworded, as it is only occurring intermittently in upstream CI, and not reproducible across the board (see the bug below).\n\nI\u0027d say something like: \"When using libvirt 1.2.2, upstream CI environment has observed intermittent failures with live snapshots under load\"","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8b406ced11e31016a57cdb4f35866d25bcd55868","unresolved":false,"context_lines":[{"line_number":273,"context_line":"This is likely related to concurrent libvirt/qemu operations). This config"},{"line_number":274,"context_line":"option provides a mechanism to disable live snapshot, in favor of cold"},{"line_number":275,"context_line":"snapshot, when this issue is encountered. Cold snapshot causes an instance"},{"line_number":276,"context_line":"outage while the guest is going through the snapshotting process."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"For more information, refer to the bug report:"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_904feb69","line":276,"updated":"2016-10-04 10:25:45.000000000","message":"\"Cold snapshot causes an instance outage\" -\u003e \"Cold snapshot causes the instance to be paused\"","commit_id":"ede5991002556f690225a779bb86730fd7ed051a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"adf5bf38d385e00d046437de8765d9c55290ed06","unresolved":false,"context_lines":[{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.BoolOpt(\u0027use_live_snapshot\u0027,"},{"line_number":340,"context_line":"        default\u003dTrue,"},{"line_number":341,"context_line":"        deprecated_name\u003d\u0027disable_libvirt_livesnapshot\u0027,"},{"line_number":342,"context_line":"        deprecated_group\u003d\u0027workarounds\u0027,"},{"line_number":343,"context_line":"        help\u003d\"\"\""},{"line_number":344,"context_line":"Configure live snapshots."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_f06e6ffe","line":341,"updated":"2016-10-04 10:43:22.000000000","message":"You can\u0027t use deprecated_name in this scenario, as the old / new configuration parameters have inverse meaning from each other. The deprecation only possible if the old/new parameters are semantically the same.\n\nThe whole point of having the workarounds option group is that these are options where we explicitly do *not* provide any upgrade compatibility - they\u0027re one-off version specific hacks. \n\nSo there is no reason to try to setup deprecations at all. Just delete the workaround and add the new option.\n\nIMHO you can just call this \"live_snapshot\" - the \"use_\" prefix does not add any value","commit_id":"f6e3a88edef9e67ff8ae9e3298e2be2cb5c8a0e5"}],"releasenotes/notes/rename-disable_libvirt_livesnapshot-opt-ea4eb4f33d9a77da.yaml":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1490308443785f22928acbf4c6d5738d2d3dc0ff","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``workarounds.disable_livesnapshot`` option has been renamed to"},{"line_number":5,"context_line":"    ``libvirt.use_live_snapshot`` and is now enabled by default. To retain"},{"line_number":6,"context_line":"    pre-Newton behavior, set the new configuration option to False."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a98d1f4_cb6c68d2","line":6,"updated":"2016-10-04 10:44:07.000000000","message":"You\u0027ve not merely renamed it - you\u0027ve inverted the meaning. ie\n\n  disable_livesnapshot\u003dTrue  !\u003d use_live_snapshot\u003dTrue","commit_id":"f6e3a88edef9e67ff8ae9e3298e2be2cb5c8a0e5"}]}