)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f05c138568a2a6d14f75bdf846517c9150cb98f","unresolved":false,"context_lines":[{"line_number":841,"context_line":"            max_rows \u003d int(max_rows)"},{"line_number":842,"context_line":"            if max_rows \u003c 0:"},{"line_number":843,"context_line":"                print(_(\"Must supply a positive value for max_rows\"))"},{"line_number":844,"context_line":"                return(2)"},{"line_number":845,"context_line":"            if max_rows \u003e db.MAX_INT:"},{"line_number":846,"context_line":"                print(_(\u0027max rows must be \u003c\u003d %(max_value)d\u0027) %"},{"line_number":847,"context_line":"                      {\u0027max_value\u0027: db.MAX_INT})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_d88779d5","line":844,"updated":"2016-09-29 19:53:37.000000000","message":"Hmm, so this changes behavior, I\u0027m not sure we should do that in case someone had scripted to this. Although in reality if you scripted to rc\u003d2 then the script is busted anyway, so I\u0027d expect anyone scripting this would be checking for 0 and non-0 is considered an error.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0cc30701b5dde674fe2544495f017b5a7658b60","unresolved":false,"context_lines":[{"line_number":841,"context_line":"            max_rows \u003d int(max_rows)"},{"line_number":842,"context_line":"            if max_rows \u003c 0:"},{"line_number":843,"context_line":"                print(_(\"Must supply a positive value for max_rows\"))"},{"line_number":844,"context_line":"                return(2)"},{"line_number":845,"context_line":"            if max_rows \u003e db.MAX_INT:"},{"line_number":846,"context_line":"                print(_(\u0027max rows must be \u003c\u003d %(max_value)d\u0027) %"},{"line_number":847,"context_line":"                      {\u0027max_value\u0027: db.MAX_INT})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_bbd2a7d0","line":844,"in_reply_to":"3a98d1f4_d88779d5","updated":"2016-09-29 20:12:28.000000000","message":"I think we\u0027re pretty safe since this is not a useful return code for scripting, really. It means that you provided something unreasonable for that parameter, not that anything went wrong when you were expecting this to work.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"}],"tools/hooks/post_test_hook.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f05c138568a2a6d14f75bdf846517c9150cb98f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_7b273fb6","line":8,"updated":"2016-09-29 19:53:37.000000000","message":"I guess we\u0027re leaving this in here as a hard limit in case something goes crazy, so we can avoid an infinite loop. The job would eventually timeout, but yeah.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0cc30701b5dde674fe2544495f017b5a7658b60","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_bbe9c782","line":8,"in_reply_to":"3a98d1f4_7b273fb6","updated":"2016-09-29 20:12:28.000000000","message":"Yep. Right now we complete after four runs. If we wait for the timeout, we\u0027re just going to spin hard doing nothing.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f05c138568a2a6d14f75bdf846517c9150cb98f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"},{"line_number":12,"context_line":"\t    break;"},{"line_number":13,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_fb3b4fcf","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":13},"updated":"2016-09-29 19:53:37.000000000","message":"How about -eq 0 to be specific? If you got 2 back this would pass.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f05c138568a2a6d14f75bdf846517c9150cb98f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"},{"line_number":12,"context_line":"\t    break;"},{"line_number":13,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_7864a521","line":10,"updated":"2016-09-29 19:53:37.000000000","message":"tab weirdness?","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0cc30701b5dde674fe2544495f017b5a7658b60","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"},{"line_number":12,"context_line":"\t    break;"},{"line_number":13,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_dbecd391","line":10,"in_reply_to":"3a98d1f4_7864a521","updated":"2016-09-29 20:12:28.000000000","message":"Gah, sorry.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0cc30701b5dde674fe2544495f017b5a7658b60","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"\tif [[ $? -ne 1 ]]; then"},{"line_number":11,"context_line":"\t    echo Archiving Complete"},{"line_number":12,"context_line":"\t    break;"},{"line_number":13,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a98d1f4_3b95b7dd","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":13},"in_reply_to":"3a98d1f4_fb3b4fcf","updated":"2016-09-29 20:12:28.000000000","message":"well, it would stop if you get 2, which is what I was going for. I should probably catch other values and explicitly fail though, yeah.","commit_id":"30a74f77fd2707c19c6562cb4fc3642c203f2ec5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66a1e6552adb8f40add3a0c1a47617c45586e7e6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        $MANAGE db archive_deleted_rows --verbose --max_rows 1000"},{"line_number":10,"context_line":"        if [[ $? -gt 1 ]]; then"},{"line_number":11,"context_line":"            echo Archiving failed with result $?"},{"line_number":12,"context_line":"            return $?"},{"line_number":13,"context_line":"        elif [[ $? -eq 0 ]]; then"},{"line_number":14,"context_line":"            echo Archiving Complete"},{"line_number":15,"context_line":"            break;"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a98d1f4_07797cc8","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":21},"updated":"2016-09-29 22:08:58.000000000","message":"This is going to be the return code of the echo command, so if you really want this, you\u0027ll need to save the rc from the archive command and use it as a variable throughout. That\u0027s probably what you should do anyway.","commit_id":"53b2086803a1f099c636444f9f4ad30890e0de4c"}]}