)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6515fb3346062e0374e847c69c75161dbe6f927","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kashi Reddy \u003ckashi.reddy@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-22 20:16:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove hostname from xenstore params after first boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removes hostname from xenstore params in first boot"},{"line_number":10,"context_line":"after networkreset. hostname being present was causing issue"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2Fx6M%3D","line":7,"updated":"2013-07-23 12:15:47.000000000","message":"maybe add xenapi: or mention its XenAPI only below.","commit_id":"8f3dcd15c4305aadeb29819ac58e2c5db12a45e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6515fb3346062e0374e847c69c75161dbe6f927","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove hostname from xenstore params after first boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removes hostname from xenstore params in first boot"},{"line_number":10,"context_line":"after networkreset. hostname being present was causing issue"},{"line_number":11,"context_line":"with changing hostname on windows"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2Fx58%3D","line":9,"updated":"2013-07-23 12:15:47.000000000","message":"Probably need to explain that the hostname flag is picked up by the XenAPI PV tools on windows.\n\nHowever, this causes the hostname to be reset back to the original name on ever reboot, which is very confusing.","commit_id":"8f3dcd15c4305aadeb29819ac58e2c5db12a45e0"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"97f10d329d5f0a0cb9a25a5626be674b8294826f","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        @step"},{"line_number":471,"context_line":"        def remove_hostname(undo_mgr, vm_ref):"},{"line_number":472,"context_line":"            self.remove_hostname(instance, vm_ref)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        @step"},{"line_number":475,"context_line":"        def bdev_set_default_root(undo_mgr):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F188%3D","line":472,"updated":"2013-07-22 09:35:30.000000000","message":"This is not worth an extra step, its really quick, and this will make the progress reporting a bit worse I suspect. I would do this inside _boot_new_instance for now, after the reset network","commit_id":"7ac5f45591d60de6ccc98b36daebdcac1d89c31e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"97f10d329d5f0a0cb9a25a5626be674b8294826f","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        LOG.debug(_(\"Injecting hostname to xenstore\"), instance\u003dinstance)"},{"line_number":1624,"context_line":"        self._add_to_param_xenstore(vm_ref, \u0027vm-data/hostname\u0027, hostname)"},{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"    def remove_hostname(self, instance, vm_ref):"},{"line_number":1627,"context_line":"        LOG.debug(_(\"Removing hostname from xenstore\"), instance\u003dinstance)"},{"line_number":1628,"context_line":"        self._remove_from_param_xenstore(vm_ref, \u0027vm-data/hostname\u0027)"},{"line_number":1629,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F180%3D","line":1626,"updated":"2013-07-22 09:35:30.000000000","message":"Please just add a unit test in test_vmops to check this method does what you expect, and errors correctly. probably want to silently fail if the key is already missing, etc.","commit_id":"7ac5f45591d60de6ccc98b36daebdcac1d89c31e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6515fb3346062e0374e847c69c75161dbe6f927","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            # Reset network config"},{"line_number":704,"context_line":"            agent.resetnetwork()"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        self.remove_hostname(instance, vm_ref)"},{"line_number":707,"context_line":"        # Set VCPU weight"},{"line_number":708,"context_line":"        instance_type \u003d flavors.extract_flavor(instance)"},{"line_number":709,"context_line":"        vcpu_weight \u003d instance_type[\u0027vcpu_weight\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fx6c%3D","line":706,"updated":"2013-07-23 12:15:47.000000000","message":"There is no way we can know if the tools will have set the hostname by this point, but this is a reasonable compromise. Its late enough in the case where the agent is used, in other cases, cloud-init should really be used to set the hostname.","commit_id":"8f3dcd15c4305aadeb29819ac58e2c5db12a45e0"}]}